Re: [MMUSIC] ICE-SIP-SDP: Concluding ICE statement

[Roman Shpount <[e-mail]>]

On Tue, Jul 23, 2019 at 6:10 PM Christer Holmberg <
[e-mail]> wrote:

> >> "Once the agent has successfully nominated a pair, the state of the
> check list associated with the pair is set to Completed.
> >> Once the state of each check list is set to either Completed or Failed,
> for each Completed check list the
> >> agent checks whether the nominated pair matches the default candidate
> pair. If there are one or more pairs that don't match,..."
> >
> > I am still unclear about Failed. I would prefer the last sentence to say:
> >
> > Once the agent has successfully nominated a pair, the state of the check
> list associated with the pair is set to Completed.
> > Once the state of each check list is set to either Completed or Failed,
> for each >Completed check list the
> > agent checks whether the nominated pair matches the default candidate
> pair. If there are one or more pairs that don't match,
> > or if there are any Failed check lists, and the peer did not indicate
> support for the 'ice2' ice-option, the controlling agent MUST
> > generate a subsequent offer (Section 3.4.1), in which the connection
> address, port and transport protocol in the "c=" and "m="
> > lines associated with each data stream match the corresponding local
> information of the nominated pair for that data stream.
> > Data streams associated with a Failed check lists MUST be rejected by
> setting port in "m=" line to zero.
>
> If there are Failed check lists, shouldn't there be a subsequent update
> with port set to zero no matter if there is 'ice2' or not?
>
> RFC 8445 says that "The agent MUST take proper actions for removing the
> failed data stream."
>
>
You are right and I would assume ice-sip-sdp should spell this out. How
about:

Once the agent has successfully nominated a pair, the state of the check
list associated with the pair is set to Completed. Once the state of each
check list is set to either Completed or Failed, for each Completed check
list the agent checks whether the nominated pair matches the default
candidate pair. If there are one or more pairs that don't match, and the
peer did not indicate support for the 'ice2' ice-option, the controlling
agent MUST generate a subsequent offer (Section 3.4.1), in which the
connection address, port and transport protocol in the "c=" and "m=" lines
associated with each data stream match the corresponding local information
of the nominated pair for that data stream. Furthermore, if there are any
Failed check lists, the controlling agent MUST always generate a subsequent
offer, even if  the peer did indicate support for the 'ice2' ice-option.
This offer MUST reject all data streams associated with a Failed check
lists by setting port in "m=" line to zero.

Best Regards,
_____________
Roman Shpount