[MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks
Adam Roach <adam@nostrum.com> Wed, 05 June 2019 22:50 UTC
Return-Path: <adam@nostrum.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43A7212011D for <mmusic@ietfa.amsl.com>; Wed, 5 Jun 2019 15:50:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.68
X-Spam-Level:
X-Spam-Status: No, score=-1.68 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rzpAG2wSO_LG for <mmusic@ietfa.amsl.com>; Wed, 5 Jun 2019 15:50:07 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30752120043 for <mmusic@ietf.org>; Wed, 5 Jun 2019 15:50:07 -0700 (PDT)
Received: from MacBook-Pro.roach.at (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x55Mo4le053515 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 5 Jun 2019 17:50:05 -0500 (CDT) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1559775006; bh=/2TSbJuohrhaOJrdvS+c1RgUeIrRmf0kjB1N09l7mwg=; h=To:From:Subject:Date; b=V0GWmsL1nbSEgETUAKPTkkxDs/T4cdPQFV5mvW9gzeXEQxZLNH3/QxgYefteNoLTn sRFU2wCpGY7i2ePveMr0wjeFDDbSswOTraURXeL0VTgeBjnN6Cbe0wHlMeWOHnadKn 8zMm33diHE93veggMg0icacaYmAu88ShOG5EkBlk=
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be MacBook-Pro.roach.at
To: draft-ietf-mmusic-sdp-uks@tools.ietf.org, "mmusic@ietf.org" <mmusic@ietf.org>
From: Adam Roach <adam@nostrum.com>
Message-ID: <2b3651f8-c2f2-fcd2-1883-16de305391f3@nostrum.com>
Date: Wed, 05 Jun 2019 17:49:59 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/9ezwC218CghvH454X_qjOarXQRo>
Subject: [MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2019 22:50:09 -0000
This is my AD review for draft-ietf-mmusic-sdp-uks. It is uncharacteristically short, as I have already reviewed earlier versions of this document and provided feedback to the authors. None of my comment preclude putting the document into IETF last call. Please address them along with any other comments that may arise during the last call process. Thanks! --------------------------------------------------------------------------- Please update the abstract to indicate that this document updates RFC 8122. --------------------------------------------------------------------------- §1: > entity. A successful attack leads to the creation of sessions where > peers are confused about the identify of the participants. Nit: "...identity of..." --------------------------------------------------------------------------- §4.3: > This is considered benign since these protocols are usually > distinguishable. Suggest: s/usually/designed to be/ (there are specific forbidden PT values reserved to avoid collisions with RTCP -- 72 through 76, to be specific)
- [MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks Adam Roach
- Re: [MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks Martin Thomson