Re: [MMUSIC] Draft new version: BUNDLE-35 - Colin's comments
Colin Perkins <csp@csperkins.org> Wed, 26 October 2016 15:39 UTC
Return-Path: <csp@csperkins.org>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B15E129677 for <mmusic@ietfa.amsl.com>; Wed, 26 Oct 2016 08:39:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tVOvX3cOpGA7 for <mmusic@ietfa.amsl.com>; Wed, 26 Oct 2016 08:39:31 -0700 (PDT)
Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 23E0412966E for <mmusic@ietf.org>; Wed, 26 Oct 2016 08:39:31 -0700 (PDT)
Received: from [130.209.247.112] (port=55343 helo=mangole.dcs.gla.ac.uk) by balrog.mythic-beasts.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from <csp@csperkins.org>) id 1bzQIZ-0001i7-VV; Wed, 26 Oct 2016 16:39:29 +0100
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Colin Perkins <csp@csperkins.org>
In-Reply-To: <D4362E14.11C83%christer.holmberg@ericsson.com>
Date: Wed, 26 Oct 2016 16:39:27 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <4A987293-1DC3-47ED-BC78-E335026C7566@csperkins.org>
References: <D4362E14.11C83%christer.holmberg@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3124)
X-BlackCat-Spam-Score: -28
X-Mythic-Debug: Threshold = On =
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/BRhrPSrAK4CQrQfqP_j9Bh7Wob8>
Cc: "mmusic@ietf.org" <mmusic@ietf.org>
Subject: Re: [MMUSIC] Draft new version: BUNDLE-35 - Colin's comments
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2016 15:39:35 -0000
Hi, > On 26 Oct 2016, at 08:20, Christer Holmberg <christer.holmberg@ericsson.com> wrote: > > Hi Colin, > > Thanks for your comments! See inline. > >>> On 25 Oct 2016, at 11:24, Christer Holmberg >>> <christer.holmberg@ericsson.com> wrote: >>> >>> Iąve submitted a new version (-35) of BUNDLE. >>> >>> The text now talks about łassociating RTP streams with m- lines˛ >>> (instead of associating RTP packets). >> >> I think this new text is good, and addresses most of my concerns. I just >> have a few details outstanding: >> >> - Section 9.1, last paragraph: I suggest changing łassociate a received >> (S)RTP packet with˛ to łassociate the packets in a received SRTP stream >> with˛. > > Iąll fix as suggested. > > Iąll also change Section 1, which still talks about associating RTP > packets with m- lines. > > >> - Section 10.1, 1st paragraph: The second sentence (łDisjoint BUNDLE >> groups will form multiple RTP sessions, one per BUNDLE group˛) is >> probably true, but depends on the RTP topology, since a middlebox could >> bridge the different BUNDLE groups together into a single RTP session. I >> suggest deleting this sentence. > > Iąll remove it. > >> >> >> - Section 10.2, 1st paragraph: At the end of the first sentence, you >> might cite RFC7656 for the definition of the term RTP Stream. > > Iąll add a reference. > > >> - Section 10.2, 7th paragraph: This seems correct, but I found the >> phrasing unclear. Something like the following might be clearer: >> >> The mapping from an SSRC to an identification-tag is carried in RTCP >> SDES packets or in RTP header extensions, as described in Section 14. >> Since a compound RTCP packet can contain multiple RTCP SDES packets, >> and each RTCP SDES packet can contain multiple chunks, an RTCP packet >> can contain several SSRC to identification-tag mappings. The offerer >> and answerer maintain tables mapping RTP streams identified by SSRC, >> to łm=ł lines identified by the identification-tag. These tables are >> updated each time an RTP/RTCP packet containing one or more mappings >> from SSRC to identification-tag is received. Note that the mapping >> from SSRC to identification-tag can change at any time during an RTP >> session. > > > Iąll change as suggested. > > >> - Section 10.2, 8th paragraph: The last sentence might be clearer written >> łNote that RTCP packets can report on multiple RTP streams˛. > > Iąll change as suggested. > >> Also, the XML formatting is messed up in the middle of the paragraph. > > It looks ok in my editor :) > > OTOH, I have changed editor recently, so there are lots of instances where > the XML does look a little messy. I meant that the XML codes are appearing in the text version of the draft. >> - Section 14, 3rd paragraph: Suggest changing łŠto associate received >> RTCP- and RTP packets withŠł to łŠto associated each RTP stream withŠ˛. > > Iąll change as suggested. > > Pull request can be found at: > > https://github.com/cdh4u/draft-sdp-bundle/pull/14 Thanks. -- Colin Perkins https://csperkins.org/
- Re: [MMUSIC] Draft new version: BUNDLE-35 - Colin… Christer Holmberg
- Re: [MMUSIC] Draft new version: BUNDLE-35 - Colin… Colin Perkins
- Re: [MMUSIC] Draft new version: BUNDLE-35 - Colin… Christer Holmberg