Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ietf-mmusic-ice-sip-sdp-38: (with DISCUSS and COMMENT)
Suhas Nandakumar <suhasietf@gmail.com> Wed, 14 August 2019 00:59 UTC
Return-Path: <suhasietf@gmail.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E952120811; Tue, 13 Aug 2019 17:59:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9AlyWzhhm7SN; Tue, 13 Aug 2019 17:59:06 -0700 (PDT)
Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D905E120807; Tue, 13 Aug 2019 17:59:05 -0700 (PDT)
Received: by mail-ua1-x92d.google.com with SMTP id c4so15397472uad.1; Tue, 13 Aug 2019 17:59:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6mSGt16W/kjBOI2mBdnyleHQ7Oys8vteftHz6LuxCCw=; b=m+Qd8E8hzQO4v1gjEv91sT514ZjUFy7V6WwfPXoUXVIHn4VO2fQtpoWoyKI9j5mcMR rZ+I5Pw8gFD193QDDBhFW+a6PEFGAm/3hGR9RDR1MFc8QtGwmXvAtotHeC02NiDgafff W+XiZdlHRKn3g16zEHmz7KWoQ+Q76h0fzuXwd1aC1sFcjEjLXUQ+e8YUWW6BXoLB7Maj k8bHqcO+0pntaYWm2qEoVnQ1E89u5vJdX+KKh2SmPOOFQHR/3kf4i2TVb1MFxfP2wSyS rfKkBKO0k1FuYG8Uqi4JOtJDz0suXrRNu3L+gjFx4ml784acU5d2/0sELjtmbe1JxkZp Xb0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6mSGt16W/kjBOI2mBdnyleHQ7Oys8vteftHz6LuxCCw=; b=ZbYrIK/zgtqNyL589hdsTwDYdQeCgj95rUOekOiU0ilUA7vCzR6Ry0RRJGgJWO64VK 4193QZ8Kmx93PqUv1L7gz8x+3iN9hZfedM3HhxmjbshR21cot56BYfr+RLaXCFObhS2P 5WyWDh06AJ4JnYUMSLpJ+zKpek5+edVzkvqPoz4mSed3JAYh3K07+LGvkW8Zy0Zl28B9 dT3mdnZ7FeiH60eQSkiVIH0eeic7gg3LX/GA59g7NwI8GBo8HTiArp+RgRUE3+PYu0/t N49NVPKgLuXx1x8HdD4ki1VOq+Md9e8bKzrnlur29IhS3NzC+AHNpzuJPhiRTNsSckme mHKg==
X-Gm-Message-State: APjAAAWrUI/ryMHBfWR3+ce0QzB2VFV7Kuuq5Gj2/wowvkQcBgirhUcT PAvbxBUu3CgzdO5uXNc4MxWiwjU8M4hstupQ/kQ=
X-Google-Smtp-Source: APXvYqz6t3qcC4lYMuV0UbxCBVxtq6NyulqjKtP8N1stPnTxlempbfJAtQU3w8FwbfGlKLLfRPbhcVYPZCyEgq5e1LY=
X-Received: by 2002:ab0:3247:: with SMTP id r7mr288672uan.5.1565744344643; Tue, 13 Aug 2019 17:59:04 -0700 (PDT)
MIME-Version: 1.0
References: <156537593203.15838.12286824910808417510.idtracker@ietfa.amsl.com> <48D3EDF4-EDEC-4D69-BDDC-258104A90FF3@ericsson.com> <CAMRcRGS-2p9ymeUVGdNd0NUZZf30bxXNWCOF4nr-J0EPkwACHg@mail.gmail.com> <F160B56B-8A54-4D9C-8120-E31BDE2543FC@ericsson.com> <20190813143624.GK88236@kduck.mit.edu>
In-Reply-To: <20190813143624.GK88236@kduck.mit.edu>
From: Suhas Nandakumar <suhasietf@gmail.com>
Date: Tue, 13 Aug 2019 17:58:53 -0700
Message-ID: <CAMRcRGS3QrbqOusLfoOp06MKoHQjOkKSuSeUYfRpMvvSnwOK0g@mail.gmail.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: Christer Holmberg <christer.holmberg@ericsson.com>, "adam@nostrum.com" <adam@nostrum.com>, The IESG <iesg@ietf.org>, "fandreas@cisco.com" <fandreas@cisco.com>, "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>, "draft-ietf-mmusic-ice-sip-sdp@ietf.org" <draft-ietf-mmusic-ice-sip-sdp@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000078be2b05900943fc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/HB09faXgGL8HgiVHFSZUQiHP4sY>
Subject: Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ietf-mmusic-ice-sip-sdp-38: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Aug 2019 00:59:22 -0000
We just submitted version -39 addressing pending IESG DISCUSS comments. please let us know thanks Suhas On Tue, Aug 13, 2019 at 7:36 AM Benjamin Kaduk <kaduk@mit.edu> wrote: > Hi Christer, > > Thanks, this all sounds good to me (and I'm happy to defer to Adam about > the IPv6 examples). > > -Ben > > On Sun, Aug 11, 2019 at 09:28:21AM +0000, Christer Holmberg wrote: > > Hi Benjamin, > > > > The following pull request addresses most of your remaining issues that > were not addressed in version -38: > > > > https://github.com/suhasHere/ice-sip-sdp/pull/20 > > > > NOTE 1: I have not yet updated any examples with IPv6 addresses. I’d > like Adam to comment on that, since he previously said it shouldn’t be done. > > > > NOTE 2: I will copy the IP address privacy text from Section 5.1 to the > Security Considerations once Suhas has incorporated the changes I did to > the Security Considerations in another pull request. > > > > NOTE 3: Regarding the rtcp attribute, I still think we shall not use > SHOULD/MAY normative language, as we now align with the existing procedures > in RFC 3605. However, I have added a Note that describes the change from > RFC 5245, and the rtcp attribute change is also mentioned in the “Changes > to RFC 5245” section that was added to the -38 version. > > > > Also, I don’t remember whether you commented on the need for an IANA > registry for the candidate attribute extensions, but FYI I have created a > pull request for that too: > > > > https://github.com/suhasHere/ice-sip-sdp/pull/19 > > > > Regards, > > > > Christer > > > > > > > > From: Suhas Nandakumar <suhasietf@gmail.com> > > Date: Sunday, 11 August 2019 at 5.33 > > To: Christer Holmberg <christer.holmberg@ericsson.com> > > Cc: Benjamin Kaduk <kaduk@mit.edu>, "iesg@ietf.org" <iesg@ietf.org>, > Flemming Andreasen <fandreas@cisco.com>, "mmusic-chairs@ietf.org" < > mmusic-chairs@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>, " > draft-ietf-mmusic-ice-sip-sdp@ietf.org" < > draft-ietf-mmusic-ice-sip-sdp@ietf.org> > > Subject: Re: [MMUSIC] Benjamin Kaduk's Discuss on > draft-ietf-mmusic-ice-sip-sdp-38: (with DISCUSS and COMMENT) > > > > > > > > On Fri, Aug 9, 2019 at 11:54 AM Christer Holmberg < > christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> > wrote: > > Hi, > > > > First, as I also indicated to Alexey, the new version of the draft > was submitted before all IESG issues had been resolved, due to a > misunderstanding among the authors. Sorry for the confusion. > > > > > ---------------------------------------------------------------------- > > DISCUSS: > > > ---------------------------------------------------------------------- > > > > >A fairly minor point, but the example in Section 5.6 is not > compliant > > >with the ABNF for the ice-options production, which uses SP to > separate > > >different ice-option-tag values; the example uses a comma. > > > > DOH! I will fix that, and remove the comma. > > > > > ---------------------------------------------------------------------- > > COMMENT: > > > ---------------------------------------------------------------------- > > > > >Thank you for addressing most of my comments from the -37! A few > > >still remain, below. > > > > > >Can you remind me why the discussion of an additional three-second > > >waiting period for SIP with forking was removed from (now-) Section > 7? > > > > I removed the paragraph because I don't think there was anything SIP > specific about it. > > > > Also, my intention was to move the text about forking to Section > 7.3, but that's another thing I didn't have time to do before the new > version was submitted. > > > > >Do we have anywhere a definition of what it means to "indicate ICE > > >support in an SDP offer/answer"? (As distinct from ice2 support.) > I remember > > >some discussion about containing a ufrag/password being enough, but > that > > >doesn't seem to have ended up in the document. > > > > That’s another thing still to be done. > > > > --- > > > > Section 4.2.2 > > > > > Aren't "rtcp attribute SHOULD be included" and "rtcp attribute MAY > be > > > omitted" just duplicating existing normative requirements from > previous > > > specifications (which thus would not need new normative language > here)? > > > I think we talked about how this is slightly different from some > of the previous > > > relevant specifications, so calling out any differences here might > be worthwhile. > > > > I agree that would be useful. > > > > --- > > > > > Section 5.1 > > > > > > I appreciate that IP address privacy is mentioned here. (It might > > > be good in the security considerations, too.) > > > > Another thing I didn't do before the new version was submitted. I > will fix that. > > > > --- > > > > Section 9 > > > > > I think this top-level section would be a great place to reiterate > that > > > the SDP and ICE security considerations apply, since we are using > both > > > of them in combination. Specifically, the IP Address Privacy > concerns > > > are only briefly mentioned elsewhere in the document, and could be > worth > > > reiterating. > > > > That's strange. I had done that change in the pull request ( > https://github.com/suhasHere/ice-sip-sdp/pull/18/files< > https://protect2.fireeye.com/url?k=035ce5d6-5fd54a1f-035ca54d-0cc47ad93e1c-d6a6721d40020605&q=1&u=https%3A%2F%2Fgithub.com%2FsuhasHere%2Fice-sip-sdp%2Fpull%2F18%2Ffiles > >). > > > > In fact, it seems like none of the changes to the security > considerations have been incorporated. Suhas? > > > > [Suhas] That was an oversight Christer. We can ensure the differential > gets added in the follow up version. > > Sorry for the confusion. > > > > > > Regards, > > > > Christer > > > > > > > > > > _______________________________________________ > > mmusic mailing list > > mmusic@ietf.org<mailto:mmusic@ietf.org> > > https://www.ietf.org/mailman/listinfo/mmusic >
- [MMUSIC] Benjamin Kaduk's Discuss on draft-ietf-m… Benjamin Kaduk via Datatracker
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Christer Holmberg
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Suhas Nandakumar
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Christer Holmberg
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Christer Holmberg
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Adam Roach
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Roman Shpount
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Benjamin Kaduk
- Re: [MMUSIC] Benjamin Kaduk's Discuss on draft-ie… Suhas Nandakumar