Re: [MMUSIC] Shepherd's review of draft-ietf-msrp-usage-data-channel-17

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 13 June 2020 11:20 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB4393A07DF; Sat, 13 Jun 2020 04:20:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uql2TWtDewn5; Sat, 13 Jun 2020 04:20:03 -0700 (PDT)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B44543A07DE; Sat, 13 Jun 2020 04:19:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afxKLeV7AqLGmCGvK3s4vibLbXNoW4qvGNdVsc1PHPSZw62V/o1DywGxqSqxj/N1YtyHVb7ulOsAnMs0HslP0GD8jIUPDRYyl5Z6sJh3Ex121IFGF/F+uoFQ2iD+XKItFNZBSZOoQZWhbpqvKIg3e2QvX3dNAOwuBPaQ7SdJyubzx7xWZgLR68kObV9Fn1BDaZ4ETT4uAMq+MZLNAocdHvSSxHGfmL3dBNZOMF0Cr4uEpGINDSjDIGfpIFd/feMHvqabmxB7K17yMXK804GVvZhC/guVWtlOIGglkWuXgn7Of65zOhYwaQX9vxCkzZsZiOGpmoAVoqgm6+tF70EKyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LC2yuLaGViR5ldwOJ2RJc6t6K+tkCm/33H2c/yO91Q=; b=GU1t3bZqw6zePWdCLoe3g2kn2eMrBDjhJxoID6z3Z16nslct9Kvh3fzZxp0BYg2DzMZZPA0BJdUHZ2Ojnb0nfi4XC8BCukexRetKjmdK6eiUGq6phe2qCuT84S5UTDvvyMRjN6GJQ5fJWFlfRrOEvPa1FijawlQUHiS02qd4qMzPdy8kPOVutcyOEl4qEum1sLdZj+b1GKZXqsKkMVawr4e5C5KDuP0+1Mi4noTvW+CUG3GowGx0L1McbbHj5oOQIqL9Fj4YybunF4y0/Y85jzP+GRrzHM+jzZCU+L8nmnXqatrh+4pc44ilEAyKuE4sLpKlpWcJX6W5p9wfBRnvLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LC2yuLaGViR5ldwOJ2RJc6t6K+tkCm/33H2c/yO91Q=; b=hNzEfyF11MU56C77b7T2vxqApp9IjoIDktiyNohxpie2kIi4Ri8T78WhLjEYlMQTFiysNZh0g34vnEse8Mf9tyReEFrFrMk4nopL7PO5J0im4606uBLMd1mPNc/XArWRWKSFYAppj2gkMjtntx+xy1CERkdjaPe7W8jzRn5AsKo=
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com (2603:10a6:20b:1bc::19) by AM6PR07MB5560.eurprd07.prod.outlook.com (2603:10a6:20b:6f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.7; Sat, 13 Jun 2020 11:19:54 +0000
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::7529:b51f:5fb4:62b9]) by AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::7529:b51f:5fb4:62b9%5]) with mapi id 15.20.3109.011; Sat, 13 Jun 2020 11:19:54 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Jose M Recio <jose@ch3m4.com>, Bo Burman <bo.burman@ericsson.com>, "draft-ietf-mmusic-msrp-usage-data-channel.authors@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.authors@ietf.org>, mmusic <mmusic@ietf.org>
CC: "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>
Thread-Topic: Shepherd's review of draft-ietf-msrp-usage-data-channel-17
Thread-Index: AdY+tQCYaK/SvE0yRXW9AL9PPo+jrQAZbleAAItYQQAACpsHsA==
Date: Sat, 13 Jun 2020 11:19:54 +0000
Message-ID: <AM7PR07MB70120FBCE7DBCAD9C2F105A5939E0@AM7PR07MB7012.eurprd07.prod.outlook.com>
References: <HE1PR07MB4426977EA914E7253488C5D08D820@HE1PR07MB4426.eurprd07.prod.outlook.com> <AM7PR07MB70122C5F1138C66FA8FBAB5193830@AM7PR07MB7012.eurprd07.prod.outlook.com> <7435addc-a61f-541d-b382-29727cc8a7a5@ch3m4.com>
In-Reply-To: <7435addc-a61f-541d-b382-29727cc8a7a5@ch3m4.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ch3m4.com; dkim=none (message not signed) header.d=none;ch3m4.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.127.223.154]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6771146a-7963-4df6-2aa8-08d80f8bb2a2
x-ms-traffictypediagnostic: AM6PR07MB5560:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR07MB5560DA511279190661C92237939E0@AM6PR07MB5560.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 0433DB2766
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: XcX6LfwEXTXw6RzB38PIaulH6HoQf3DQ4MiG8TQt0uMYs1GUKcF/I7Bj4M6Yr02ELr3MGFcQgDM4i/NGoneS4VOBvIzvXm6pX7513+oOAk7nr6vsy3jSLSriARmy6sYj5uq+rap2TM0hsL++PY7gjy1/SPf6dpyo/yrn3d1Kv9v7YLc+8v+IIkU/4NJwLP81vFEf6xedoSiLsKz5E9BFUVqT4SiuOKJGt2FKcUUbDzrjFIIZuhl6hFNt97VpV75u8RhyX/FVLIY6SsHcdwp+KtN0cQY/IvnHPf9lmIDCvpqeivEiN3A+DjhKyD5COc4tV2GcecO6Y9jA4AE1BYV1bYnvB6EUEsvktG4pUOECORi1w51HB+K4rwTe3w4eri3+ER+C2RC7ux14eJF3PsJR7A==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB7012.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(55016002)(66946007)(76116006)(71200400001)(64756008)(66556008)(9686003)(86362001)(110136005)(66446008)(66476007)(52536014)(316002)(7696005)(8936002)(26005)(186003)(6506007)(8676002)(53546011)(2906002)(966005)(33656002)(478600001)(83380400001)(4326008)(5660300002)(44832011); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: irAnFCS2ukmeujTahSuxoCDvdyZA1oIKvoKVsVu13i8EOxkB5rfPBjHeeAsCqiqcutRr/F1gzSjByO7IvxHxohhmf9hVCH9ZR8MQBTAcql8/HpznpuIxy27WDWBxTd2MIpOITBZWGG2PWG+otkaeGaoyWBVMlfw5HklqBZmc8TObSZaCZlywU30z7R/n85qqK/V74gaX2gw0c0Bg4a289LyY3w6M+RIhCD4fnYT/Xl+bxB8/pdB1blp8jK7ctENNzgKMFkduG0+GlDLLSuMFccD96sTWlW/W9XMJBxu0r+WYSqfdgMypFfVwy40TMXlDxXybztTpfvSPtka/l8wTHhDbmWnzHG7rUFMOjVUaFO5COKd4HRYv9wMYdj582xANtu+/ticQJuSv/ZF6nBtTx/vcWE4i/nc/jsq25KaVu496rBhcjwb77VrqCxDkhplhR4UZjcqFDCKPRgwhLaI2nKWn2YLq5EDHXCBGJGHjyRYEQKgdmg+B9QvG7GmxVN1c
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6771146a-7963-4df6-2aa8-08d80f8bb2a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2020 11:19:54.4051 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yjf87Dw1+Z1jh7jTiN+SMokdQLpsc/4SS1BuDIceUPgB98UTasxsvyZT/v1bcYv8TpTlYF/+Xh8us82vdiQHtn26x67AfIh/iPpRQQAYqqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB5560
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/NkyQ0j13-7x8f0m6gxuJ5vCGwPw>
Subject: Re: [MMUSIC] Shepherd's review of draft-ietf-msrp-usage-data-channel-17
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2020 11:20:05 -0000

Hi,

>PR with updates in
>https://protect2.fireeye.com/v1/url?k=c74719fa-99e7a394-c7475961-86b1886cfa64-ff7ae6892db50a68&q=1&e=b91f0410-0fd5-48d5-ad8c-aface179da
>2b&u=https%3A%2F%2Fgithub.com%2Fjosemrecio%2Fdraft-msrp-data-channel%2Fpull%2F17
>
>Good catch on the IANA updates about SDP parameters. Given that usage is not modified and only a reference needs to be added, I have created an omnibus section grouping them altogether for simplicity.

It is not enough to say that a reference is added.  We need to add the usage level 'dcsa(msrp)' to each attribute.

Regards,

Christer


On 10/06/20 19:52, Christer Holmberg wrote:
> Hi Bo,
>
> Thank You for the review! Please see inline.
>
> ---
>
>> 1) Please point more clearly to which IANA registries that are targeted in sections 9.1 and 9.3.
> I suggest the following:
>
> 9.1:
>
> OLD:
>
>     "This document modifies the usage of the msrps URI scheme, registered
>     by [RFC4975], adding DTLS as a protected transport indicated by the
>     URI scheme."
>
> NEW:
>
>     "This document modifies the usage of the msrps URI scheme, registered
>     by [RFC4975], adding DTLS as a protected transport indicated by the
>     URI scheme.
>
>     A reference to RFCXXXX is added to the URI scheme "msrps"
>     in the Uniform Resource Identifier (URI) Schemes Registry."
>
>
> 9.3:
>
> OLD:
>
>     "Usage level "dcsa(MSRP)" should be added to the IANA registration of
>     the SDP setup attribute as follows:"
>
> NEW:
>
>     "The usage level "dcsa(msrp)" is added to the registration of the SDP
>     'hland-send' attribute in the Session Description Protocol (SDP)
>     Parameters registry as follows:"
>
> (Note that "MSRP" is also changed to "msrp", both in the text and in 
> the table.)
>
> ----
>
>> 2) In section 4.4, you are discussing dcsa use of setup, path, msrp-cema, accept-types, accept-wrapped-types, max-size, sendonly, recvonly, inactive, sendrecv, and "all the parameters related to MSRP file transfer" (section 4.7), but only setup has a corresponding IANA section (9.3), asking to register the attribute on dcsa level. Please add IANA >information for all of the other specified attributes as well (as separate sections or extend section 9.3, as you see fit).
> Good catch. We will do that.
>
> ---
>
>> 3) In section 3.1 change sub-protocol value in the body text from "MSRP" to "msrp", for consistency.
> Will modify as suggested.
>
> ---
>
>> Editorial comments/nits:
>>
>> i) Consider aligning all occurrences of "a MSRP" to "an MSRP".
> Will modify as suggested.
>
> ---
>
> https://protect2.fireeye.com/v1/url?k=6216e4e2-3cb65e8c-6216a479-86b1886cfa64-c037cf8999867a11&q=1&e=b91f0410-0fd5-48d5-ad8c-aface179da2b&u=https%3A%2F%2Ftools.ietf.org%2Ftools%2Fidnits%2F%2Fidnits%2F:
>> a) The document has no formal "updates" tag in the file header, it just mentions it in the abstract. Please use the formal title page header format, also for the provided XML.
> We will add updates="4975" to the XML rfc tag.
>
>> b) The abstract contains RFC4975 as a reference, which cannot be part of an abstract and must be replaced with a plain-text mention of that RFC.
> Will fix.
>
> ---
>
> Regards,
>
> Christer
>