Re: [MMUSIC] Please Read and Comment: Re: ICE SDP/JSEP peace accords

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 26 January 2019 10:38 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 953B4127133 for <mmusic@ietfa.amsl.com>; Sat, 26 Jan 2019 02:38:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.852
X-Spam-Level:
X-Spam-Status: No, score=-8.852 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=IRDGDdqZ; dkim=pass (1024-bit key) header.d=ericsson.com header.b=DnRXzKY3
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qeMr346jk80t for <mmusic@ietfa.amsl.com>; Sat, 26 Jan 2019 02:38:37 -0800 (PST)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 440B013117F for <mmusic@ietf.org>; Sat, 26 Jan 2019 02:38:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1548499114; x=1551091114; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tkfSRsSmlGyeUQa1s23fFppFUD2Hk4q+gMuRoiuYId4=; b=IRDGDdqZXGPyqX/mdruzJ4jILYS6xAZ4DAg5b2PcSFyFx2Hy4i36zZZu/Rj6Kky1 pYiu+CICjJzE0eyz6Di1B9cnGhddV3/0bPxDfFtnMI5EF2qX2wFWMnwgnZAJ0Uru nIuc/ARSzRljZ7s7Pv9RVx4vfAW7sIrK20Qj+cMLH2A=;
X-AuditID: c1b4fb2d-db5ff7000000062f-8d-5c4c38aaf2bf
Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id E5.04.01583.AA83C4C5; Sat, 26 Jan 2019 11:38:34 +0100 (CET)
Received: from ESESSMR502.ericsson.se (153.88.183.110) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 26 Jan 2019 11:38:33 +0100
Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMR502.ericsson.se (153.88.183.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 26 Jan 2019 11:38:34 +0100
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sat, 26 Jan 2019 11:38:33 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tkfSRsSmlGyeUQa1s23fFppFUD2Hk4q+gMuRoiuYId4=; b=DnRXzKY3N2GDYA+bP8N92+PueQcepL83ZPLmXCJ7b/ie4bZbAZhM3Dykws3DJlTuM8pgFXo0tYee/auE/WfzgqBTS6RDrlMPPavE3K7mcIVUicAgA1Q09bL4aGo0bFxUesfX/Wjc0ZZ7CCqSg6Aj2dR9kuVFgpeHK8pXRZ/koSs=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB3370.eurprd07.prod.outlook.com (10.170.247.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.7; Sat, 26 Jan 2019 10:38:31 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec90:1d14:9549:fdf0]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec90:1d14:9549:fdf0%4]) with mapi id 15.20.1580.012; Sat, 26 Jan 2019 10:38:31 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Roman Shpount <roman@telurix.com>, Suhas Nandakumar <suhasietf@gmail.com>
CC: Flemming Andreasen <fandreas@cisco.com>, "mmusic@ietf.org" <mmusic@ietf.org>
Thread-Topic: [MMUSIC] Please Read and Comment: Re: ICE SDP/JSEP peace accords
Thread-Index: AQHUtOAE+k+W2vP1Z0i92Eq2mAg1HqXAYGUAgAD6xMA=
Date: Sat, 26 Jan 2019 10:38:31 +0000
Message-ID: <HE1PR07MB3161D0B11C904402D0858D8E93940@HE1PR07MB3161.eurprd07.prod.outlook.com>
References: <0454609c-ce69-80d4-93d8-f89bc8ba897e@nostrum.com> <CAD5OKxu1bPDU_snQ=H7RwVgPKW_hKJY1Nj7g82vTpJ+gorPrYQ@mail.gmail.com> <f279e997-0236-b78c-e555-5189d9818ef2@nostrum.com> <9B6124BE-E369-4327-B759-77DB0ED8A484@ericsson.com> <6f42b5c5-72f0-8d6a-c68d-d19da7d94353@cisco.com> <HE1PR07MB3161189A6405D403F433F17293980@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxvNYnARbw5yvSHCeQUiSMRxQdMj9h5zUeXj+o3Nd8Kh-g@mail.gmail.com> <3e17ec5d-e6b2-5d38-e206-2ed7b8b9c690@nostrum.com> <CAD5OKxtzxOfE9O-G5tQ1C_sg8LHQBxpNATJi_ee-UVcp0gdb2w@mail.gmail.com> <ab0940dd-9ad0-d012-5530-a6a35dd659e9@nostrum.com> <CAD5OKxtgRZErxSfPOQd1xts4zg+1RWuYFOZSey=HgG-Y9g0Dhw@mail.gmail.com> <b7c0eb29-d11b-1a54-5325-d8fccb1c778d@nostrum.com> <CAD5OKxthX_GVNCchMvovAac9Q_hwLVP2VHudp3QUEZxfzBj5HA@mail.gmail.com> <b5cd275a-1dc7-9729-fea0-e8e2b432f171@nostrum.com> <f54c5932-7254-151f-a04a-07cb86809fe7@cisco.com> <CAD5OKxv_Xge=g0wtyADF3QO6qjp9iwu4sKMmYvC6zdVw5kg4tw@mail.gmail.com> <CAMRcRGStO+WjTBxETS4usOFS7NZSYgRP0ciWXZ8Sw8FBfge=5g@mail.gmail.com>, <CAD5OKxt76SVqcKCP_bsWyPEe8sXe2+Kmq4WqDgmcK9EqrJLw+g@mail.gmail.com>
In-Reply-To: <CAD5OKxt76SVqcKCP_bsWyPEe8sXe2+Kmq4WqDgmcK9EqrJLw+g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [37.136.56.89]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1PR07MB3370; 6:W47tyVqSkIrtWy5uteg7xIqthihiyMyFH0gGqX1dqLHjrdDvCGzROxVrqWvQyW9PecMLkBosi3Ct6A/Rpr6OzIHJlrCstV1h29R8clvWIZE6QXGGeiWu7sihXVO3UMuEuTCMXfJTov3NkMHx3LErJVgaN8F4vIWWTTiEay0MRMYMkD+qHhwBcv5heC2drMYDvlfQi2KEaFZxKyu3jPqiH4cgK7sQcFgPoszVJ/nKioIYGhFBQrtFTvEKWIpCaGNNP0Fo2qR8q5L16vaPCxCsS+b2CC6NXDTjh5YFFeP+bHUgHg6Ijyyvlq+IcrWGgDp4LV8oGf0AlNVncfr5SWWdyRjGsELZXi2hr/0XQySDqGt5xLPV8nt3HsBUzGU+r5bWYQ+kT01LwLyJvTt5uYy6mQVAkbjXJHj5oLcWHS5f0yy1Sy3cPOez1zuNws7zrZGGkiioFKe28baTJiLP7Ok7UQ==; 5:pxy57WSOJSnj80dIXMBw2mEWEomXj9TrlVDtyPKpQbZIRynPHOmYLI1OumihjQMP1XK9HGPsQUNbl+6yeAv2qMJjvM+uVvcf3gLK+viiARuYm8judBdi2iU9gMg8sfZujarb9JMrWkRhim5fU07kqAcjWPwimawvn3DvRDwt72y3cBEALcpmGBzitx7zKkL1y2jVDYImeR/yPRiE5gNuBA==; 7:Jg1+Ws8xqZHF8ygvUK3Xw62YhZMhgkBA8oov1XQ0sSQvcuqwGpkUXU/FA1nLGL8xB23qMJzeVsnd4OisUnUHRkL+B4vr8nHNEcBCzPyLMTQxOX3EliyY5JsXa3/IDxLL1n+mI2MJ21IlmcDWaEEp9g==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 343a885b-1061-4fde-f013-08d6837a6a55
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:HE1PR07MB3370;
x-ms-traffictypediagnostic: HE1PR07MB3370:
x-microsoft-antispam-prvs: <HE1PR07MB3370054A0381C2936E3339C093940@HE1PR07MB3370.eurprd07.prod.outlook.com>
x-forefront-prvs: 0929F1BAED
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(396003)(39860400002)(366004)(136003)(376002)(346002)(189003)(199004)(97736004)(1015004)(74316002)(71190400001)(54906003)(6606003)(2906002)(44832011)(3846002)(6116002)(105586002)(19627405001)(478600001)(106356001)(99286004)(5070765005)(14444005)(256004)(446003)(966005)(486006)(14454004)(316002)(110136005)(71200400001)(11346002)(476003)(229853002)(66066001)(76176011)(55016002)(606006)(7736002)(81156014)(68736007)(33656002)(6506007)(6436002)(53936002)(53546011)(8676002)(25786009)(26005)(7696005)(102836004)(4326008)(6246003)(9686003)(6306002)(54896002)(81166006)(186003)(39060400002)(236005)(8936002)(93886005)(86362001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3370; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: HkpkBwJVqj4mY876KDj4uOC7ArN0dq069duz72f976XuvNjHVa+Odnr4L4z24D8NzH+ftxJK59Won7Bibik5EI7B9OrUYS913WVyW3hWgbvVtEGzSMjg4svXdCgG7itajXSVaWUXKyOfZXmAH9HlnGLhlg/UbPqPs6LJe3BEObajua1WEROLMVZQDcKeM23Kr20ZNmS/KygJYCDaboEJuEQ5JkROiXjw8g6hmFfOqpY3Rju0LiGmu2E2tl5JjByXrtuN4KrSNifSjAxcTWTuHy/UvUhg9gI0JPphTWUs6WEb+G/IwtOrHkOrElEHA9N5+NncqIsHqSQIFxPhuu580DrBgkrnGlcXOAToJpaR0dz/2Qz6dop/YRM+2DGOOOXDtGphAFKBXn/UVt0e1Z7glXg8Dn1MTRJdk931e1DlDfw=
Content-Type: multipart/alternative; boundary="_000_HE1PR07MB3161D0B11C904402D0858D8E93940HE1PR07MB3161eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 343a885b-1061-4fde-f013-08d6837a6a55
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2019 10:38:31.0698 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3370
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRmVeSWpSXmKPExsUyM2J7ue4qC58YgwmTxCzeX9C1mLr8MYvF jAtTmS12zu1gdmDxmPJ7I6vHzll32T2WLPnJ5HFrSkEASxSXTUpqTmZZapG+XQJXxt6rfAWv yyvOtx5ibGDsTu9i5OSQEDCROP11PUsXIxeHkMARRokbS26xQzjfGCU+frvPBOdsnbMdqmwJ k0R7/xxmEIdFYAKzxPILLawQmUlMEs1bLjFCOI8YJf69/wo0jYODTcBCovufNshGEQFfiduP bjCC2MwCQRI3H18As4WB4jOnfWKFqPGTWDKpgxHCtpJ4seMzWJxFQFWie2c/G4jNKxAjsfhB P9SuNxwSeydOA2vgFAiUWNTbyA5iMwqISXw/tYYJYpm4xK0n85kg3haQWLLnPDOELSrx8vE/ Voj6RIn9qx5AxRUkjt97wghhy0pcmt8NtkxCoIld4vC2KywQCV2JD1OnQjX4Shx5M5cJougm o0Tb3xaobi2JHV9nQ23Olth2+RpUs4zEvieL2Scw6s1CcuAsYIAxC+RL7L/FMwvsUUGJkzOf sECUGEi8PzefGcLWlli28DWUrS+x8ctZRmTxBYzsqxhFi1OLi3PTjYz1Uosyk4uL8/P08lJL NjEC09TBLb91dzCufu14iFGAg1GJh7fEwCdGiDWxrLgy9xCjBAezkggvp4B3jBBvSmJlVWpR fnxRaU5q8SFGaQ4WJXHeP0KCMUIC6YklqdmpqQWpRTBZJg5OqQbGYEuHBsuFPuJMX+sf9S6w m1H51jBcr6FzT+yb/B+CH+wPLDect4S1t//mto+Gr5R5JWuCfY8+OPpuc+8R1m/33zUF2qpd fjeH51zLSo01ioo5mQExHG+mfX/8Y85O2Zo/9zhVOYwOcj39b31vVnX2It/nUcwvd7Ue8HgZ s/B7QcKyvpQH0eddlFiKMxINtZiLihMB3GfRgk8DAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/UoN9hnCOf85DFTlYDLQHEufeC7U>
Subject: Re: [MMUSIC] Please Read and Comment: Re: ICE SDP/JSEP peace accords
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jan 2019 10:38:40 -0000

Hi,


I have also provided some comments on Adam's PR. I haven't posted them on the RTCWEB list, but I can do that too.


All I ask for is to make a clear separation between implementations of the JSEP API (e.g., browsers) and implementations using the JSEP API (e.g. JavaScript applications). The spec now talks about "JSEP implementations", and at least to me it is unclear what that really refers to.


Regards,


Christer



________________________________
From: Roman Shpount <roman@telurix.com>;
Sent: Friday, January 25, 2019 9:35 PM
To: Suhas Nandakumar
Cc: Christer Holmberg; Flemming Andreasen; mmusic@ietf.org
Subject: Re: [MMUSIC] Please Read and Comment: Re: ICE SDP/JSEP peace accords

I have provided my comments on pull request. I think this is a reasonable way forward but the language requires clarification.

We will also need to update ice-sip-sdp to deal with some of the ambiguities:

1. We need to specify that protocol in the answer must match protocol in the offer, even if none of the ICE candidates in the answer match. For instance, if an offer is received with TCP/DTLS/RTP/SAVPF , but the answer contains only UDP candidates, answer MUST sill use  TCP/DTLS/RTP/SAVPF

2. We need to specify what address and port must be used if protocol in the m= line does not match any of the candidates. I think using IN IP4 0.0.0.0 and port 9 is a safe option which avoids ICE mismatch.

Regards,
_____________
Roman Shpount


On Fri, Jan 25, 2019 at 1:58 PM Suhas Nandakumar <suhasietf@gmail.com<mailto:suhasietf@gmail.com>> wrote:
I think Adam’s Pr on this topic is reasonable way forward.

Thanks
Suhas

On Fri, Jan 25, 2019 at 10:50 AM Roman Shpount <roman@telurix.com<mailto:roman@telurix.com>> wrote:
On Fri, Jan 25, 2019 at 9:05 AM Flemming Andreasen <fandreas@cisco.com<mailto:fandreas@cisco.com>> wrote:


On 1/22/19 4:42 PM, Adam Roach wrote:
On 1/22/19 3:40 PM, Roman Shpount wrote:
On Tue, Jan 22, 2019 at 4:36 PM Adam Roach <adam@nostrum.com<mailto:adam@nostrum.com>> wrote:
On 1/22/19 3:33 PM, Roman Shpount wrote:
On Tue, Jan 22, 2019 at 4:25 PM Adam Roach <adam@nostrum.com<mailto:adam@nostrum.com>> wrote:
On 1/22/19 3:15 PM, Roman Shpount wrote:
> The issue is the offer generated when ICE restart is not initiated and
> TCP candidate is currently nominated. TCP candidate is the only
> candidate which is present in both offer and answer. It is also the
> default candidate. No UDP candidate will be added it any point during
> the offer/answer exchange.


This is what I tried to indicate with the use of an italicized "always"
in my previous reply.

EVEN IF it is generating an offer when ICE restart is initiated and the
TCP candidate is nominated, Chrome will still always (always, always)
generate an SDP that includes a UDP candidate and use that candidate's
value in the m=/o= lines.

Unless I am mistaken, if ICE restart is not initiated, only the nominated candidate must be included. No other candidates must be present. If Chrome does not follow this, then it is most likely not complaint with either ICE or JSEP specifications.


Based on the conversation I had with their engineers, that seems to be the case.

Based on RFC 5245 section 9.1.2.2 (https://tools.ietf.org/html/rfc5245#section-9.1.2.2) this is wrong:

The agent MUST include candidate attributes for candidates matching the default destination for each component of the media stream, and MUST NOT include any other candidates.


I'm not disagreeing.

So where does this leave us ?


I think JSEP sections 5.1.2 (https://tools.ietf..org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2<https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.1.2>;) and potentially 5.2.2 (https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.2.2) would need to be updated to be consistent with each other and mmusic drafts.

There is currently a discussion on RTCWEB of pull request https://github.com/rtcweb-wg/jsep/pull/862/files which attempts to fix this.

Regards,
_____________

Roman Shpount
_______________________________________________
mmusic mailing list
mmusic@ietf.org<mailto:mmusic@ietf.org>
https://www.ietf.org/mailman/listinfo/mmusic