Re: [MMUSIC] WGLC on draft-ietf-mmusic-msrp-usage-data-channel-16

Paul Kyzivat <pkyzivat@alum.mit.edu> Thu, 07 May 2020 16:01 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AF603A0ADB for <mmusic@ietfa.amsl.com>; Thu, 7 May 2020 09:01:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.991
X-Spam-Level:
X-Spam-Status: No, score=-1.991 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=alum.mit.edu
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6cTaNi3StyD7 for <mmusic@ietfa.amsl.com>; Thu, 7 May 2020 09:01:21 -0700 (PDT)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5460B3A0A86 for <mmusic@ietf.org>; Thu, 7 May 2020 09:01:17 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRmed7HDqKdQVrkZ76ecjPO8ufyqnDZvoJDxkOAuC+99xRHR7vG+AGjC5nY+px1D0m1ZMxESc3I/KpGskNL1sZeVh7k0BQVgSEyUTrIBr7x6sWoZbArbU4dx5R/7goodpFXumPVEJf9uyYLbw+oxUefds8KrsTFvsEaREzE0CeS8U3DfaDH7rD+dN41aYb6S1r7OeinZGdNnYpq3r/auKdANHeDynzeKRFatat6O5rSySxsD8Cr4u3avFXHpubmC/pZZYKNvRnn9ylpCD9MaN/fYGPm5WH+I7ArSKOLxFjn7GCcOV38VTl/AIVRLFVURatL7kPIoCLF7BmnlE6/Q7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pRNhGpgchJ2uLAbN/kfLPre/fsW56a45aUrkzLiB7wY=; b=EGHWjpef1F7VDWRBxwyFoHCbUxDSiWWOJ5vtSMZP0fN+79iGdT2P0Fbye4jupM4L4sJ3FyvYyx+qoX45us1awXSqc9CtyuoJpXn7JhnnkqXdIFF7nlpVPGsLmLWGiPi46ZvDr/HqMznC4hCeFlmpm5M7PgYg74LW9WeKmQLaFM7riq+caeg2Fm6CjzWiBx4uUKaSuMWYeWYwLLp1H09dfWBZVsizk0CKs9/wKK+++EyfKxhnkXE0KIMHvS1r4CoUoK0NyAvaP022izacWzDtUicukvcFpcVWiLliDwrqdt+QQW7FyImKyUNFRDOEPN4ZbtXNOtrvDt9ImSdkaAWUmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=permerror (sender ip is 18.7.68.33) smtp.rcpttodomain=ietf.org smtp.mailfrom=alum.mit.edu; dmarc=none action=none header.from=alum.mit.edu; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alum.mit.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pRNhGpgchJ2uLAbN/kfLPre/fsW56a45aUrkzLiB7wY=; b=YlWJ1+/2iCMg7Zh2qKRMAJJISGIK5QdajuE7HqeW6x+ky47Q+xusF21F5rg3XOZhxhqlyv9NfZyq4g8dIY+TvWdWCVjfjP8Ib0CzriM6X04TGNHBnqoiRXHP78bn9v2hDMlE1Ft3U6MokfgMT7Jrfup9FLthTHTLytcP4j2IUwQ=
Received: from MN2PR18CA0007.namprd18.prod.outlook.com (2603:10b6:208:23c::12) by MN2PR12MB4000.namprd12.prod.outlook.com (2603:10b6:208:16b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Thu, 7 May 2020 16:01:15 +0000
Received: from BL2NAM02FT012.eop-nam02.prod.protection.outlook.com (2603:10b6:208:23c:cafe::7e) by MN2PR18CA0007.outlook.office365.com (2603:10b6:208:23c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Thu, 7 May 2020 16:01:15 +0000
Authentication-Results: spf=permerror (sender IP is 18.7.68.33) smtp.mailfrom=alum.mit.edu; ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=alum.mit.edu;
Received-SPF: PermError (protection.outlook.com: domain of alum.mit.edu used an invalid SPF mechanism)
Received: from outgoing-alum.mit.edu (18.7.68.33) by BL2NAM02FT012.mail.protection.outlook.com (10.152.77.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.29 via Frontend Transport; Thu, 7 May 2020 16:01:15 +0000
Received: from Kokiri.localdomain (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id 047G1CVj022174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for <mmusic@ietf.org>; Thu, 7 May 2020 12:01:14 -0400
To: mmusic@ietf.org
References: <HE1PR07MB4426ADA1E4B1D696A48BA9A98DA40@HE1PR07MB4426.eurprd07.prod.outlook.com>
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
Message-ID: <66bc33b6-8a66-1da3-93c0-e7ddc31cc605@alum.mit.edu>
Date: Thu, 7 May 2020 12:01:12 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <HE1PR07MB4426ADA1E4B1D696A48BA9A98DA40@HE1PR07MB4426.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Forefront-Antispam-Report: CIP:18.7.68.33; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:outgoing-alum.mit.edu; PTR:outgoing-alum.mit.edu; CAT:NONE; SFTY:; SFS:(39860400002)(376002)(346002)(396003)(136003)(46966005)(33430700001)(786003)(5660300002)(70586007)(82740400003)(82310400002)(356005)(7596003)(478600001)(33440700001)(186003)(26005)(75432002)(2906002)(336012)(8936002)(36906005)(956004)(6916009)(86362001)(8676002)(31686004)(47076004)(70206006)(316002)(2616005)(31696002)(43740500002); DIR:OUT; SFP:1101;
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2e5b088-cf81-4e91-cf1f-08d7f29fdf09
X-MS-TrafficTypeDiagnostic: MN2PR12MB4000:
X-Microsoft-Antispam-PRVS: <MN2PR12MB4000A6F4701797BBDE22F7A5F9A50@MN2PR12MB4000.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-Forefront-PRVS: 03965EFC76
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ll9pPuxoR7lYs95M8IO5Fv+oNYK/kRCN/7HYo0nEZhcySHS+0uRYXyDVmjeaiBcEJnUOM3HuDjvJetrqwYjIWBpeCFCnavFYk0ZcLnoVOwku+bzy6T85zuFUfbdo3ZYsucXuil8eIIOojqn+7Z14Tezrn1/jvUtWoa8xjcNdgYCSGGNgxSc/MJKpgIQglk5h10Zqvk11x1+RkixOcjj3NECB+QhJqyzmH1fyBxwf8BPsR0aKdD4xskGddySXniKQjLThfAOeoX5yQ9leFffIBcZOxLyx3Nb6pAJbAOZWXkWtSXzZ99pYRi1Sd47sZ9aq90mprh+Qz/3RiTdtfm46lCsmLib3XsvpnEz8a8qny06XNv0X7MaHckerG3qUfqmoozALs24Wp/LvYfMZyeW/h67JSmPCR0z/OOzu8oWR7xur3+Q/FfqE1cGpy0S9ANmZwPEgaxCSN0Gq0rAlRDmrV2uJRj2CjCt0jwNfUq9elW7tZcjWgvQSoTQrURabeVKssEmr8QGCcVxV0jtRdfDbd7WzfPE4op6ONeA/6KD8kFH5XJY88W+0OUJcuKkjK0FBY/iSn9aUc/uJYJJQlr+/t8vNmhfNEKWQqbqwB4aNnqQ=
X-OriginatorOrg: alum.mit.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2020 16:01:15.0948 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c2e5b088-cf81-4e91-cf1f-08d7f29fdf09
X-MS-Exchange-CrossTenant-Id: 3326b102-c043-408b-a990-b89e477d582f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3326b102-c043-408b-a990-b89e477d582f; Ip=[18.7.68.33]; Helo=[outgoing-alum.mit.edu]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4000
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/Uw-0jz8DIYUJT0hhIN8lDmYzj2w>
Subject: Re: [MMUSIC] WGLC on draft-ietf-mmusic-msrp-usage-data-channel-16
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 May 2020 16:01:30 -0000

(Its good to see this is almost done!)

I took a fresh look at the document. I found a number of small things 
but nothing monumental:

1) NIT:

In Section 3.1, in the table, the value for Label has a lot of white 
space between "See" and "Section 4.3". It would look better with a 
single space.

2) MINOR ISSUE:

In section 4.1, the abnf says:

    transport  /= "dc" / 1*ALPHANUM

The /= means this is an added alternative to what is present in RFC4975. 
Hence it is equivalent to:

    transport = "tcp" / 1*ALPHANUM / "dc" / 1*ALPHANUM

What you should really have is just:

    transport  /= "dc"

3) NIT:

Section 4.4 says:

    An offerer and answerer MUST include a dcsa attribute for the
    following MSRP-specific SDP attributes:

I suggest: s/for the/for each of the/

Similarly, where it says:

    An offerer and answerer MAY include a dcsa attribute for the

I suggest: s/for the/for any of the/

4) QUESTION:

Does section 4.6 this mean it is an error to use SDP to close the 
DTLS/SCTP association (via m=0) without all the added SDP attributes to 
close each data channel?

Could it not be implied that closing the association implicitly closes 
all the data channels?

5) QUESTION:

The example in section 4.8 includes use of the "path" attribute. How 
does that square with the following in section 4.4:

    The path attribute SHALL NOT be used for transport negotiation.

I guess you mean that some usages of path are ok and others are not. 
Could you be more explicit about this?

6) ISSUE:

Section 7.1 registers "MSRP" as if it was a totally new websocket 
protocol name, but it isn't. It is already registered as a websocket 
protocol referencing RFC7977.

I think you instead need to specify that the existing registration be 
updated.

That's all.

	Thanks,
	Paul