Re: [MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-sdp-uks-06: (with DISCUSS and COMMENT)

"Martin Thomson" <mt@lowentropy.net> Tue, 06 August 2019 07:43 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB795120059; Tue, 6 Aug 2019 00:43:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=zhN8APiO; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=f+GawzVb
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Lz5FUH5JXoV; Tue, 6 Aug 2019 00:43:11 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 30AF912004D; Tue, 6 Aug 2019 00:43:11 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 98218205B8; Tue, 6 Aug 2019 03:43:10 -0400 (EDT)
Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Tue, 06 Aug 2019 03:43:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type:content-transfer-encoding; s=fm2; bh=Dr PmuP3Dosdohcqcs5C3FHw2xFJ7Ek2UO9y6a2UYz/M=; b=zhN8APiOqXk5wv6gq1 ag7s7mmkk4Zccq5sIHlnfm0Rqu4BryYlBgH8IcAxziAoiWkGuHbyG+N2UYa6nL9l BRF7VTRg0Rj/2JlETBbNf631jx8Qb/+taryxDVjka3JrrCaXq5+qRHqMcLGVBtkM 7gf+Og6hQg3CMZ1UOw3J1jL14QMdFJukmd7KmUql4gljXzASJLTByF0gi5kcFi80 M8Dx63iWun8xme7sF3XpJo8/tNq8NMLYHvIQsAieCiWk6Zz2ls8Bd0DIoMTyhQnT 03nu79GMn9oHc2KiNQlgqep+HyEaZjlRZYOtsfTCh5inbPE3E2B4SDVvgO41/TXH gV2w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DrPmuP3Dosdohcqcs5C3FHw2xFJ7Ek2UO9y6a2UYz /M=; b=f+GawzVbLIIMtNQ1CHVTKlw3g6y2X7a5Hx9HQVeFiMC3kWS3w192fTJwP rQxwtxl+8Vp9Y0jPNCSzop+5vf97ek8LnVn4/ntXckTVbsWkgW5hR3z4JKXDeCge ADLhnDM68w/iDezTemew/8tVCpSh0SbJu1E/L+s06Dmsm+SSLFhjFjs1dZh0ZXPO c/RT0h+ZCLWNTKMoWOyiOaQM6pb7M8NmXA51HP7Ir8gXgnA7F94DxKWmcfnF34/N R5+3gji54S9MFh0nm5gbxNYWL4RvTJv2oF+mMl9Db4UNAr11t0F9E4QJwaZUd8f5 BLQ5MfllMnryJCERo0uYayA2tuevQ==
X-ME-Sender: <xms:ji9JXWqm_4lrjCTNAzdBz-IGaAuy68baWT4hvJWrrqAZ1zFCtoighA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddtledguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepfdfo rghrthhinhcuvfhhohhmshhonhdfuceomhhtsehlohifvghnthhrohhphidrnhgvtheqne cuffhomhgrihhnpehgihhthhhusgdrtghomhenucfrrghrrghmpehmrghilhhfrhhomhep mhhtsehlohifvghnthhrohhphidrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:ji9JXb1c8InD4ZBDmcf_V2VVTF0b44nZaKQA5WCADdN_3_jpa6igSw> <xmx:ji9JXflARLt3_N2gS6COxKixopKhxSqS5sSBEzH41c-zYyeeNclolQ> <xmx:ji9JXenJffxZ8M6-fBu3foGRqivi2KK7T0Uf_0eSIcX1SWHhxTeKeg> <xmx:ji9JXdRWsiQpvo8tyS5F2PHKn-HjkyLeVhhHKjc6b69QPW-KwMV5QQ>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4803BE00A4; Tue, 6 Aug 2019 03:43:10 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.6-808-g930a1a1-fmstable-20190805v2
Mime-Version: 1.0
Message-Id: <7cebefbb-15b3-476d-a497-a49137cadff4@www.fastmail.com>
In-Reply-To: <156505826472.2103.10624716680930395268.idtracker@ietfa.amsl.com>
References: <156505826472.2103.10624716680930395268.idtracker@ietfa.amsl.com>
Date: Tue, 06 Aug 2019 17:43:13 +1000
From: Martin Thomson <mt@lowentropy.net>
To: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>
Cc: draft-ietf-mmusic-sdp-uks@ietf.org, mmusic <mmusic@ietf.org>, "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/YdMqhVEIKgq8MlSLbM4y5Zpxy3E>
Subject: Re: [MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-sdp-uks-06: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Aug 2019 07:43:13 -0000

I've combined the changes with Ben's.  See    https://github.com/martinthomson/sdp-uks/pull/11

On Tue, Aug 6, 2019, at 12:24, Roman Danyliw via Datatracker wrote:
> (1) Section 3.2.  There are a few places where further clarity on error
> handling would be helpful:

Added requirement to use illegal_parameter.

> (2) I support Ben’s DISCUSS on the clarity of Section 3.2. I would add a few
> additional observations:
> 
> ** Per the sentence, “The resulting string is then encoded using UTF-8”,
> shouldn’t this JSON text already be UTF-8 per Section 8.1 of RFC8259 -- what’s
> the new encoding to be done?

A JSON text is a string of tokens, not octets, by my reading.  The UTF-8 encoding is something that happens to JSON text to produce a sequence of octets, so you have to say that.

I realize that isn't clear from RFC 8259, but the risk I'm hedging against is the UTF-8 encoding not happening, not that it might happen twice (which is a nonsensical operation in many contexts, but I will concede still possible in some).  At least I hope that someone will realize that encoding twice is not a sensible option.