[MMUSIC] Magnus Westerlund's Discuss on draft-ietf-mmusic-data-channel-sdpneg-25: (with DISCUSS and COMMENT)

Magnus Westerlund via Datatracker <noreply@ietf.org> Fri, 05 April 2019 12:04 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: mmusic@ietf.org
Delivered-To: mmusic@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EEF281203E9; Fri, 5 Apr 2019 05:04:40 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Magnus Westerlund via Datatracker <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-mmusic-data-channel-sdpneg@ietf.org, Bo Burman <bo.burman@ericsson.com>, mmusic-chairs@ietf.org, bo.burman@ericsson.com, mmusic@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.94.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Magnus Westerlund <magnus.westerlund@ericsson.com>
Message-ID: <155446588097.13196.6373243259627185094.idtracker@ietfa.amsl.com>
Date: Fri, 05 Apr 2019 05:04:40 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/aPS0Gbj8g5KAx8iTrGS81UZqN0Q>
Subject: [MMUSIC] Magnus Westerlund's Discuss on draft-ietf-mmusic-data-channel-sdpneg-25: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 12:04:41 -0000

Magnus Westerlund has entered the following ballot position for
draft-ietf-mmusic-data-channel-sdpneg-25: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mmusic-data-channel-sdpneg/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

There might be a serious issue in label definition.

5.1.3.  Label Parameter

   The 'label' parameter indicates the name of the channel.  It
   represents a label that can be used to distinguish, in the context of
   the WebRTC API [WebRtcAPI], an RTCDataChannel object from other
   RTCDataChannel objects.  This parameter maps to the 'Label' parameter
   defined in [I-D.ietf-rtcweb-data-protocol].  The 'label' parameter is
   optional.  If it is not present, then its value defaults to the empty
   string.

  label-opt       = "label=" quoted-string
  quoted-string   = DQUOTE *(quoted-char / escaped-char) DQUOTE
  quoted-char     = SP / quoted-visible
  quoted-visible  = %x21 / %x23-24 / %x26-7E ; VCHAR without " or %
  escaped-char    = "%" HEXDIG HEXDIG

I interpret that as the intention is to enable the SDP Attribute to carry the
label as defined in W3C API. That value is in the current candidatate
specification an https://www.w3.org/TR/webrtc/ as an USVSsting
(https://heycam.github.io/webidl/#idl-USVString). And in the reference version
of the WebRTC API as an DOMstring. Both are not limited to ASCII and may
contain any Unicode characters. Thus the escaping mechanism defined appear to
be insufficient.

I think the "quoted-string" need a definition of what type of string this truly
are so that it is clear what a character in the string is.

In addition the specification of escaping is undersspecified. I would recommend
at least adding discussion of the need and how to escape DQUOTE and % that can
be relatively common operations.


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Section 5.1.3:

Is it correct that there are no limiation on the lenght of the label? So it
will okay if I use the more than 450k words of J.R.R.R Tolkien's Lords of the
Ring as label?

[WebRtcAPI]
Is it really the intention to point to the very old version of the API from
2015? The current candidate specification is available here:
https://www.w3.org/TR/webrtc/ and are from 2018.