Re: [MMUSIC] Alexey Melnikov's Discuss on draft-ietf-mmusic-ice-sip-sdp-37: (with DISCUSS and COMMENT)

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 05 August 2019 12:54 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DDAA21201C6; Mon, 5 Aug 2019 05:54:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.991
X-Spam-Level:
X-Spam-Status: No, score=-1.991 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jjG2Vy--HhcB; Mon, 5 Aug 2019 05:54:27 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10070.outbound.protection.outlook.com [40.107.1.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 08D5A12002E; Mon, 5 Aug 2019 05:54:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzoCxh9Kw3eIVIZ6u3zgLWziFrs3FEBXdgtedKAdmgPIShb/WhebEI6903sjeRlqPzLk6XBV3HoV8DHQy+60FG4f7nUk11JT1NxLo+QFD7biliKgJXKdSnJJReeVYSPGBmudN03/szgGOS9sV7/4dTA3Jn8mrrO/3vaRpw/dZVhogJU2W4bhhhI6+ze+IEsXNRyIqG0q7SVUik95Sd+ghLZhKMhnMy09eKxaHRzVJUAYbD7NIeJ7Cx/EXkfnJhIuI04GtjAUYeQ6OuTZipT+A8wctw5f6HMXwuti+5vH0fKnABBnPRVQNan7MOB6BTUQiDZ7QhReTfIKIHkudwHnZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60BAL09Dlxjvw9zmG3Hw+ySvQU2Qimep2ArpGFWUbIw=; b=IrION/W2N55LP7fkbrGHSQuhToDpr0nlZdC+7FUIvp4NsluP4MbNZIkSVJJCzIaWC2UgtOJMJ4KFsQ+9NPkezoR6NYibwfxtp94VYQsGF1HTs4peuLhzq/G75/ku8a7BRFOqGPHT2kXtqE0+XoimEFsva8yZUwUtCcv8l6iUSvKQKzNt1qAL8EpDf0Y7dckP/b92Z9G9pHZXSdTi7fLLlIKpewWEUe7AZOd5jk2Spsoe22nmjzw/i8QoFsnsYKBgM/DQ3RHciZAtvyJApAgkRQAaReAE1Il8Mp7m696ydDz3EhtgCxLlUhVOA23bVQfYiyX4YiHMEX1NCHRfXTNvnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60BAL09Dlxjvw9zmG3Hw+ySvQU2Qimep2ArpGFWUbIw=; b=QJMUmzLnuUMpDs0Qqchbsa+HFM5AxK525eQs5np45gJ5iaRU9mbKeJs2eIF47YTCD6g8+plPKnGOWpGsdvDdNwpu2pwG4hgKKHW56hORg71Kod1LdsCjddf9t2ZXOq1qv1V0+kqWdXUoiWRa4W4EqaaATIlFwz8JJuXAJvSl7/0=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB3081.eurprd07.prod.outlook.com (10.170.244.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.11; Mon, 5 Aug 2019 12:54:24 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec0d:f9d3:7159:ba7]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec0d:f9d3:7159:ba7%6]) with mapi id 15.20.2157.011; Mon, 5 Aug 2019 12:54:24 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Alexey Melnikov <aamelnikov@fastmail.fm>, The IESG <iesg@ietf.org>
CC: "draft-ietf-mmusic-ice-sip-sdp@ietf.org" <draft-ietf-mmusic-ice-sip-sdp@ietf.org>, "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>, "fandreas@cisco.com" <fandreas@cisco.com>, "mmusic@ietf.org" <mmusic@ietf.org>
Thread-Topic: Alexey Melnikov's Discuss on draft-ietf-mmusic-ice-sip-sdp-37: (with DISCUSS and COMMENT)
Thread-Index: AdVLiNnu+8AzQsZhRpSTUJdNF9rGrw==
Date: Mon, 5 Aug 2019 12:54:24 +0000
Message-ID: <HE1PR07MB31616305DCD0062C0801656B93DA0@HE1PR07MB3161.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: fi-FI
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [79.134.118.162]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8a04ad33-d031-4027-fb99-08d719a40afd
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:HE1PR07MB3081;
x-ms-traffictypediagnostic: HE1PR07MB3081:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <HE1PR07MB3081B1AE7017F3C7E9906DD993DA0@HE1PR07MB3081.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01208B1E18
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(51914003)(189003)(199004)(256004)(966005)(7736002)(478600001)(74316002)(305945005)(14454004)(26005)(186003)(68736007)(476003)(44832011)(486006)(9686003)(53936002)(7696005)(54906003)(2906002)(110136005)(6306002)(55016002)(25786009)(3846002)(6116002)(33656002)(66556008)(64756008)(316002)(6506007)(102836004)(81166006)(6436002)(8676002)(81156014)(52536014)(71190400001)(71200400001)(8936002)(66476007)(66946007)(99286004)(66446008)(4326008)(86362001)(76116006)(5660300002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB3081; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 2AnC0xhR+TLJC6DpJuCQdjtVFm28YzMu3zH6e0ycMHBqJORLQK36QIsN6ipOHQDIavv1lYmZ5bHFO6Awvfei9hIJyZdfbRGOx/Hipro1JPZR4ovVGSfqsJOyXNnEmgt5TBoC/dS+nbRCMZIpf95D/rZLDWkUnxQeZTcd3qJnRnLiyJ3nvCQbTINB394+PR8p8F4eViLu5KlcTE3Gz5LpLSSVUUPxq0Orj/EaBcMWn+4u7HaVO0mG1BKZNO1A69PXx+/+TbQNJtwN+fGCa0u1Nxolo7YTaRAT+C4329iyM06zRNXKFTwqMWmzUE0JpD9mILNcqZeDLumNi9Z/E5cm5yjuZza257FbvdGa+6pUkMHoEbSznTDyNVUXr+UDKkJCRNv/derO1UqU9mxq9MVgV/Xnf8lZYo7TDnyXsF9appo=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a04ad33-d031-4027-fb99-08d719a40afd
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 12:54:24.4964 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0UbdmVCEoqMFXXQovwJoQauVUlw+l9s0S87KsOpCy5CJCSoeLnkVloNKcClFPQH19CLMz4VOr48lxFbGvNLKxYYd6XFKYgxL2g7QyOAn+vU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3081
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/QdYZXfsrNnpi8gB7RKDxw-Fs1wQ>
Subject: Re: [MMUSIC] Alexey Melnikov's Discuss on draft-ietf-mmusic-ice-sip-sdp-37: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Aug 2019 12:54:30 -0000

Hi,

Thanks for the review! Please see inline.

----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

> This is a fine document and I only found a few minor things that should be easy to fix.
>
> In 4.1:
>
>   The candidate attribute can itself be extended.  The grammar allows
>   for new name/value pairs to be added at the end of the attribute.
>
>   Such extensions MUST be made through IETF Review or IESG Approval
>   [RFC8126] and the assignments MUST contain the specific extension and
>   a reference to the document defining the usage of the extension.
>
> This is effectively creating a new registry, but this information is not present in the IANA Considerations section.

Does it really mandate a registry? 

The syntax says:

	candidate-types       = "host" / "srflx" / "prflx" / "relay" / token

There are other SDP attributes (and SIP header fields etc) that allow extensions ("token", in this case), without a registry.

Note that this was already in RFC 5245.

---

----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

>This is a fine document and I only found nits:
>
>1) A document which is effectively a bis of RFC 5245 should have a section describing changes since the original RFC. Can such section be added?

Yes. I agree we should have some text about that.

---

> 2) In 4.1:
>
> component-id          = 1*5DIGIT
>
>   <component-id>:  is a positive integer between 1 and 256 (inclusive)
>      that identifies the specific component of the data stream for
>      which this is a candidate.
>
> Is there any reason why component-id ABNF production allows up to 5 digits, while the description only allows 3?

I see no reason. The syntax allowed 5 digits also in 5245, but the maximum value was 256.

So, unless the other authors are aware of a reason why 5 digits needs to be allowed, I suggest: s/1*5DIGIT/1*3DIGIT

---

> 3) In 9.2:
>
>   o  Name, Email, and Address of a contact person for the registration
>
> Considering EU GDPR, I think the WG needs to discuss whether collecting postal address is needed, and if it is, whether IANA has to publish them on the website.

The sub-registry ( https://www.iana.org/assignments/sip-parameters/sip-parameters.xhtml#sip-pns ) created by the recently published RFC 8599 (SIP Push) doesn't require any personal information for registering a new pn-provider value (section 14.5). It only requires (in addition to the new value and a description) a reference to the document that specifies the new value.

So, we could either require e.g., a name and email, or simply not require any personal information.

Any opinions?

---

Regards,

Christer