Re: [MMUSIC] Finding a max length of "a=mid" attribute

Justin Uberti <juberti@google.com> Wed, 03 March 2021 21:56 UTC

Return-Path: <juberti@google.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 678E73A1BDA for <mmusic@ietfa.amsl.com>; Wed, 3 Mar 2021 13:56:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.599
X-Spam-Level:
X-Spam-Status: No, score=-17.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nBKy3i76FzOk for <mmusic@ietfa.amsl.com>; Wed, 3 Mar 2021 13:56:02 -0800 (PST)
Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A30F83A10A6 for <mmusic@ietf.org>; Wed, 3 Mar 2021 13:56:02 -0800 (PST)
Received: by mail-yb1-xb2c.google.com with SMTP id c131so26211167ybf.7 for <mmusic@ietf.org>; Wed, 03 Mar 2021 13:56:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2JShU/QDlR/MT4Xo7X6N2PVcNwSirBT88SFunf0dQGU=; b=GAOfkeG7YSZU7fvbP/wGShQBklUlZvYk4juxdIJ95oy3CmX2t5SF6NSIfolJb1Qdvg OO/AGsRKePPKL60Ji1PU0jvJ5nyKxij3le3P7lol24M7VvlKBzx9ijCosXlMG+TgZfPQ HIQK2bStALN7SyRcQdfLny+0TpyGnw3Sc99paOHj81lstP3Mf7Q++wp2r2XkhNf52vKN rBjKX/rYWdyZ4YYwvzDghS+FduX6ve0jvLp/7EBeoBH4b1kzWYTurjRnHme3PIVTNQx4 ZcWrFvbqrCmbC1BL5LCab1VwivH2Vec147fb1pSBe9SZZLEb/W2xYjh+nrGoOvFGRLM8 LtaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2JShU/QDlR/MT4Xo7X6N2PVcNwSirBT88SFunf0dQGU=; b=bS6LLYmppVCrxtKRzeq5rHbxGpUnDxrZtGtR8SsX1D9vs45JgiLlAKakxnumJNP9PJ rcVSWBhwMv2DrC1TAAuCpOWxNV+ZfsSIez0oO3fLteKPHKawMstQD4j+PankUjMHJ+nc P7rBTTp5d1y9Cc1qbRaPThOFDvTRa6/4G/4r9r+K/XLH6vN+LlPO2kKli8QmkLhX6FhR ugssSQ0fHmk1R41S0D67MHjwoxAgVd5nnV/TPZfNSOzc2F6d6Mp/5HhoH7KRQPteQnl2 Vnigd9EbMrCI7SUhFic77z7oVDNvz5VKlBWSdNyMQhhPuPzjYj5W2R9oD3R8UzfOHvQs TMJA==
X-Gm-Message-State: AOAM533ii/e5eELKglYvEkMzjYs6zgaZBMy4foApEVaXI1kN5PhM9VNl 62eU2AXi54zyJUWx/IndrA9icx7oB6Dzt7YzQwqzfMZtC0xjVw==
X-Google-Smtp-Source: ABdhPJyVgldID6gP1sbDx0h00Ad/vjYMcMwc7jXMGw2CtxjjpWFumbLXM6ozjpwfkdAUmRgLsn6c+W4RPcp8HbKKK0s=
X-Received: by 2002:a25:ab32:: with SMTP id u47mr2090228ybi.46.1614808561138; Wed, 03 Mar 2021 13:56:01 -0800 (PST)
MIME-Version: 1.0
References: <463c848c-d171-7184-d65b-9ea95438d442@alum.mit.edu> <CANKS34fmzw3TNJVJhkUQvWv+EM2SCuEZcp7JgyZbN-p7iqMxfg@mail.gmail.com> <bfd34ef4-d081-c1e9-9985-da1e1b794c58@alvestrand.no> <CA+ag07budQbg1qKa+rR939sQ2CP2aAmnd8jDL93e1_B=QuonQA@mail.gmail.com>
In-Reply-To: <CA+ag07budQbg1qKa+rR939sQ2CP2aAmnd8jDL93e1_B=QuonQA@mail.gmail.com>
From: Justin Uberti <juberti@google.com>
Date: Wed, 3 Mar 2021 13:55:49 -0800
Message-ID: <CAOJ7v-2n2UsV58KzVMG-M9fNW1w-HTOtp5=8z0ZD6FazTOJUDg@mail.gmail.com>
To: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
Cc: Harald Alvestrand <harald@alvestrand.no>, mmusic WG <mmusic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ab420c05bca8eacc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/mW-qBgj3Cjsy3fu5GXCs1hqm81E>
Subject: Re: [MMUSIC] Finding a max length of "a=mid" attribute
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2021 21:56:05 -0000

We have limits on a lot of values for exactly this reason - UDP packets
have a finite length, and therefore when it comes to RTP packetization,
overly long values make things screech to halt.

So I think defining such a limit would be a good idea, but I think you'd
have to reject it rather than ignore it to get deterministic behavior
(which seems like another upside to me).

On Wed, Mar 3, 2021 at 1:43 PM Sergio Garcia Murillo <
sergio.garcia.murillo@gmail.com> wrote:

> If length is >16, shouldn't the 2 byte header extension be used instead?
> that would allow mid values up to 256 bytes.
>
> Best regards
> Sergio
>
>
> El mié., 3 mar. 2021 22:40, Harald Alvestrand <harald@alvestrand.no>
> escribió:
>
>>
>> On 3/3/21 4:06 PM, Nils Ohlmeier wrote:
>> >> Am 3/3/21 um 06:31 schrieb Paul Kyzivat <pkyzivat@alum.mit.edu>du>:
>> >>
>> >> On 3/3/21 3:51 AM, Harald Alvestrand wrote:
>> >>> I'm searching for the source of a max length limit on the "a=mid"
>> attribute.
>> >>> I couldn't find it in RFC 5888 (grouping framework) or RFC 8843
>> (BUNDLE).
>> >>> Does anyone remember where it's supposed to be?
>> >>> (I have code that will insist that it should be 16 bytes or less, but
>> I'm trying to verify that this is the correct limit.)
>> >> Its defined as a token (from RFC4566/8866). And that is:
>> >>
>> >>   token = 1*(token-char)
>> >>
>> >> There is no upper limit on the length. You can't impose a limit for
>> implementation convenience. But practically speaking it is limited by the
>> length of the message body that contains it, so you could code using an
>> offset+length into the message buffer.
>> > While the SDP side might be able to handle really long MID values I
>> > doubt the RTP header extension allow or support that. Maybe your 16
>> > byte length limitation comes from the RTP side?
>>
>> I found that it is impossible to encode an 1-byte RTP header extension
>> longer than 16 bytes (the length is a 4-bit field with a bias value of
>> 1). So in practice, it's an RTP restriction.
>>
>> I think Postel once advised that one should always have length limits -
>> "if you don't have a length limit, you just have an implementation
>> defined limit, and that's worse".
>>
>> So the next question (now that we've settled that the standards don't
>> impose one) is: Should the standards specify a limit?
>>
>> And the third question: if asked to handle a BUNDLEd connection where
>> the MID is > 16 bytes, is it reasonable to just ignore the over-long MID
>> value?
>>
>>
>>
>>
>> >
>> > Best
>> >    Nils
>> >
>> > _______________________________________________
>> > mmusic mailing list
>> > mmusic@ietf.org
>> > https://www.ietf.org/mailman/listinfo/mmusic
>>
>> _______________________________________________
>> mmusic mailing list
>> mmusic@ietf.org
>> https://www.ietf.org/mailman/listinfo/mmusic
>>
> _______________________________________________
> mmusic mailing list
> mmusic@ietf.org
> https://www.ietf.org/mailman/listinfo/mmusic
>