Re: [MMUSIC] Shepherd's review of draft-ietf-msrp-usage-data-channel-17

Jose M Recio <jose@ch3m4.com> Sat, 13 June 2020 06:01 UTC

Return-Path: <jose@ch3m4.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 668FC3A0902; Fri, 12 Jun 2020 23:01:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ch3m4.com header.b=mroEEp/2; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=PkRJXrX+
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2SzBZzg9RpMn; Fri, 12 Jun 2020 23:01:47 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1DB33A081C; Fri, 12 Jun 2020 23:01:46 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 06CF55C019E; Sat, 13 Jun 2020 02:01:45 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 13 Jun 2020 02:01:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ch3m4.com; h= subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=3 Kl09Dt43JfEp3+QhNDA0b4xkMTfCcvsQy7/XLUB4yQ=; b=mroEEp/2BEvEz/9R9 sPvTzgZCme/tE/S97tsNB8gzn96W5eStaGKzoy1YboukqqpmxcDFe0/4Gb2pCGsC OlBmBzsRpPIZiJHVqkNv2MbAEcnD+bQFvNmVqFuz55XyZqlMkXtWHmGKJgJHRwkO FVv/ZXt4FJPERUIaStMDyMoBklWlXO5oWA1CMV+hdNmmMeBFLhAM9Lbb3IPsVA8l FaemgXSOCvW2qPkGOgdItWzSjg8yAXehbcKmp8vapv3X+K47HEmhzWLiD4A99kdA dl8eNReleptMJWUrSlw2vNB2x2IBKTAPJny5DKtfNLUJwJQpfXYkr2o34fJThZvE JlFSg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=3Kl09Dt43JfEp3+QhNDA0b4xkMTfCcvsQy7/XLUB4 yQ=; b=PkRJXrX+OFyklv1jFnC+Ezxw136FxdVx8Z1mUnOgfw7c2SF80Vhq6fbPu m0bw3RR/01q7EV+2y6Hb/mSDFCGX5QDVVw7KY9TqwKwaYLjmQ+WqQCATPwvdkowq HsOx9cHYewI3BRUyz3UQs50J4VhvOALDV3bNCXJsCwrg4/uDohnJE24154c0evWg 2HqVeTpHI1uDn4hi+TmNwYx6yvhGYmc7p1oRu9l6d/wzA6MazXRHjiHez+biXJhU VeMsnz36PmYAGOQ+lph6j1mUxlR9qwVt2Qo33oZZADxpk80frRrlnum3TPT9noxL SwnvVqZiTL65xs8NjNtO2O5j/8gQA==
X-ME-Sender: <xms:yGvkXiEge4NxEyGXCp8u2UIN68nkeBalCJRv3cFediCLV9uBuHEs4A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeivddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhs vgcuofcutfgvtghiohcuoehjohhsvgestghhfehmgedrtghomheqnecuggftrfgrthhtvg hrnhepffegiefhfeehveehveejvdffteekveeltdduvddtkeekveevjefgtdetffdvvddv necuffhomhgrihhnpehgihhthhhusgdrtghomhdpihgvthhfrdhorhhgnecukfhppedufe ekrdejhedrvdduiedrgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhoshgvsegthhefmhegrdgtohhm
X-ME-Proxy: <xmx:yGvkXjVwrB7x3lSc5_EkCzhTOJo-o18Rw8TFgHkpaAAPzzcJOS4chQ> <xmx:yGvkXsK8d1ql5-g2t7QT8_eDkNITSsaPCD-YCZvQb5YlPb1Cy_EH4Q> <xmx:yGvkXsEWTZx8K5er7LDwJpR7U4dERiQNHEcFJogC0V6iXfHQLHEVAw> <xmx:yWvkXjfZTUvJfN96RDGiZFMjq6Oz2JFthE9pixj8OaRuhETAFyhSwQ>
Received: from [192.168.0.102] (unknown [138.75.216.40]) by mail.messagingengine.com (Postfix) with ESMTPA id 0BA643060F09; Sat, 13 Jun 2020 02:01:42 -0400 (EDT)
To: Christer Holmberg <christer.holmberg@ericsson.com>, Bo Burman <bo.burman@ericsson.com>, "draft-ietf-mmusic-msrp-usage-data-channel.authors@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.authors@ietf.org>, mmusic <mmusic@ietf.org>
References: <HE1PR07MB4426977EA914E7253488C5D08D820@HE1PR07MB4426.eurprd07.prod.outlook.com> <AM7PR07MB70122C5F1138C66FA8FBAB5193830@AM7PR07MB7012.eurprd07.prod.outlook.com>
Cc: "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>
From: Jose M Recio <jose@ch3m4.com>
Message-ID: <7435addc-a61f-541d-b382-29727cc8a7a5@ch3m4.com>
Date: Sat, 13 Jun 2020 14:01:40 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <AM7PR07MB70122C5F1138C66FA8FBAB5193830@AM7PR07MB7012.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/qRqXC29WwFLwTlx6yfnl-vmJlKA>
Subject: Re: [MMUSIC] Shepherd's review of draft-ietf-msrp-usage-data-channel-17
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Jun 2020 06:01:48 -0000

PR with updates in 
https://github.com/josemrecio/draft-msrp-data-channel/pull/17

Good catch on the IANA updates about SDP parameters. Given that usage is 
not modified and only a reference needs to be added, I have created an 
omnibus section grouping them altogether for simplicity.

JM


On 10/06/20 19:52, Christer Holmberg wrote:
> Hi Bo,
>
> Thank You for the review! Please see inline.
>
> ---
>
>> 1) Please point more clearly to which IANA registries that are targeted in sections 9.1 and 9.3.
> I suggest the following:
>
> 9.1:
>
> OLD:
>
>     "This document modifies the usage of the msrps URI scheme, registered
>     by [RFC4975], adding DTLS as a protected transport indicated by the
>     URI scheme."
>
> NEW:
>
>     "This document modifies the usage of the msrps URI scheme, registered
>     by [RFC4975], adding DTLS as a protected transport indicated by the
>     URI scheme.
>
>     A reference to RFCXXXX is added to the URI scheme "msrps"
>     in the Uniform Resource Identifier (URI) Schemes Registry."
>
>
> 9.3:
>
> OLD:
>
>     "Usage level "dcsa(MSRP)" should be added to the IANA registration of
>     the SDP setup attribute as follows:"
>
> NEW:
>
>     "The usage level "dcsa(msrp)" is added to the registration of the SDP
>     'hland-send' attribute in the Session Description Protocol (SDP)
>     Parameters registry as follows:"
>
> (Note that "MSRP" is also changed to "msrp", both in the text and in the table.)
>
> ----
>
>> 2) In section 4.4, you are discussing dcsa use of setup, path, msrp-cema, accept-types, accept-wrapped-types, max-size, sendonly, recvonly, inactive, sendrecv, and "all the parameters related to MSRP file transfer" (section 4.7), but only setup has a corresponding IANA section (9.3), asking to register the attribute on dcsa level. Please add IANA >information for all of the other specified attributes as well (as separate sections or extend section 9.3, as you see fit).
> Good catch. We will do that.
>
> ---
>
>> 3) In section 3.1 change sub-protocol value in the body text from "MSRP" to "msrp", for consistency.
> Will modify as suggested.
>
> ---
>
>> Editorial comments/nits:
>>
>> i) Consider aligning all occurrences of "a MSRP" to "an MSRP".
> Will modify as suggested.
>
> ---
>
> https://tools.ietf.org/tools/idnits/:
>> a) The document has no formal "updates" tag in the file header, it just mentions it in the abstract. Please use the formal title page header format, also for the provided XML.
> We will add updates="4975" to the XML rfc tag.
>
>> b) The abstract contains RFC4975 as a reference, which cannot be part of an abstract and must be replaced with a plain-text mention of that RFC.
> Will fix.
>
> ---
>
> Regards,
>
> Christer
>