Re: [MMUSIC] [secdir] Review of draft-ietf-mmusic-sctp-sdp-22

Paul Kyzivat <paul.kyzivat@comcast.net> Fri, 10 February 2017 21:38 UTC

Return-Path: <paul.kyzivat@comcast.net>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD3C0129C5A for <mmusic@ietfa.amsl.com>; Fri, 10 Feb 2017 13:38:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=comcast.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JOjeiuuwG4vy for <mmusic@ietfa.amsl.com>; Fri, 10 Feb 2017 13:38:34 -0800 (PST)
Received: from resqmta-po-02v.sys.comcast.net (resqmta-po-02v.sys.comcast.net [IPv6:2001:558:fe16:19:96:114:154:161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7F35B129C5F for <mmusic@ietf.org>; Fri, 10 Feb 2017 13:38:34 -0800 (PST)
Received: from resomta-po-12v.sys.comcast.net ([96.114.154.236]) by resqmta-po-02v.sys.comcast.net with SMTP id cItccoV7iJ5z3cItlccDfi; Fri, 10 Feb 2017 21:38:33 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1486762713; bh=7tDqX5nGw8BcSEyogUbMdVOJwrDRWay92FsFnlZzSyg=; h=Received:Received:Subject:To:From:Message-ID:Date:MIME-Version: Content-Type; b=E4w+Zb+WTtLmMBLg/94ZE03mxnGoYiu1dkvpIPoXpoSzBsGUqz6To67NO/9zf2XiD waB/MNf+PScw0Asqy9nDvXeuO10OpL743Li27cptZyiZj3vuMO9TUr6pi9P38nCeyh kP5d7lKSfTj9MabEvyUAmSn0/ptNrdUf1+mfcvU/Ajq9xebkLXiwNAGfWdAL2xwYnL sEi2e4AdIzPjui86l6GmEsdRrfAU+37ivfAsVkh4QRjoP+2sZdr+lxxwq/4Or/IH+d Y1Br1ky1dUpO5nG7slX9hlqSH1warqPUFi3uoiWQbkRUFljQ0p/ZhmT81MqO2WkN7P FnqM4K5m96VuA==
Received: from [192.168.1.110] ([73.186.127.100]) by resomta-po-12v.sys.comcast.net with SMTP id cItkcwJXIL4A9cItkcosTN; Fri, 10 Feb 2017 21:38:33 +0000
To: mmusic@ietf.org
References: <148669725288.8138.2095744202497272272.idtracker@ietfa.amsl.com> <alpine.LRH.2.20.1702092230300.22742@bofh.nohats.ca> <D4C388CF.17C73%christer.holmberg@ericsson.com>
From: Paul Kyzivat <paul.kyzivat@comcast.net>
Message-ID: <e9af1b9f-8943-5b7b-3d6b-0bd1c38f46e9@comcast.net>
Date: Fri, 10 Feb 2017 16:38:32 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <D4C388CF.17C73%christer.holmberg@ericsson.com>
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope: MS4wfEdoB83f8ViJU6cEXKX3c9PxtJceW6gndDkiWGj3YYrml6e6spEfPnUG+vJ5JfoUpF4UK1OVNcNsRZREt8+2q2tU1Ie8yIn5hHoUXOTQEuxrcad0Jd/P Jr+8aNWts29XYa1Z+c9hRMBdRRYlB9C9EDEsqiml4nStf4BlOJHT3cZOsrtBj+/rj7QUURCDC6TcTg==
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/s86tHNmfO-trf7OopoIY8ob5Wr0>
Subject: Re: [MMUSIC] [secdir] Review of draft-ietf-mmusic-sctp-sdp-22
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Feb 2017 21:38:42 -0000

On 2/10/17 9:15 AM, Christer Holmberg wrote:

>> Section 5.2:
>>
>> 	Leading zeroes MUST NOT be used.
>>
>> What is the problem with leading zeros? What can go wrong when these are
>> used? Should
>> an implementor be warned about something specific?
>
> I don¹t know. The same statement exists for a number of SDP attributes,
> but I didn¹t find any justification.

This is standard practice in RFC4566. It has an ABNF rule:

    integer =             POS-DIGIT *DIGIT

that makes it invalid to insert leading zeros. I don't *know*, but 
speculate, that this might be tied to the C language convention where a 
leading zero means octal, and not wanting to introduce that confusion.

But the sctp port value isn't defined using the 'integer' rule. It has 
its own definition:

             sctp-port-value = 1*5<DIGIT defined in RFC4566>

To be consistent, perhaps that should be changed to:

             sctp-port-value = <POS-DIGIT defined in RFC4566>
                               *4<DIGIT defined in RFC4566>

	Thanks,
	Paul