Re: [MMUSIC] [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 13 July 2020 08:58 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E17F93A0C61; Mon, 13 Jul 2020 01:58:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.202
X-Spam-Level:
X-Spam-Status: No, score=-0.202 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jo3Qvy7PBM8s; Mon, 13 Jul 2020 01:58:13 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5DE8A3A0C5F; Mon, 13 Jul 2020 01:58:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RyjXnyd1ZAEjZNXknzNNU2zxHtYxkW0vOnprQJptS3/X2h0u1M+MqN04CXtOvREs4N1AaBHMQ1Ai7qt5gruu9FU8f9Lkw2toEXtqhPZ327mpYNRGw4kpIxhdOmjKWv8BXnDgeMZ+bmY5gZ+08YKjIA4aABoHDn/dCCn+gN5MrYXJipV5HWcKoeDrms9k8SVnjQ3bCSjxuITkh11BsU16/8wGJeHiUgFv6BpG11tPuYMx3ibGShSpfnGcAxg4vyxlc1yGxb+yGepXbB7tqCQ3YswWMXI0qfkXYSNSFzCxBp2wQgEyuTarAFw8B2VOkxLtF1yHYd+rT09WlLWosSto1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMH4q9RrxCnC2vf9sf3WbwsPng+GdAnfYn0WA4ixawg=; b=QstPWU9jo0yZTEpd7FLol7e06UttIkMkZonrP0kWNHWGIUvzaAJ1iCIF4VwLxcdtBQ3YwWOm/4Zrm2E0ElxWPpP+Hs3zG/uKw+PtNlB98pe4sgD1a5IptyHCBq+zXUSa0zGHGrUMTrlZFcYGUCwxHUoFeWhhmbyQFJFrK0NVVgw9cYhF9Q7+XzkwaRNahfCZEGSK0odlC42BRF5/ft6Bc43dkyMOHOsrSsdBqLfLy2kUHyYmqCQrGOKNCeL237kLciUd+EPvORSmHP0nNHBdfzZGz8vIr8gzw8yiVwoU5iGDoRUpcvvAQI5KbrnU7mV6bLawWiMtjQ5A8vceOEtTZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMH4q9RrxCnC2vf9sf3WbwsPng+GdAnfYn0WA4ixawg=; b=aGwm4Y/+5UQVtBvp2+kEHiVZQXJ3u18+wPz+dS0avPZRw2FuHwL2n1TWvFFAdZAjzW4OTFjSjbfFBhpqOw7egF8nAi2+UBtwfyqZA0cdgkOFdbfBKgQj6xkV52SSj8QpQ20HjVB2BMsXp3PUDvHreCx6VvqQ8R1TccKGXiTIA0U=
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com (2603:10a6:20b:1bc::19) by AM5PR0701MB2452.eurprd07.prod.outlook.com (2603:10a6:203:d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.10; Mon, 13 Jul 2020 08:58:06 +0000
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::68d5:e267:db47:9d39]) by AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::68d5:e267:db47:9d39%6]) with mapi id 15.20.3195.013; Mon, 13 Jul 2020 08:58:06 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Brian Carpenter <brian.e.carpenter@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Thread-Topic: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
Thread-Index: AQHWWJ10s19LL8LqLkyup5236uCREKkFKsQA
Date: Mon, 13 Jul 2020 08:58:06 +0000
Message-ID: <AM7PR07MB7012B935296554B783A0995393600@AM7PR07MB7012.eurprd07.prod.outlook.com>
References: <159459362316.14150.6160122631877971567@ietfa.amsl.com>
In-Reply-To: <159459362316.14150.6160122631877971567@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.127.223.154]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 51d30118-3aef-46ab-e5f9-08d8270adc07
x-ms-traffictypediagnostic: AM5PR0701MB2452:
x-microsoft-antispam-prvs: <AM5PR0701MB24523C436EAA53F24C81200893600@AM5PR0701MB2452.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 34ZGZwP6H9UrfpfziCV7hvoJ4MmHVPegUTtE4JVW6ZEDx38ADw86YMUhBUcDxTRPwLq2AOqDm3y32q+hi+lhwxQnLmVtWqjMHhz3OvBIGemATTDHMi7yh8d9gkGZALPPNgffKhbjyT1Rtxn3zkP7lbMWvcosnFg/v/pzW33spNIu0cm0tR05AV5k6nZdh7JNq34ZKiqjWMkw/pUVWMv+p3BvqN+jMbzQ3OgFZnwbBDSCgus5f/7RIcnSw6KOdYq24AMT5Otuz3dNT9HgaSIpatvDYxZlwZoVEodgch64iKgZqFYK1LqRCE4Dk4r+skLCZQOu56n/AGmilA2c7N4fag==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB7012.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(52536014)(5660300002)(54906003)(110136005)(71200400001)(26005)(7696005)(55016002)(9686003)(6506007)(4326008)(83380400001)(186003)(8936002)(478600001)(8676002)(44832011)(76116006)(64756008)(66946007)(66556008)(316002)(86362001)(66476007)(2906002)(66446008)(33656002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: BauP9+dWxASRiGDlMVspEo/mTKHLCOTI0q91cIYXQhzS6toNMSj88lCC5J94S16G77I5ZnpNXMqmkbOH4DsqYSFmYAAMV9YkswjitR8a+77Cy3KXQqI6lXy16vCzK4EIJrlRQxQ6Vfi3bYRuzPNG63lLYo+fMbHu9FVK2UNw7MLNQD4oH2J8v0xWQxfKlI5D4EoqCNUsFd8/xfw1LlmxHaLbFrYLtSotDgBuEuwKYBy5G3i3qlTmgpU5e2wDepD9uv61WpA6bYYl4zmd6dsQSBIoannyipxA6xH43WewxUbe9TZ5Vi2mpCJC/L7+CblYYDQCwTgPS+BJk7Dce5idBIqPRTBgXxUdjvdzd+bhlp5/1uaeDh8W+HcA0or8c7Q6d5qJrK5cu9fqHFqOP0pTFY4gM7jMTC00/O5glVtcIu8hxeSorbxXRF9splX28S4rmzJbe9hgBYkfSFNLFWriCKsbdk5wlSVKL7SreXlMcKDSY1Q1JXxZJXt9V4CLGTby
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB7012.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51d30118-3aef-46ab-e5f9-08d8270adc07
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 08:58:06.7188 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KG/Nt0vMzIFMEfneW7iVAZxG+RvUw0U1mhpl6c7Q8KsVfglfcAWZ/ltuNEWqGwrELiIuLCOXRQ8TqXpwQQnT7eFp4uiIzY/93QTTlqNQ340=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB2452
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/lRv-flLaUmQs6UWF8VSTh_cQwZg>
Subject: Re: [MMUSIC] [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 08:58:15 -0000

Hi Brian,

Thank You for the review! Please see inline.


Nits:
-----

>> 4.1.  MSRP URI
>> ....
>>     transport  /= "dc"
>>
>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>
>>     transport  =  "tcp" / "ws" / 1*ALPHANUM
>>
> The advantage of listing out
>
>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>
> would be that the reader sees the full list.

The MMUSIC WG has previously decided to take the approach of only writing the new value, using the "/=" format.

---

>>                  ; Add "dc" to existing transports per [RFC4975]
>>
>>I suggest
>>
>>                 ; Add "dc" to existing transports per Section 9 of [RFC4975]

Will modify as suggested.

---

>>4.6.  Session Closing
>>
>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>   present in the SDP answer if no corresponding attributes are present
>>   in the received SDP offer.
>>
>> Should that be MUST?

The reason for "must" is that is referring to generic data channel SDP O/A procedures.

I suggest to remove the paragraph.

---

>> B2BUA
>>
>> Define the acronym please.

We normally don't do that in MMUSIC specifications. Also, it is on the IETF list of well-known acronyms.

Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back User Agent (B2BUA)'

---

>> 9.2.  Subprotocol Identifier MSRP
>>
>>   A reference to this document is added to the subprotocol identifier
>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>
>> s/this document/RFCXXXX/

Will modify as suggested.

---

>> 11.  CHANGE LOG
>>
>> Mark this section for deletion by the RFC Editor

I think the RFC Editor will delete it by default, but we can add explicit text.

Regards,

Christer