Re: [MMUSIC] Comments on draft-pthatcher-mmusic-rid-00

Byron Campen <docfaraday@gmail.com> Thu, 08 October 2015 20:52 UTC

Return-Path: <docfaraday@gmail.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09BEC1ACE03 for <mmusic@ietfa.amsl.com>; Thu, 8 Oct 2015 13:52:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QY-2QM0omEl6 for <mmusic@ietfa.amsl.com>; Thu, 8 Oct 2015 13:52:42 -0700 (PDT)
Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D5C41ACE01 for <mmusic@ietf.org>; Thu, 8 Oct 2015 13:52:42 -0700 (PDT)
Received: by wicfx3 with SMTP id fx3so45108406wic.1 for <mmusic@ietf.org>; Thu, 08 Oct 2015 13:52:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=3/XxFJzYAL2xIr46edDD/YRGY5k9iSZ02DmF886Ujt4=; b=rVpb/rWGvxmodshR0zLtx3mffk4PUPJxB9tFWxaHFwfn9bjhb+cKScT9yEAB6e7Ab0 k5dYQJrFm9rLYVoqivWd6EtSmAzZ74eEpm5vwm1DvqLl7MHSkTDil4B7hIJhrVS2lYZA VTPlqyTKIFILK8FDGIMbQzAPsXGnT7tarkI59c3Wv7R7aWsERxUAUZZxw3YGhGrOU9Su bgn4YVfX6hAKpYAlnD2msrLu18+AGT7SHlkjojul8q6vFjEHZQPYu0rRiy8EDXcKpwIJ jkj7JB5yK8v6bVMMZKDlClVFMXlx6GNrjA1Ii6n7o4slehcPIe4OlxXpdW6DTlVWBw61 WAeg==
MIME-Version: 1.0
X-Received: by 10.194.235.6 with SMTP id ui6mr11812709wjc.92.1444337560651; Thu, 08 Oct 2015 13:52:40 -0700 (PDT)
Received: by 10.27.54.16 with HTTP; Thu, 8 Oct 2015 13:52:40 -0700 (PDT)
In-Reply-To: <CADyBEEFjgVR8Yf8RnCii6fuVxf=YN8S6Av4YruwU2PB5Lu_hZg@mail.gmail.com>
References: <5604B29B.9070005@nostrum.com> <CAMRcRGQngExyrL0doFidea19D8QAvCAgwjoaS=DO+upNGXxL0w@mail.gmail.com> <5612A3C5.8070508@alum.mit.edu> <CADyBEEFjgVR8Yf8RnCii6fuVxf=YN8S6Av4YruwU2PB5Lu_hZg@mail.gmail.com>
Date: Thu, 8 Oct 2015 15:52:40 -0500
Message-ID: <CADyBEEGpXqRhW8bK_dqx9475Sq8QfnfY-bLz5giruoXEjv+DmQ@mail.gmail.com>
From: Byron Campen <docfaraday@gmail.com>
To: mmusic@ietf.org
Content-Type: multipart/alternative; boundary=089e01493bd03d11ec05219e0b47
Archived-At: <http://mailarchive.ietf.org/arch/msg/mmusic/szn1Lh9MCtyj6nbOkxDf2a3d52A>
Subject: Re: [MMUSIC] Comments on draft-pthatcher-mmusic-rid-00
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Oct 2015 20:52:44 -0000

   Some additional feedback on the grammar:

- The use of ';' as a delimiter for rid-list complicates the parse code if
';' is also used as a delimiter for rid-attr-list. For example, consider:

a=rid:3 send pt=96 depend=1;2;max-fps=30
vs
a=rid:3 send pt=96 depend=1,2;max-fps=30


- There does not seem to be anywhere for extensions to rid-attr-list to
hook in. We should make room for that, and forbid any such extensions from
using ';' since that is reserved as a delimiter.

- There is an example where max-br takes no value:

a=rid:1 send pt=97; max-br=; max-height=720;

   Is this intended?

Best regards,
Byron Campen

On Thu, Oct 8, 2015 at 12:47 PM, Byron Campen <docfaraday@gmail.com> wrote:

>
>
> On Mon, Oct 5, 2015 at 11:22 AM, Paul Kyzivat <pkyzivat@alum.mit.edu>
> wrote:
>
>> * Section 10.*:
>>
>> The a=rid lines in most/all of the examples are inconsistent with the
>> syntax. E.g. The following:
>>
>>    a=rid:1 send pt=*; max-width=1280; max-height=720; max-fps=30
>>
>> ought to be:
>>
>>    a=rid:1 send pt=* max-width=1280;max-height=720;max-fps=30
>>
>>
>    Actually, it is worse than this; the grammar does not permit more than
> one of "max-width", "max-height", etc. Also, the use of <param-val> (aka
> <byte-string>) as the values of things like max-width precludes the use of
> any delimiter, since param-val can contain anything except NUL, CR, and LF.
> Things like max-width really should be a positive integer, so the grammar
> will need to be tightened down. I'm guessing that what the author was
> shooting for was ';' delimited, with positive integer values for everything
> but depend=.
>
>    Also, I would expect that stuff like pt=*,96,8,* is not permitted, but
> the current grammar permits it.
>
> Best regards,
> Byron Campen
>
>