Re: [MMUSIC] ICE-SIP-SDP: Concluding ICE statement

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 23 July 2019 22:33 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D7F7120352; Tue, 23 Jul 2019 15:33:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dnSzBsmOjc5x; Tue, 23 Jul 2019 15:33:01 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 510861203C2; Tue, 23 Jul 2019 15:33:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ub9wwSp/rM7WDQ3KQzrVRcnh8E0BtNt7DSzK3cZZV1MdW0GjyYZ4Yrbul9TnjffkH1Vm+o5LWsRVLSce9IWmxKfuVOrSuweNu/IuzMc52c3p9l257JAFbzPB8FkJYNpRvgZW05H6xDupH536OerKZ07WlLNgcEkK/qUOQA8RhJ1IVtZdcZzO10SfUpr/jrBbepfKAvmY0ZXPPQonKcF/GdADkKSAiwCyEZH0B07CwfGyS+94slldo7wbySsqu7+jWpD50UzGw773zNwM3re9DTNMcPbC6MXpXus57sUrthsKKztYKRnBE/PesVct+aMbT7jFRj3yaOKpELbC/HLzAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=menYlhZYzT3KL3aY/0kmMm4peh41JmdFFp4Mhin9wkc=; b=iNM98QTlIpTKXbZcggis1RfvaoJ7UigdRRSmVEB0UjLxucZ1ZQDDwDfHcwM+0+S5gq1+z2OPafsOP/50epiLf3rtinU9FDHESgoRh3FlDchBAEgAnWyEx17mzmSr9OZkxQPAcVJQTluY3he6e0ABNajtkJY7a/BBabPTn5iiTDysAonH9nvKi/GnObgxuSEZx+2fZdpZfr3ZRF13tVeWP1RTIZuyHVW85yMIJJj+c+dB7FryknsMHEb8z9ufbLx3pZTSu9VJdRaIZtrPM2aJtMx+FuNesQBJP4YcVTuyiykGngG5MvlZWRsJCKI5PLnjwGT+d9w+pozR23SNnoNncQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=ericsson.com;dmarc=pass action=none header.from=ericsson.com;dkim=pass header.d=ericsson.com;arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=menYlhZYzT3KL3aY/0kmMm4peh41JmdFFp4Mhin9wkc=; b=QVnmFqVC/orDWiVMbhAse48n0cmefSYw1l35YcgSuaiPn4k1ZwQFRUVj/Zyg7cEtck6rve1TOsUiyc9MWF4nBavlLN4Omv7IHR2bqNceYr2do51ASjZJYXfvb2bGbXH6SbC1sadJDXnzFNPNFywjlJCXlh7WDZvxrJGTPvZ/xA0=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB4396.eurprd07.prod.outlook.com (20.176.167.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 23 Jul 2019 22:32:58 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec0d:f9d3:7159:ba7]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::ec0d:f9d3:7159:ba7%6]) with mapi id 15.20.2115.005; Tue, 23 Jul 2019 22:32:58 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Roman Shpount <roman@telurix.com>
CC: "mmusic@ietf.org" <mmusic@ietf.org>, "mmusic-chairs@ietf.org" <mmusic-chairs@ietf.org>
Thread-Topic: [MMUSIC] ICE-SIP-SDP: Concluding ICE statement
Thread-Index: AQHVPKw2e0+KSgDw30S7CQWjva3tSabPVecAgAAKTjCAAAZygIAAf57AgAEHkwCAAAPEcIAAD1gAgADg04CABWbzgIAAbD1AgADkGoCAACN3sIAACNMAgAAGYcCAAAPdAIAAAa1g
Date: Tue, 23 Jul 2019 22:32:58 +0000
Message-ID: <HE1PR07MB3161B334C6E49871CC9673E593C70@HE1PR07MB3161.eurprd07.prod.outlook.com>
References: <804B6CBB-3614-4CD5-82FC-0E475F716E18@ericsson.com> <CAD5OKxvYQZz_6RpMf9FvSFx+Mz1=cTUC5-cw3o6jVgKqMKLxSQ@mail.gmail.com> <HE1PR07MB316103A8253F36D03E718AB793C90@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxv4kSM3xbqB7Kag3=qdV_4W3T9RbB4D-DLXeNJVqqzOwA@mail.gmail.com> <HE1PR07MB31611980F5E438EFA620329C93C80@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxsoRrvzvnc4uSwmbJgMzv7Y4bmjPc4fYv4iGhogtyJTzQ@mail.gmail.com> <HE1PR07MB316164B3D661E223F7F892BA93C80@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxuA-Kt_NONWorafn1XPNgKJGvR6XLb2f5sx+_WkW4hz-A@mail.gmail.com> <41178B75-AB52-4CD0-A157-3E8EA6778DE2@ericsson.com> <CAD5OKxsHGK6gpz3rM42BAK4vpwV3RHK=F5QZBPViXGF4quNuJw@mail.gmail.com> <HE1PR07MB3161D26FD5FA4C43821D86BB93C70@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxvaVw877ee7sfjnfxcecbcPM370YVQkwtqNrWUCpDLM-w@mail.gmail.com> <HE1PR07MB31616857A2CBFD17202C9B5993C70@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxv_GwmXdYN0P3J7H_Brf5hRXc2yQGtjppdyRL7Zm=SkzQ@mail.gmail.com> <HE1PR07MB3161B5786C7BBA2926AB75A593C70@HE1PR07MB3161.eurprd07.prod.outlook.com> <CAD5OKxscsSa03o_T2GdhvwYkvYc2wxMSsmXQAe2QizRWQ-WHrw@mail.gmail.com>
In-Reply-To: <CAD5OKxscsSa03o_T2GdhvwYkvYc2wxMSsmXQAe2QizRWQ-WHrw@mail.gmail.com>
Accept-Language: en-US
Content-Language: fi-FI
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [79.134.118.162]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7d3caa32-f719-462e-e8e0-08d70fbdb6e5
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:HE1PR07MB4396;
x-ms-traffictypediagnostic: HE1PR07MB4396:
x-microsoft-antispam-prvs: <HE1PR07MB43964C972E87808CFE5FA36593C70@HE1PR07MB4396.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0107098B6C
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(189003)(199004)(81166006)(68736007)(66446008)(4326008)(81156014)(66556008)(71190400001)(76116006)(53936002)(66476007)(64756008)(8936002)(478600001)(6506007)(86362001)(66946007)(71200400001)(7696005)(66066001)(76176011)(2906002)(186003)(102836004)(14444005)(3846002)(26005)(5660300002)(6116002)(476003)(14454004)(11346002)(446003)(316002)(305945005)(6916009)(7736002)(74316002)(9686003)(44832011)(54906003)(99286004)(33656002)(486006)(55016002)(6436002)(256004)(52536014)(25786009)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB4396; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: C/K37eVxuMfP/nD5mOAqAhrBXe3RX+DcTe9MxFUNP1DtEmZvU0eA/m8krYzyJ8bBUiotNy5c5kBmvk1oil7TGytKtLOEkvgj2BsPCXZEt622EI3v7efcluNSE2VuD51+xUoSYJHsqJ0orvj3/mXLl2Xz5zRQc0cD0Xt/BZpLvfQQ+CAdrmJm96lfcV/Ag5FcZUXv7SKvlhty1LkPrC4UvRKUjYwX4jYi/rDcOTnxsJIgsCwX2Tz4hcihwmBvlimEAmz0fu9p0I2iVUzJyIuxnnLEzSI6Wcl7NA/y/87cBD1ip9k12W80EM9Eu4imqN6yjTPwJ1Upbc1jiViiYmjOrJzMuCgheO6OENoeZG0Ma3u+DtH3r50A2iXXGeTON/y+cki34P/vkpc0KP2LJMia2sYfToJh71qM+AT9Gz8v1TM=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3caa32-f719-462e-e8e0-08d70fbdb6e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 22:32:58.5981 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: christer.holmberg@ericsson.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB4396
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/uivrP6FbUt4N1m80J0u75yAGmyE>
Subject: Re: [MMUSIC] ICE-SIP-SDP: Concluding ICE statement
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2019 22:33:04 -0000

Hi,

...

>> If there are Failed check lists, shouldn't there be a subsequent update with port set to zero no matter if there is 'ice2' or not?
>>
>> RFC 8445 says that "The agent MUST take proper actions for removing the failed data stream."
>
> You are right and I would assume ice-sip-sdp should spell this out. How about:
>
> Once the agent has successfully nominated a pair, the state of the check list associated with the pair is set to Completed. Once the state of
> each check list is set to either Completed or Failed, for each Completed check list the agent checks whether the nominated pair matches the 
> default candidate pair. If there are one or more pairs that don't match, and the peer did not indicate support for the 'ice2' ice-option, the controlling 
> agent MUST generate a subsequent offer (Section 3.4.1), in which the connection address, port and transport protocol in the "c=" and "m=" lines 
> associated with each data stream match the corresponding local information of the nominated pair for that data stream. Furthermore, if there are 
> any Failed check lists, the controlling agent MUST always generate a subsequent offer, even if  the peer did indicate support for the 'ice2' ice-option. 
> This offer MUST reject all data streams associated with a Failed check lists by setting port in "m=" line to zero.

Looks good. Just a few minor editorial change suggestions:

Once the agent has successfully nominated a pair, the state of the check list associated with the pair is set to Completed. Once the state of
each check list is set to either Completed or Failed, for each Completed check list the agent checks whether the nominated pair matches the 
default candidate pair. If there are one or more pairs that don't match, and the peer did not indicate support for the 'ice2' ice-option, the controlling 
agent MUST generate a subsequent offer, in which the connection address, port and transport protocol in the "c=" and "m=" lines 
associated with each data stream match the corresponding local information of the nominated pair for that data stream (Section 3.4.1.2.2.). 
Furthermore, if there are one or more check lists with the state set to Failed, the controlling agent MUST generate a subsequent offer in order to remove 
the associated data streams by setting the port value of the data streams to zero (Section 3.4.1.1.2.), even if  the peer did indicate support for the 'ice2' ice-option. 

Regards,

Christer