[MMUSIC] Mirja Kühlewind's No Objection on draft-ietf-mmusic-ice-sip-sdp-37: (with COMMENT)

Mirja Kühlewind via Datatracker <noreply@ietf.org> Mon, 05 August 2019 17:18 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: mmusic@ietf.org
Delivered-To: mmusic@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 73C85120297; Mon, 5 Aug 2019 10:18:48 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: =?utf-8?q?Mirja_K=C3=BChlewind_via_Datatracker?= <noreply@ietf.org>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-mmusic-ice-sip-sdp@ietf.org, mmusic-chairs@ietf.org, fandreas@cisco.com, mmusic@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.99.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: =?utf-8?q?Mirja_K=C3=BChlewind?= <ietf@kuehlewind.net>
Message-ID: <156502552845.24515.11157901358870690278.idtracker@ietfa.amsl.com>
Date: Mon, 05 Aug 2019 10:18:48 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/yyEgmiiNiYh7kMZnZkT3FXcWx6E>
Subject: [MMUSIC] =?utf-8?q?Mirja_K=C3=BChlewind=27s_No_Objection_on_draf?= =?utf-8?q?t-ietf-mmusic-ice-sip-sdp-37=3A_=28with_COMMENT=29?=
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Aug 2019 17:18:49 -0000

Mirja Kühlewind has entered the following ballot position for
draft-ietf-mmusic-ice-sip-sdp-37: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mmusic-ice-sip-sdp/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

1) First I have a processing question for the IESG (and maybe the RFC editor)
but it might be just me not knowing this: As I understand it, RFC5245 was spilt
up into RFC8445 and this document, however, I find it a bot odd that both
documenst obsolete RFC5245. Is that what we usually do? Did we have this case
before? Is that the right thing to do?

2) One quick question: Why is a port value of "9" used to signal use of the
default destination, instead of e.g. "0"? Is that because port "0" is used to
reset the data stream? However, couldn't this combination of address and port
"0" not be treated differently? Or is that to avoid any potential false
connections? How could that happen? Isn't there a better way to do that? I
mainly would like to understand what the reason is and maybe request to also
explain this in the document.

3) A minor editorial comment
Sec 4: "This specification defines eight new SDP attributes"
Given these attributes have already been specified in RFC5245, I wouldn't call
them "new".

4) Question on sec 4.1:
"   <transport>:  indicates the transport protocol for the candidate.
      This specification only defines UDP.  However, extensibility is
      provided to allow for future transport protocols to be used with
      ICE by extending the sub-registry "ICE Transport Protocols" under
      "Interactive Connectivity Establishment (ICE)" registry."
The registry also contain an entry for TCP (see RFC6544). However, I also
wonder a bit why a new registry was created initially instead of just using the
protocol numbers or keyword in the IANA Protocol Numbers Registry...?

5) A request in section 5.4:
"If absent in an offer and answer the default value of the attribute
   is 50 ms, which is the recommended value specified in [RFC8445]."
RFC8445 also specifies a minimum of 5ms (MUST). It would be good to also
indicate here that this minimum exists without relying on the user to look up
RFC8445.

6) Also further on in section 5.4:
   "Once both agents have indicated the pacing value they with to use,
   both agents MUST use the larger of the indicated values."
Given this in normatively specified in RFC8445, maybe you should not use
normative language in this document but provide in addition again a reference
to RFC8445.

7) And similar on the use of MUST in section 5:
"The keepalives MUST be sent
   regardless of whether the data stream is currently inactive, .."
This is specified in RFC8445, so maybe consider not using normative language
here as well... however, this case is maybe less clear.

8) You probably should explicitly instruct IANA in the IANA consideration
section to update the references to this RFC instead of RFC5245 in the
respective registry.