[Mpls-review] 答复: MPLS-RT review of draft-raza-mpls-ldp-applicability-label-adv

Mach Chen <mach.chen@huawei.com> Wed, 27 June 2012 03:44 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: mpls-review@ietfa.amsl.com
Delivered-To: mpls-review@ietfa.amsl.com
Received: from localhost (localhost []) by ietfa.amsl.com (Postfix) with ESMTP id 6EE5C21F85B8 for <mpls-review@ietfa.amsl.com>; Tue, 26 Jun 2012 20:44:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.352
X-Spam-Status: No, score=-2.352 tagged_above=-999 required=5 tests=[AWL=3.195, BAYES_00=-2.599, J_CHICKENPOX_21=0.6, MIME_8BIT_HEADER=0.3, RCVD_IN_DNSWL_MED=-4, SARE_SUB_ENC_UTF8=0.152]
Received: from mail.ietf.org ([]) by localhost (ietfa.amsl.com []) (amavisd-new, port 10024) with ESMTP id EFsGvInsx8Cx for <mpls-review@ietfa.amsl.com>; Tue, 26 Jun 2012 20:44:53 -0700 (PDT)
Received: from dfwrgout.huawei.com (dfwrgout.huawei.com []) by ietfa.amsl.com (Postfix) with ESMTP id B82A421F85B4 for <mpls-review@ietf.org>; Tue, 26 Jun 2012 20:44:53 -0700 (PDT)
Received: from (EHLO dfweml202-edg.china.huawei.com) ([]) by dfwrg02-dlp.huawei.com (MOS 4.2.3-GA FastPath) with ESMTP id AHF93883; Tue, 26 Jun 2012 23:44:53 -0400 (EDT)
Received: from DFWEML405-HUB.china.huawei.com ( by dfweml202-edg.china.huawei.com ( with Microsoft SMTP Server (TLS) id 14.1.323.3; Tue, 26 Jun 2012 20:43:02 -0700
Received: from SZXEML405-HUB.china.huawei.com ( by dfweml405-hub.china.huawei.com ( with Microsoft SMTP Server (TLS) id 14.1.323.3; Tue, 26 Jun 2012 20:42:58 -0700
Received: from SZXEML511-MBS.china.huawei.com ([]) by szxeml405-hub.china.huawei.com ([::1]) with mapi id 14.01.0323.003; Wed, 27 Jun 2012 11:42:52 +0800
From: Mach Chen <mach.chen@huawei.com>
To: Ross Callon <rcallon@juniper.net>, Nischal Sheth <nsheth@juniper.net>, "thomas.morin@orange.com" <thomas.morin@orange.com>
Thread-Topic: MPLS-RT review of draft-raza-mpls-ldp-applicability-label-adv
Thread-Index: Ac1O7viHN2hrb6y1R2mvf0ff4lr/LgFJBJfA
Date: Wed, 27 Jun 2012 03:42:52 +0000
Message-ID: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE22C9CDD18@SZXEML511-MBS.china.huawei.com>
References: <DF7F294AF4153D498141CBEFADB17704C7120F21D3@EMBX01-WF.jnpr.net>
In-Reply-To: <DF7F294AF4153D498141CBEFADB17704C7120F21D3@EMBX01-WF.jnpr.net>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
x-originating-ip: []
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mailman-Approved-At: Tue, 26 Jun 2012 23:43:21 -0700
Cc: George Swallow <swallow@cisco.com>, "mpls-review@ietf.org" <mpls-review@ietf.org>, Luca Martini <lmartini@cisco.com>, "Sami Boutros \(sboutros\)" <sboutros@cisco.com>, "skraza@cisco.com" <skraza@cisco.com>, Nic Leymann <N.Leymann@telekom.de>, Martin Vigoureux <martin.vigoureux@alcatel-lucent.com>, Loa Andersson <loa@pi.nu>
Subject: [Mpls-review] =?utf-8?b?562U5aSNOiBNUExTLVJUIHJldmlldyBvZiBkcmFm?= =?utf-8?q?t-raza-mpls-ldp-applicability-label-adv?=
X-BeenThere: mpls-review@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: MPLS Review <mpls-review.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls-review>, <mailto:mpls-review-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls-review>
List-Post: <mailto:mpls-review@ietf.org>
List-Help: <mailto:mpls-review-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls-review>, <mailto:mpls-review-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2012 03:44:54 -0000


I have read and reviewed draft-raza-mpls-ldp-applicability-label-adv-02. 

Overall, I think this draft is useful and ready to be considered for WG adoption.

I also have some comments on the draft:

1. Section 4.1, 
"Any document specifying a new FEC SHOULD state the applicability
     of the negotiated label advertisement discipline for that FEC."
I agree with Luca, a "MUST" (instead of "SHOULD") should be more appropriate.

2. Section 5
It's not clear the "future work" is of this draft or the WG(I guess its later), especially for the first paragraph, it gave me the impression that this draft will define per-FEC/application capability negotiation in the future. And the second paragraph is a bit overlap with Section 4.1.  So, I'd suggest to remove this section. If want to keep it, you could just keep the first paragraph and clarify the new extension is out of scope. 

Best regards,

发件人: Ross Callon [mailto:rcallon@juniper.net] 
发送时间: 2012年6月20日 22:14
收件人: Nischal Sheth; Mach Chen; thomas.morin@orange.com
抄送: Loa Andersson; George Swallow; Ross Callon; Martin Vigoureux; mpls-review@ietf.org; skraza@cisco.com; Sami Boutros (sboutros); Luca Martini; Nic Leymann
主题: MPLS-RT review of draft-raza-mpls-ldp-applicability-label-adv

You have been selected as an MPLS Review team reviewers for
Reviews should comment on whether the document is coherent, is it useful
(ie, is it likely to be actually useful in operational networks), and is
the document technically sound?  We are interested in knowing whether the 
document is ready to be considered for WG adoption (ie, it doesn’t have to
be perfect at this point, but should be a good start). 
Reviews should be sent to the document authors, WG co-chairs and secretary,
and CC’d to the MPLS WG email list. If necessary, comments may be sent 
privately to only the WG chairs. 
Are you able to review this draft by July 11, 2012 (this is giving you an 
extra week due to the July 4th holiday)? 
Thanks, Ross
(as MPLS WG chair)