[mpls-tp] AD review of draft-ietf-mpls-tp-uni-nni

Adrian Farrel <Adrian.Farrel@huawei.com> Mon, 06 December 2010 12:30 UTC

Return-Path: <Adrian.Farrel@huawei.com>
X-Original-To: mpls-tp@core3.amsl.com
Delivered-To: mpls-tp@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 08A3B3A6A71 for <mpls-tp@core3.amsl.com>; Mon, 6 Dec 2010 04:30:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -105.375
X-Spam-Level:
X-Spam-Status: No, score=-105.375 tagged_above=-999 required=5 tests=[AWL=1.224, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ez2R8gjnPpL4 for <mpls-tp@core3.amsl.com>; Mon, 6 Dec 2010 04:30:10 -0800 (PST)
Received: from usaga03-in.huawei.com (usaga03-in.huawei.com [206.16.17.220]) by core3.amsl.com (Postfix) with ESMTP id CB8B83A6A55 for <mpls-tp@ietf.org>; Mon, 6 Dec 2010 04:30:08 -0800 (PST)
Received: from huawei.com (usaga03-in [172.18.4.17]) by usaga03-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LD000455ASICL@usaga03-in.huawei.com> for mpls-tp@ietf.org; Mon, 06 Dec 2010 06:31:30 -0600 (CST)
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) by usaga03-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTPA id <0LD0003X4ASGZB@usaga03-in.huawei.com> for mpls-tp@ietf.org; Mon, 06 Dec 2010 06:31:30 -0600 (CST)
Date: Mon, 06 Dec 2010 12:31:32 +0000
From: Adrian Farrel <Adrian.Farrel@huawei.com>
To: draft-ietf-mpls-tp-uni-nni@tools.ietf.org
Message-id: <0e2c01cb9541$84ec90a0$8ec5b1e0$@huawei.com>
MIME-version: 1.0
X-Mailer: Microsoft Outlook 14.0
Content-type: text/plain; charset=us-ascii
Content-language: en-gb
Content-transfer-encoding: 7BIT
Thread-index: AcuVQMSKYEqsh4P+SGWTZf7NDsaqrw==
Cc: mpls-tp@ietf.org
Subject: [mpls-tp] AD review of draft-ietf-mpls-tp-uni-nni
X-BeenThere: mpls-tp@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: Adrian.Farrel@huawei.com
List-Id: MPLS-TP Mailing list <mpls-tp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/mpls-tp>, <mailto:mpls-tp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls-tp>
List-Post: <mailto:mpls-tp@ietf.org>
List-Help: <mailto:mpls-tp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls-tp>, <mailto:mpls-tp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Dec 2010 12:30:12 -0000

Hi,

I have performed an AD review of your draft.

Don't panic!

I review all drafts that I am responsible for before putting them forward
for IETF last call. The main objective is to catch nits and minor issues
that would show up during the last call or in IESG review. The intention is
to help polish your document and make sure it is clean and shiny so that
other reviewers will stick to the technical details.

My comments are pretty trivial, but there are sufficient of them in a 
relatively short document that I'd like to see a quick respin before I
issue the IETF last call. Hopefully this won't take you more than a few
minutes. As soon as I see a new revision posted, I'll set the ball in
motion.

Of course, all of my issues are up for discussion.

Thanks for the work,
Adrian

===

Abstract                                                      
s/[RFC5921]/(RFC 5921)/
---
Abstract
s/ Network-to-Network interface/ Network-to-Network Interface/
---
Abstract
Expand "MPLS-TP" on first use. (MPLS is OK as an acronym)
---
Abstract
s/IETF onsensus/IETF consensus/
---
Table of Contents

You can remove the ToC from this short I-D.

---
Section 1
Expand "MPLS-TP" on first use. (MPLS is OK as an acronym)
---
Section 1
s/Network-to-Network interface/Network-to-Network Interface/
---
Section 1.1
Expand "PE" and "CE" on first use.
---

Section 1.1

   This document provides updated illustrations of the MPLS-TP UNI and
   MPLS-TP NNI to show these additional details.  These illustrations
   are intended to obsolete the corresponding ones in [RFC5921].  This
   document also defines additional terminology referenced in the
   illustrations.  No other updates are proposed by this document.

Too tentative!

Try...

   This document provides updated illustrations of the MPLS-TP UNI and
   MPLS-TP NNI to show these additional details.  These illustrations
   obsolete figures 3 and 5 in [RFC5921].  This document also defines
   additional terminology referenced in the illustrations.  No other
   updates are made by this document.

---

Section 2

s/User-Network interface/User-to-Network Interface/

---

Section 2

s/MPLS UNI/MPLS-TP UNI/

---

Figure 1

Is it the intention that the left hand extreme of the UNI-C function 
should also delimit the CE? Or should you show the top and bottom bars
of the CE box extending further to the left?

---

Figure 1

Remove the footnote "TSI = Transport Service Instance" as you have
put this in Section 1.2.

---

Figure 2

Remove the footnote "TSI = Transport Service Instance" as you have
put this in Section 1.2.

---
Section 5
s/RFC5921/[RFC5921]/
---
Section 7
Remove unused reference RFC 2119