Re: [mpls] Comments on draft-aa-mpls-ldp-link-shut

Anush Mohan <anush.mohan@ericsson.com> Sun, 17 November 2019 07:24 UTC

Return-Path: <anush.mohan@ericsson.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C72971200A3; Sat, 16 Nov 2019 23:24:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ke-L-PqFXqrG; Sat, 16 Nov 2019 23:24:31 -0800 (PST)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0622.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::622]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B71F9120033; Sat, 16 Nov 2019 23:24:30 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIEeVPkbKYUWbXaJBRCoCXIa5Y5fP4oFSfjc72EDC9fgLf14EQ99MpA4f53NLjk9KlVeo7arS2/2Aj/OFpDSRQ8MH7hPPZzLh3wBw682X+svlMmbPlpMAhcCanSKaGVHkBBVhJivVNmO4yhqS19dR+sUpYgjWhWh/CU3Lu403GhtTRx0rcDLuULxDg8Hjp5/R/+ECSLOlMe+t6Ob+ZdL3llsQC+7f54jRCGEoangE2f2BAsF0Vm3+ZCUjA2lomZk5pOmRp+T4G6iedmKuhqnSH61SSbdttrvuc1ToA5mlSVqrkbP+zPfsR31jRhpRBt4kXiIGFsk/sslUCe46Bfuxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4O/MgaD5M3Zn9UbjdtPrSSczUCp2OuJ9vyPEUIhYbgk=; b=U1kfjb+HQuXgvfvWVI16IEmYIhoT7reMoJM3EDq0Rx+KFCR0s5i5oRx6Ll/XuQLDoS1YwAEw4L00ga4cYwCyOlY8GTH6O79O1nmI/Lgu9k3+nXELvc3esaZlF729/fWcXHlC+q8raZJqv52Yb84GWvgdGXukbsW+saOQjjn6kWkIQq3yM7d3vS6CdaRndp03h7Wlg/TDnSLckmdf7P6WWcXOyh99ZHRKNnEq9stUhllesjeR1YmuKel7+C8BCP4bN7JXHF54IjfO/i8TZSZSAjvbDGbcL6o289HbkYTB6QhdiRZqxHSoY71tK6Te8gZFhwoLtxJkUjpYM4YVA8X8NQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4O/MgaD5M3Zn9UbjdtPrSSczUCp2OuJ9vyPEUIhYbgk=; b=YuoOreh1kD3e2eWpRS3kiw29jvWhMONER6y6zvHTM3203UAlt3jvwf/cla/gIeJ6VoGei4gIlBl49V5CAD8ZhMWXDKv0iNH/PGjyRP/qdBJDvPEp9KHRIMjDf7DwLLnjMa1kKtLO+2usRUHfkW4TDIbc9XfvDxvcALi5ngJhK9o=
Received: from VI1PR0701MB2672.eurprd07.prod.outlook.com (10.173.85.135) by VI1PR0701MB3056.eurprd07.prod.outlook.com (10.173.72.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.10; Sun, 17 Nov 2019 07:24:27 +0000
Received: from VI1PR0701MB2672.eurprd07.prod.outlook.com ([fe80::b102:1cb6:f55f:122]) by VI1PR0701MB2672.eurprd07.prod.outlook.com ([fe80::b102:1cb6:f55f:122%9]) with mapi id 15.20.2474.012; Sun, 17 Nov 2019 07:24:27 +0000
From: Anush Mohan <anush.mohan@ericsson.com>
To: Anush Mohan <anush.mohan@ericsson.com>, Tarek Saad <tsaad.net@gmail.com>, "draft-aa-mpls-ldp-link-shut@ietf.org" <draft-aa-mpls-ldp-link-shut@ietf.org>
CC: Vishnu Pavan Beeram <vbeeram@juniper.net>, mpls <mpls@ietf.org>
Thread-Topic: Comments on draft-aa-mpls-ldp-link-shut
Thread-Index: AQHVnRDXLAapMOsZ4Ue+SbbHTFeRRKeO57SAgAAImZCAAAU2AA==
Date: Sun, 17 Nov 2019 07:24:27 +0000
Message-ID: <VI1PR0701MB267217F63A80312A946EE95F83720@VI1PR0701MB2672.eurprd07.prod.outlook.com>
References: <DM6PR19MB36896FDCD631789277FE592AFC720@DM6PR19MB3689.namprd19.prod.outlook.com> <DM6PR19MB368974E13C15258185FA5DF6FC720@DM6PR19MB3689.namprd19.prod.outlook.com> <VI1PR0701MB2672F6415B820A035E126AEF83720@VI1PR0701MB2672.eurprd07.prod.outlook.com>
In-Reply-To: <VI1PR0701MB2672F6415B820A035E126AEF83720@VI1PR0701MB2672.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=anush.mohan@ericsson.com;
x-originating-ip: [2401:4900:2181:d5aa:7499:4acc:dd2b:764d]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cd2f16e9-969d-406d-c08f-08d76b2f2de5
x-ms-traffictypediagnostic: VI1PR0701MB3056:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR0701MB3056E7F08F687AAAFD613A1F83720@VI1PR0701MB3056.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 02243C58C6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(199004)(189003)(4326008)(71200400001)(44832011)(186003)(2501003)(486006)(2940100002)(6246003)(14444005)(256004)(71190400001)(46003)(55016002)(229853002)(25786009)(86362001)(5660300002)(9686003)(6436002)(476003)(446003)(11346002)(53546011)(6506007)(99286004)(7736002)(14454004)(64756008)(66446008)(305945005)(66946007)(66476007)(102836004)(66556008)(76176011)(6116002)(81166006)(81156014)(478600001)(7696005)(8936002)(76116006)(33656002)(52536014)(316002)(2906002)(8676002)(54906003)(110136005)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0701MB3056; H:VI1PR0701MB2672.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: eMkOleihK1dUEdzlIz4Vlz07Zt1m+e+Ib7vt/id3+dNtWc8W3QKWbvXHU293R4a158QKXv4Pa5DfpVmPNYrFkZRHcDbgeYIOzWAv/t6S/i92wm+7r7hnXYhjeg7Mr94BUeKIb2xn7Y7YcIOyXst9y8IrRLxVE5bX8CETr5gL73OBo6hEZoW0lxBGULKfkspkLT2VVwUCpUjKkF2Q5L8mY993SdXE5yTpVjdyC/hEQIsaD37HhlQ2R9R/Lf+FE06WFWIrWweW49hZOj3awfki2rHvlkr62t5CU3q7baP1ZqKH4nT4KX4jYsAzd+MyFawkPHPtXUG7t10PyPcpf9KdF6i7Ocln35P4l922kWUb97K31DrhnvJ4UYoUdAXEjqcEIzD/ZHI0CoVq6uu8VhD8oSWwXQGfuGn3hZw4iGpEgrTflXVQ92GVgvJAytiEnoNX
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd2f16e9-969d-406d-c08f-08d76b2f2de5
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2019 07:24:27.3201 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tClSpfxs1Gnyrv8wbqndhW/x+AD4lRoRrAF0rNcWhSZoTpy0ryLij+/Rk9mOKj0bWK4dnb6OvqmZcbhlB+ijkhXifLY5/yPQPN+tXe/j1Lk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB3056
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/1umisEVTX_hg7llllWB8CiDwi10>
Subject: Re: [mpls] Comments on draft-aa-mpls-ldp-link-shut
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 07:24:33 -0000

Hi Tarek,

   Please find my replies inline.

Regards
Anush

P.S:  Looks like my earlier reply got truncated.

From: Tarek Saad <tsaad.net@gmail.com>
Sent: Sunday, November 17, 2019 12:03 PM
To: draft-aa-mpls-ldp-link-shut@ietf.org
Cc: Vishnu Pavan Beeram <vbeeram@juniper.net>; mpls <mpls@ietf.org>
Subject: Re: Comments on draft-aa-mpls-ldp-link-shut

+ mpls@ietf.org<mailto:mpls@ietf.org>

From: Tarek Saad <tsaad.net@gmail.com<mailto:tsaad.net@gmail.com>>
Date: Sunday, November 17, 2019 at 2:32 PM
To: "draft-aa-mpls-ldp-link-shut@ietf.org<mailto:draft-aa-mpls-ldp-link-shut@ietf.org>" <draft-aa-mpls-ldp-link-shut@ietf.org<mailto:draft-aa-mpls-ldp-link-shut@ietf.org>>
Cc: Vishnu Pavan Beeram <vbeeram@juniper.net<mailto:vbeeram@juniper.net>>
Subject: Comments on draft-aa-mpls-ldp-link-shut

Hi co-authors,

Having gone through this draft, I have the following comments:

1.      Draft does not mention LDP session protection feature -- aka targeted LDP session to peer that handles the case of keeping LDP session UP in case of Hello Adj or link adjacency down. I see several vendors (at least Juniper/Cisco) who have support for this

                     [Anush]: Agree, we need to mention this. It helps for the issue mentioned in the draft.


2.      Section 2.5.5 or rfc5036 describes a hold timer that only after expiring will trigger the Hello adjacency deletion - and only after the last hello adjacency going down will trigger the LDP session to peer to go down.. i.e. the RFC 5036 does not dictate that LDP session to peer to go down immediately after link down as stated in draft-aa-mpls-ldp-link-shut section 3

                   [Anush]:   This particular section talks about procedures for maintaining LDP hello adjacencies, but doesn't explicitly 
                       prevent any implementation from immediately tearing down LDP session, when the only LDP enabled link to a
                       peer goes down. Other places in the RFC leave it open to the implementation, to decide  when to terminate an LDP 
                       session.