[mpls] MIB Dr. review of draft-ietf-mpls-mldp-mib-01

Joan Cucchiara <jcucchiara.ietf@gmail.com> Sat, 11 February 2017 02:20 UTC

Return-Path: <jcucchiara.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7512129529; Fri, 10 Feb 2017 18:20:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GvBHUvaqe9ck; Fri, 10 Feb 2017 18:20:29 -0800 (PST)
Received: from mail-ot0-x232.google.com (mail-ot0-x232.google.com [IPv6:2607:f8b0:4003:c0f::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A0C9128DF6; Fri, 10 Feb 2017 18:20:29 -0800 (PST)
Received: by mail-ot0-x232.google.com with SMTP id 65so41420117otq.2; Fri, 10 Feb 2017 18:20:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=hRNIa6XNtozn8PM6+Xp9a+XjeT811/grI3f+QMf5lpw=; b=em8LiCz4/VfslLucRTDZdQXLURXN7qQXUK12BO/qhs99mGZUIFVbd61iIlarIQEexO W0kJETY+jiKIwTcz8XBpuMfTJoCXRUoRAsB6UMWq5/vE44b0HWRFq/d6n1GyCNmzSBr8 Ec06DwKAC6TU/q4R14WjMxWEs0/JgWF2ndtTZkMNHx+PRtvgPL8poyjtoeVa2aS4m7q3 tFWmh/TuDSUF6Zg3XCZbbIcklJkMmeoa6RWc4jlLdGGvoFFSMqENavlQ9MFYzH0ee8mI VYy4T3Omvn3Gx3NC+VHKpUSNiFBHU3Sqw8mLU30GwKRAM+EC07CXE2jHD0d7haGtoJke zAjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hRNIa6XNtozn8PM6+Xp9a+XjeT811/grI3f+QMf5lpw=; b=S4GWNNMt4Hnum1/Wg4ISf/3tDLQKJHetMFEBlp6gY188bRARu1iZDFd3s3IlONJWSp ymVaCEdtYNJeBm71hOsk8/VQ1W0OxsLYW4gpwPd3MMlYOEaQ/4zxzsq1wvNxSkdzd9CS x5ZSYZrKokhyFxeQDG+2+ycpdU/06lnZre4gcPET7vbKr3E8UOFKj59s4Gx+sHqhn3qE SbswBqvCnUZTU+n2otS3A+f5sOhb/HfZtTHguYJq9s0bykW7cOJ5RL3Do4OmiYOcROf+ u3uI/F9FCY4VC+zXPmYNhGIApfzIamqFKdBgGcCwAgnKTA1S7C7ulkLzFSi+pBbyw5k/ lF2Q==
X-Gm-Message-State: AMke39nbaB8yRoa8WTWXHDJb8n5KoT5k5VUaEZbZPDxe9PUhyC/0tgu4cs9xW5ujNLmhu3dyNOzQYi2X66FRug==
X-Received: by 10.157.52.33 with SMTP id v30mr6332284otb.156.1486779628817; Fri, 10 Feb 2017 18:20:28 -0800 (PST)
MIME-Version: 1.0
Received: by 10.74.28.16 with HTTP; Fri, 10 Feb 2017 18:20:28 -0800 (PST)
From: Joan Cucchiara <jcucchiara.ietf@gmail.com>
Date: Fri, 10 Feb 2017 21:20:28 -0500
Message-ID: <CANSkkOk1bztCQMiDjfDLO7_+x0pxBeKiBEZMZVEru0CeEkmztw@mail.gmail.com>
To: Loa Andersson <loa@pi.nu>, mpls@ietf.org, mib-doctors@ietf.org, draft-ietf-mpls-mldp-mib@ietf.org
Content-Type: multipart/alternative; boundary=001a114147c8a29544054837dbe0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/29Q9SWZkbOtmGYQxruJfsT-B7t0>
Subject: [mpls] MIB Dr. review of draft-ietf-mpls-mldp-mib-01
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Feb 2017 02:20:32 -0000

Hello Authors,

This draft has come a long way since the previous version.  Thanks for that.

Please make sure the MIB compiles with smilint prior to MIB review as it is
difficult to review a
MIB Module that doesn't compile.

Also, please add compliance statements and conformance groups.

Comments below.
Thanks,
-Joan


output from smilint compiler:
------------------------------
While processing your request the following errors and/or warnings have
been found:

mibs/MPLS-MLDP-STD-MIB:76: [5] {date-year-2digits} warning: date
specification `2016092600Z' contains a two-digit year representing `1920'
mibs/MPLS-MLDP-STD-MIB:76: [2] {date-month} date specification
`2016092600Z' contains an illegal month
mibs/MPLS-MLDP-STD-MIB:76: [2] {date-hour} date specification `2016092600Z'
contains an illegal hour
mibs/MPLS-MLDP-STD-MIB:76: [4] {date-in-past} warning: date specification
`2016092600Z' predates the SMI standard

Then after that was fixed, more errors:

mibs/MPLS-MLDP-STD-MIB:268: [2] {identifier-redefined} redefinition of
identifier `mplsLdpPeerCapabilityEntry'
mibs/MPLS-MLDP-STD-MIB:254: [6] {previous-definition} info: previous
definition of `mplsLdpPeerCapabilityEntry'
mibs/MPLS-MLDP-STD-MIB:268: [1] {internal-other} syntax error, unexpected
COLON_COLON_EQUAL, expecting OBJECT
mibs/MPLS-MLDP-STD-MIB:271: [5] {internal-flushing} warning: flushing
recent incorrect declaration, see previous error(s)
mibs/MPLS-MLDP-STD-MIB:279: [4] {hyphen-in-label} warning: named bit
`upstream-label-assignment' must not include a hyphen in SMIv2
mibs/MPLS-MLDP-STD-MIB:283: [4] {hyphen-in-label} warning: named bit
`prot-lsr' must not include a hyphen in SMIv2
mibs/MPLS-MLDP-STD-MIB:286: [4] {hyphen-in-label} warning: named bit
`node-prot' must not include a hyphen in SMIv2
mibs/MPLS-MLDP-STD-MIB:386: [1] {internal-other} syntax error, unexpected
UPPERCASE_IDENTIFIER, expecting COLON_COLON_EQUAL
mibs/MPLS-MLDP-STD-MIB:417: [5] {internal-flushing} warning: flushing
recent incorrect declaration, see previous error(s)
mibs/MPLS-MLDP-STD-MIB:482: [2] {description-missing} description missing
in object definition
mibs/MPLS-MLDP-STD-MIB:482: [1] {internal-other} syntax error, unexpected
MAX_ACCESS, expecting COLON_COLON_EQUAL
mibs/MPLS-MLDP-STD-MIB:493: [5] {internal-flushing} warning: flushing
recent incorrect declaration, see previous error(s)
mibs/MPLS-MLDP-STD-MIB:1060: [1] {internal-other} syntax error, unexpected
'}', expecting UPPERCASE_IDENTIFIER or LOWERCASE_IDENTIFIER or NUMBER
mibs/MPLS-MLDP-STD-MIB:1060: [5] {internal-flushing} warning: flushing
recent incorrect declaration, see previous error(s)
mibs/MPLS-MLDP-STD-MIB:1061: [1] {internal-other} syntax error, unexpected
STATUS



General Comments (please check throughout document)
---------------------------------------------------------------------------------
*) Need to get this to compile using smilint.


*) When other documents (RFCs or drafts) are mentioned, there should be a
reference notation given.  Please fix this throughout the draft.

*) Naming Conventions:  Please refer to RFC4181 (MIB guidelines).
Basically, the naming conventions used in this MIB Module do not follow
the recommended naming conventions (Appendix C).

Prefix should be used throughout for all objects/tables/entries etc.
So "mplsMldp" needs to be used consistently.


*) Think there are more AUGMENTS relationships between RFC3815 Tables and
Tables in this MIB Module
but they are not defined as AUGMENTS within the MIB Module but are
described as such within the
document sections.   Please make sure that the relationships between these
tables are clarified.
e.g.  mplsMldpPeerCapabilityTable and mplsLdpPeerTable


Section 2.

Remove the first paragraph.  Think this is understood.

   [[CREF1: The title and text for this section has been copied from the
   official boilerplate, and should not be modified unless the official
   boilerplate text from the OPS Area web site has changed.  See RFC4818
   section 3.1 for a discussion of the boilerplate section.]]


Section 4. Overview

*) Make sure the RFCs/drafts listed are referenced as being in the
References Section (probably the Normative References section).  Some of
them are, some of the are not.  Be consistent.

*) Not very helpful to list a bunch of documents and not specify which
features (i.e. specify the sections/sub-sections) appear in which
documents.
We already can see the list of documents in the References section so
unless features/sections/subsections from these docs are specified per
document, then don't see this as adding information.

*) Also, some out of date listings, so need to update these.
ietf-rtgwg-mofrr is an RFC as of 8/2015
ietf-mpls-mldp-node-protection is an RFC as of 1/2016

*) typo:  ...stats per per Interface


Section 6.2

   mplsMldpSessionStatsTable : This table contains the number of mLDP
   FECs received and advertised to particular LDP session.

s/to particular LDP session/ to a particular LDP session/


Section 7.

   There are ten scalars, listed below are defined for this MIB module.

*) above sentence is awkward.  Maybe something like:

The following scalars are defined in this MIB Module:


Section 8.1

*) s/from LDP peer/from an LDP peer/


Section 8.5

typo in section's title
s/Upstreaam/Upstream/


Section 8.6

s/gives the information/gives information/
s/about number/about the number of/  (2 occurrences)

s/received on particualr/received on a particular/

Please note:  will review the other sections once the MIB compiles and
compliance statements are added.


References Section:
*) Some references (drafts) out of date and RFCs are out of order
References.  Please update.

Other
*) Please remove Appendix A and Appendix B (and regenerate the Table of
Contents.)