[mpls] Re: Comments on draft-mirsky-mpls-stamp-07

"zhangli (CE)" <zhangli344@huawei.com> Thu, 22 August 2024 02:11 UTC

Return-Path: <zhangli344@huawei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 64024C137362 for <mpls@ietfa.amsl.com>; Wed, 21 Aug 2024 19:11:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.207
X-Spam-Level:
X-Spam-Status: No, score=-4.207 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id odwOBBjk9NBY for <mpls@ietfa.amsl.com>; Wed, 21 Aug 2024 19:11:43 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1584BC14F5E3 for <mpls@ietf.org>; Wed, 21 Aug 2024 19:11:43 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Wq67W24nBz6K5ql; Thu, 22 Aug 2024 10:08:39 +0800 (CST)
Received: from lhrpeml100001.china.huawei.com (unknown [7.191.160.183]) by mail.maildlp.com (Postfix) with ESMTPS id ADD5A140B73; Thu, 22 Aug 2024 10:11:39 +0800 (CST)
Received: from dggpemf200009.china.huawei.com (7.185.36.246) by lhrpeml100001.china.huawei.com (7.191.160.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 03:11:38 +0100
Received: from dggpemm100019.china.huawei.com (7.185.36.251) by dggpemf200009.china.huawei.com (7.185.36.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Aug 2024 10:11:36 +0800
Received: from dggpemm100019.china.huawei.com ([7.185.36.251]) by dggpemm100019.china.huawei.com ([7.185.36.251]) with mapi id 15.01.2507.039; Thu, 22 Aug 2024 10:11:36 +0800
From: "zhangli (CE)" <zhangli344@huawei.com>
To: Greg Mirsky <gregimirsky@gmail.com>
Thread-Topic: Comments on draft-mirsky-mpls-stamp-07
Thread-Index: Adr0OJe5+5HczWm7QvS07yam0Dw04A==
Date: Thu, 22 Aug 2024 02:11:36 +0000
Message-ID: <aa60c2c94c2f41b084e42696114bdcca@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.153.181.253]
Content-Type: multipart/alternative; boundary="_000_aa60c2c94c2f41b084e42696114bdccahuaweicom_"
MIME-Version: 1.0
Message-ID-Hash: 6BTL6BTFOQHXHS2VFNZM6PIZDUXRDQO4
X-Message-ID-Hash: 6BTL6BTFOQHXHS2VFNZM6PIZDUXRDQO4
X-MailFrom: zhangli344@huawei.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-mpls.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "mpls@ietf.org" <mpls@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [mpls] Re: Comments on draft-mirsky-mpls-stamp-07
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/7yd_t4Pm4pmchfgInw_k-jlff3M>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Owner: <mailto:mpls-owner@ietf.org>
List-Post: <mailto:mpls@ietf.org>
List-Subscribe: <mailto:mpls-join@ietf.org>
List-Unsubscribe: <mailto:mpls-leave@ietf.org>

Hi Greg,

Thanks for your quick response and update, please find my response below tagged with Li>>.

Best regards
Li

发件人: Greg Mirsky <gregimirsky@gmail.com>
发送时间: 2024年8月22日 6:01
收件人: zhangli (CE) <zhangli344@huawei.com>
抄送: mpls@ietf.org
主题: Re: Comments on draft-mirsky-mpls-stamp-07

Hi Li,
thank you for your interest in the draft and thoughtful comments; much appreciated. Please find my notes below tagged GIM>>. Attached are the working version and diff that highlights updates.

Regards,
Greg

On Wed, Aug 21, 2024 at 1:54 AM zhangli (CE) <zhangli344@huawei.com<mailto:zhangli344@huawei.com>> wrote:
Hi Greg,

I am interested in this draft and I just read it, here are my comments.


1.    In the second paragraph of introduction, it writes the “This document defines the Reflected Packet Path TLV”. However, this document defines “STAMP Session Identifier TLV” in section 3.1, so I suppose the “Reflected Packet Path TLV” should be replaced with “STAMP Session Identifier TLV”, is it right?
GIM>> Great catch, thank you! You are absolutely correct, it must be changed to STAMP Session Identifier TLV. Please check in the working version.

Li >> Good work, I checked the document in the attachment, there is another “STAMP Session Identifier TLV” also need to be replaced, it is in the seventh paragraph below Figure1 “If the STAMP Session-Reflector cannot find the path specified in the Reflected Packet Path TLV…”



2.    In section 3.1, the draft writes that “Reflected Packet Path field contains none, one or more sub-TLVs.”, if I understand correctly, each sub-TLV describes a route path(such as Non-FEC Path TLV). If there is only one reflected path specified, the Session-Reflector will reflect the test packet along the specific path. If there are multiple reflected path, how should the Session-Reflector do? Reflect the reflected-test packet on all the paths?
GIM>> A very good question, thank you. I think that in some environments, e.g., SR-MPLS, a sub-TLV that defined for TLV Types 1, 16, and 21 represents a segment, not the entire path. However, as you've noted, Non-FEC Path TLV can be used as alternative to using multiple sub-TLVs.

Li>> Great, I think I am clear on this point now. The “Reflected Packet Path field” is used to describe one reflected path, if the sub-TLV represents a segment, then this “field” could contains one or more sub-TLVs, if the sub-TLV represents a path(Non-FEC Path TLV), then this “field” Should just contain one sub-TLV. Do I understand correctly?

Best regards

Li


---------- Forwarded message ---------

From: <internet-drafts@ietf.org><mailto:&lt;internet-drafts@ietf.org&gt;>

Date: Mon, Mar 25, 2024 at 5:52 PM

Subject: New Version Notification for draft-mirsky-mpls-stamp-07.txt

To: Greg Mirsky <gregimirsky@gmail.com><mailto:&lt;gregimirsky@gmail.com&gt;>





A new version of Internet-Draft draft-mirsky-mpls-stamp-07.txt has been

successfully submitted by Greg Mirsky and posted to the

IETF repository.



Name:     draft-mirsky-mpls-stamp

Revision: 07

Title:    Simple Two-way Active Measurement Protocol (STAMP) for MPLS Label

Switched Paths (LSPs)

Date:     2024-03-25

Group:    Individual Submission

Pages:    9

URL:      https://www.ietf.org/archive/id/draft-mirsky-mpls-stamp-07.txt

Status:   https://datatracker.ietf.org/doc/draft-mirsky-mpls-stamp/

HTML:     https://www.ietf.org/archive/id/draft-mirsky-mpls-stamp-07.html

HTMLized: https://datatracker.ietf.org/doc/html/draft-mirsky-mpls-stamp

Diff:

https://author-tools.ietf.org/iddiff?url2=draft-mirsky-mpls-stamp-07



Abstract:



   Simple Two-way Active Measurement Protocol (STAMP), defined in RFC

   8762 and RFC 8972, is expected to be able to monitor the performance

   of paths between systems that use a wide variety of encapsulations.

   This document defines encapsulation and bootstrapping of a STAMP test

   session over an MPLS Label Switched Path.







The IETF Secretariat