Re: [mpls] RtgDir Review: draft-ietf-mpls-ri-rsvp-frr-05

<julien.meuric@orange.com> Thu, 20 June 2019 14:07 UTC

Return-Path: <julien.meuric@orange.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0D9CE12014B; Thu, 20 Jun 2019 07:07:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.291
X-Spam-Level:
X-Spam-Status: No, score=-0.291 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FORGED_MUA_MOZILLA=2.309, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gjLiN289JpKO; Thu, 20 Jun 2019 07:07:47 -0700 (PDT)
Received: from orange.com (mta239.mail.business.static.orange.com [80.12.66.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBFEE120089; Thu, 20 Jun 2019 07:07:46 -0700 (PDT)
Received: from opfedar03.francetelecom.fr (unknown [xx.xx.xx.5]) by opfedar20.francetelecom.fr (ESMTP service) with ESMTP id 45V3YY03Q0z8wFc; Thu, 20 Jun 2019 16:07:45 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.98]) by opfedar03.francetelecom.fr (ESMTP service) with ESMTP id 45V3YX5XrzzCqkq; Thu, 20 Jun 2019 16:07:44 +0200 (CEST)
Received: from [10.193.71.81] (10.114.13.245) by OPEXCAUBM7F.corporate.adroot.infra.ftgroup (10.114.13.98) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 16:07:44 +0200
To: Chandrasekar Ramachandran <csekar@juniper.net>
CC: "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-mpls-ri-rsvp-frr.all@ietf.org" <draft-ietf-mpls-ri-rsvp-frr.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
References: <25527_1555000351_5CAF6C1F_25527_187_1_c344649c-bea5-5d0e-3b76-2bd28be6d226@orange.com> <BYAPR05MB547700FDE3B96DEF070438E6D9E40@BYAPR05MB5477.namprd05.prod.outlook.com>
From: <julien.meuric@orange.com>
Organization: Orange
Message-ID: <2098_1561039664_5D0B9330_2098_160_1_84b25e23-a628-854e-fb5d-f9ffdcdb170e@orange.com>
Date: Thu, 20 Jun 2019 16:07:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <BYAPR05MB547700FDE3B96DEF070438E6D9E40@BYAPR05MB5477.namprd05.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [10.114.13.245]
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/8DCETKzBZzjIJicNtzZkrkNuC_o>
Subject: Re: [mpls] RtgDir Review: draft-ietf-mpls-ri-rsvp-frr-05
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 14:07:54 -0000

Hi Chandra,

Thanks for the update. I've just taken a look at the diff: it looks
fine, with an improved MUST/SHOULD ratio. I haven't checked all nits,
but it seems you missed a key one in section 4.6.2.2., leaving a Path
message when talking about upstream (see below).

Cheers,

Julien


On 20/06/2019 15:42, Chandrasekar Ramachandran wrote:
> [...]
>
>> -----Original Message-----
>> From: julien.meuric@orange.com <julien.meuric@orange.com>;
>> Sent: Thursday, April 11, 2019 10:03 PM
>>
>> - s/in TIME_VALUES object carried in PATH to default value/in the
>> TIME_VALUES object carried in the *Resv* message to a default value/


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.