Re: [mpls] I-D Action: draft-ietf-mpls-mldp-yang-04.txt

tom petch <ietfc@btconnect.com> Tue, 31 July 2018 10:28 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80423130E95 for <mpls@ietfa.amsl.com>; Tue, 31 Jul 2018 03:28:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.187
X-Spam-Level: ***
X-Spam-Status: No, score=3.187 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RATWARE_OUTLOOK_NONAME=2.95, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NqzcpDAAdHC3 for <mpls@ietfa.amsl.com>; Tue, 31 Jul 2018 03:28:14 -0700 (PDT)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on071c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::71c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49DE9130E8F for <mpls@ietf.org>; Tue, 31 Jul 2018 03:28:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7Lc4VLoaZAPi/Mp/5HnWCseAPSEnmyQuzvdjKAOnHI=; b=FtqFSYK+NNsuNo0JnYVtjYzpVrCyL1zdbfVEblRqKd0x96PKeewKVX2fTpTjisHAEOTc62uvpz4LngJ8YaDkwdcZVFE9w4u0q3+lYu3xPZ/ZJgP1PIiUCfiNiNjK9Oe4MdUyL8tiNAUvHEGY+Nyz8VmIvJRb3qiIkaRZxvRcgyM=
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com (10.161.107.154) by VI1PR07MB0911.eurprd07.prod.outlook.com (10.161.109.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.14; Tue, 31 Jul 2018 10:28:11 +0000
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::6d94:2d16:29ed:70d9]) by VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::6d94:2d16:29ed:70d9%9]) with mapi id 15.20.1017.010; Tue, 31 Jul 2018 10:28:11 +0000
From: tom petch <ietfc@btconnect.com>
To: mpls <mpls@ietf.org>
CC: mpls <mpls@ietf.org>
Thread-Topic: I-D Action: draft-ietf-mpls-mldp-yang-04.txt
Thread-Index: AQHUKLku3Q9J5z7PHkmBFVKrL1FOxg==
Date: Tue, 31 Jul 2018 10:28:11 +0000
Message-ID: <03a101d428b8$c331c7a0$4001a8c0@gateway.2wire.net>
References: <153177665670.21806.8770135060291245851@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: AM6PR0502CA0012.eurprd05.prod.outlook.com (2603:10a6:209:1::25) To VI1PR07MB0831.eurprd07.prod.outlook.com (2a01:111:e400:508e::26)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [86.165.129.102]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB0911; 6:vdWreDnP6Qk0T8GCGrCZ/zH6KXT/iqmRuvuUbZPtKCn2bsK9K4Np+p2LA8W/gBSLK7WHerjCb4j1Sw0LF2gKEKE3Sib/RWehSJtw3thiOxurSE514oNhsJV7AALP4wbY8gFrJNyB5R0/bZ6W8mui8CFMTzLQRBPsb3oYxGs+0FPs5JWHlVaw9o5LJE3SQfO9xWzb49F5/4sUHF4QXG8APViahGLwko5tMUQWgdmefGeMVEPgY1iB743bbP1Vjdu/9691HoNysqDpynIfq/uPpn7IlzwlOOCGO8FrvRNV599u12A+WDAaSWXwT+mtcfjzVm4DKGhcWXSEm3l5mXMxZ9ELgJuYImID9ffqhnClLaA7wE508YZ0kOF/rlnXWSdvmiWyabDswRyrms4j37ndDBFVnoICGiFQ4lD5t0u5rnHQijbdYQe1kBSqg5FPfTjkrMinSO5dvZIjPgc7+Nvqhg==; 5:i+AWLo4TUpYWLYBFLO6SyHuAXXUWYcf0Cn4AOzYPt7adzCqUal92NWbDPpdP+PmRO36kBQSqAfxp2hwhn8q/OmJsiiS4JOiTTONJxP7S5Y95+WFwbmKcgLVTILk2lpPfimwRcYFXys9+XcCx3OonTNvbQDS9SuCeTHn2XQaLZUU=; 7:tjaUm6JVoHjax7Y9uT4sPBXVvY3dPUdpXSckcSMoh/vFt3zgq7IYpaLGgCWcaALvdQPKeNYTiY1TDiBGNgcyhUpZXlKa4NAN6gyDoEoH56x1ZmzJgSm8hXABh/6ln9JYIJd7G2j7IeHTX19lmdNZUU/WBm41EeZPLIwxBiBxaYyPA0h0Fn7FlncUeFbhdTQ8xCP34ngWHtESMKfkaxl7TAsxNPs1mIk+k1EekPkXOaj/Y9b2fAKcslbsmOG8qpbH
x-ms-office365-filtering-correlation-id: 762eba46-7042-44e2-8bee-08d5f6d05091
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7193020); SRVR:VI1PR07MB0911;
x-ms-traffictypediagnostic: VI1PR07MB0911:
x-microsoft-antispam-prvs: <VI1PR07MB0911F43257586A46AC6B0286A02E0@VI1PR07MB0911.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(120809045254105)(192374486261705)(788757137089);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR07MB0911; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB0911;
x-forefront-prvs: 0750463DC9
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(346002)(376002)(396003)(366004)(39860400002)(13464003)(199004)(189003)(86362001)(8936002)(6486002)(5660300001)(44736005)(6916009)(53936002)(14496001)(305945005)(1556002)(66066001)(81166006)(6436002)(3846002)(8676002)(81156014)(229853002)(14454004)(478600001)(6116002)(14444005)(966005)(256004)(68736007)(6246003)(4326008)(102836004)(2900100001)(6506007)(386003)(2906002)(25786009)(486006)(86152003)(33896004)(6512007)(84392002)(5250100002)(6306002)(9686003)(476003)(106356001)(316002)(446003)(7736002)(97736004)(186003)(99286004)(52116002)(105586002)(76176011)(26005); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB0911; H:VI1PR07MB0831.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: jypyk7xrGUpXND0dl7BueK8WU3iIg7B5sa0z7yKoflxm/4j4OaDtdXFljF0F2Hq6j+ej4+gwIlexywg75fHi0CT+qWm6v82MW2US839NCx8FgynARBPnc35AZ+05Wg9IUQVQ7yBUxqxUnxZ4OsX2hcMShsdoF4WOe9VdKbVR3WeI7qd8+o47glLFYlZ65WHz/d/P4EmGl/vFoNL52jBqsUtqkRAGRPy1eeOvTAngK/MYoKDprG0JcvD+rv12vT92TnAIrFwAnNQvKVLRHwwmabBtPrf3cnBdgJOegl7KlR7hmoPUEf3CvVxHl6qPHkT2tBbIbFJ/P0cmEHCdlDWnw/dFkARWpbocKlGWhO2EMc8=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <CED3C95CF23D604CACC0F895B24F0775@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 762eba46-7042-44e2-8bee-08d5f6d05091
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2018 10:28:11.3713 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB0911
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/8VIdtl4Bt0N7w2azpCi28x5lIjE>
Subject: Re: [mpls] I-D Action: draft-ietf-mpls-mldp-yang-04.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 10:28:17 -0000

There is quite a lot wrong with this I-D in a similar vein to the issues
I just flagged for WGLC for draft-ietf-mpls-ldp-yang, namely


- Boiler plate rfc2119 lacks reference to RFC8174 but I see no must or
should in any case so maybe this is not needed
- NMDA is mentioned in the Introduction but it is usually called out in
the Abstract as well
- s.8 reads as if this I-D has open issues; is that intended, or do you
have future RFC in mind? If the latter, I suggest rewording it to say
the issues that are out of scope for this memo.
- no Note to RFC Editor asking them to replace XXXX with the number
assigned to this RFC
- no Note to RFC Editor asking them to replace the four dates in the
YANG modules with the date of publication
- no Copyright in the YANG modules
- WG Chairs listed in the modules which rfc6087bis says is not needed
- no YANG Version statement in the YANG modules
- no mention of the current YANG 1.1 RFC
- no reference statements for the import modules and their RFC are
missing from the Normative References of the I-D
- RFC4364 is listed as as reference in the YANG module but does not
appear in the I-D Normative References
- no Informative Reference to the Tree Diagrams RFC8340
- Security Considerations do not conform to rfc6087bis and lack the
Normative References that that calls for
- IANA Considerations fails to reference RFC7895 and RFC7950
- the representation of the IANA Considerations as boxes is unusual and,
for me, harder to understand than the usual list of lines

Uh huh; it is as if the rtgarea has a template for YANG modules with
things like this  wrong in it so each successive YANG Module I-D
reproduces much the same issues:-)

Tom Petch

----- Original Message -----
From: <internet-drafts@ietf.org>
To: <i-d-announce@ietf.org>
Cc: <mpls@ietf.org>
Sent: Monday, July 16, 2018 10:30 PM

> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Multiprotocol Label Switching WG of
the IETF.
>
>         Title           : YANG Data Model for MPLS mLDP
>         Authors         : Kamran Raza
>                           Sowmya Krishnaswamy
>                           Xufeng Liu
>                           Santosh Esale
>                           Loa Andersson
>                           Jeff Tantsura
> Filename        : draft-ietf-mpls-mldp-yang-04.txt
> Pages           : 58
> Date            : 2018-07-16
>
> Abstract:
>    This document describes a YANG data model for Multi-Protocol Label
>    Switching (MPLS) Multipoint Label Distribution Protocol (mLDP).
The
>    mLDP data model augments the LDP data model.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-mpls-mldp-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-mpls-mldp-yang-04
> https://datatracker.ietf.org/doc/html/draft-ietf-mpls-mldp-yang-04
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-mldp-yang-04
>
>
> Please note that it may take a couple of minutes from the time of
submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>