Re: [mpls] New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt

Yingzhen Qu <yingzhen.ietf@gmail.com> Mon, 02 August 2021 22:44 UTC

Return-Path: <yingzhen.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3DD23A1FD0; Mon, 2 Aug 2021 15:44:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x_9OILUeCF2l; Mon, 2 Aug 2021 15:44:53 -0700 (PDT)
Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4EDFB3A1FC8; Mon, 2 Aug 2021 15:44:53 -0700 (PDT)
Received: by mail-pj1-x102d.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso2101137pjf.4; Mon, 02 Aug 2021 15:44:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tHvl53aIYk34xWicj6ITjKQo+f2fhPzIZrY19c3okYQ=; b=WjrWTvr+UixoVLAYCFKze+Pr/W1qrpwXsT620GCcCDPkYOlJMeC01G06SQN+LOuzp5 iL3hr1GMvsC0wrF0qtXnZ1fgEnpn/S16joNZbPCdWyXG3aUbtbBOkCJrnR7xB8Xi9Mp4 Ck4mJFn61OyMJHR/6ql0lQisUhwmAFTe5grtcaBokbiMznwLqlLS9AgYE/Vd4xmNXLqb KoI/Y9Qg74vo7mYcipRN1Sp3j/Gzm6Id/MOPt7Sv5lzVJelWMMwW+9XJibV9poMJoEFf SbTmSmbu5gSBdkoJDuH9l4O1WGq3DEfHQK38cmz8aORHd2xzfMxE8C2OYwVz9f0mUdP3 XuEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tHvl53aIYk34xWicj6ITjKQo+f2fhPzIZrY19c3okYQ=; b=G171UA7Lc+o1UF9N8UduVtAjNZjPRT1MuZWdE1fRivTLpA6YEAZf37QvyvWE8+6PBr f3T/TQBaKkp9n9ySWAZAhDw8YAJid+7+Tgd3nKiZGvUocHl0Dgk9JQdruy7EHomPYtne CoGAhyj99yRRipFV8oYmLZtGHogVon7R8SkdsnIfjw+Sb7L6A7/juex3mGkL0+6hyTbE gmB+YelZA8i2fErS/3U/X81QtidpexD6T/pbv9viWbYbSfRg2QfgOP1s2i59Sj5L3pua qs+w4CuQN1BXdG9fOkNUTcj33c2e71LG/TZNXpyS9Pnhw2edOfsYMgRAwkGsCCLf/p2F CtsA==
X-Gm-Message-State: AOAM530tPjP3pdRDK7did22yFbP0+76Tv+6UmbUOYRGnWY/zzQgwp3It eU5LLjow7OVN7J60rtiXDQ==
X-Google-Smtp-Source: ABdhPJy8VbEfToOJmxg+VQ3RfBz0GnhLxvhXHzfvQwMlSzHJBXrAu3BkpWiPnkr2zXVjr7Sn9Z/e2Q==
X-Received: by 2002:a17:902:b692:b029:12b:e0b8:3415 with SMTP id c18-20020a170902b692b029012be0b83415mr3810327pls.32.1627944291841; Mon, 02 Aug 2021 15:44:51 -0700 (PDT)
Received: from ?IPv6:2601:646:9702:c61:f096:47a9:b43c:bd1f? ([2601:646:9702:c61:f096:47a9:b43c:bd1f]) by smtp.gmail.com with ESMTPSA id l1sm11515509pjq.1.2021.08.02.15.44.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Aug 2021 15:44:51 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\))
From: Yingzhen Qu <yingzhen.ietf@gmail.com>
In-Reply-To: <AM7PR07MB6248410CF95AE457D9CB47A2A0EF9@AM7PR07MB6248.eurprd07.prod.outlook.com>
Date: Mon, 2 Aug 2021 15:44:50 -0700
Cc: "mpls@ietf.org" <mpls@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-qu-mpls-mpls-msd-yang@ietf.org" <draft-qu-mpls-mpls-msd-yang@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <337367E8-EED8-4709-B9D3-43A81A91D02B@gmail.com>
References: <162784450568.13184.7481638186028270876@ietfa.amsl.com> <BY5PR13MB304858C756AEA5D8AB06A688E1EF9@BY5PR13MB3048.namprd13.prod.outlook.com> <AM7PR07MB6248410CF95AE457D9CB47A2A0EF9@AM7PR07MB6248.eurprd07.prod.outlook.com>
To: tom petch <ietfc@btconnect.com>
X-Mailer: Apple Mail (2.3654.40.0.2.32)
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/8a31xDbfDocddr-LHdcVfLUZH0I>
Subject: Re: [mpls] New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 22:44:59 -0000

Hi Tom,

Thank you for your review and comments. I have submitted version -02 to address your comments. Please see my detailed answers below.

Thanks,
Yingzhen

> On Aug 2, 2021, at 3:01 AM, tom petch <ietfc@btconnect.com> wrote:
> 
> From: mpls <mpls-bounces@ietf.org> on behalf of Yingzhen Qu <yingzhen.qu@futurewei.com>
> Sent: 02 August 2021 05:41
> 
> Hi all,
> 
> We just submited a new version of the draft. Here is a summary of chagnes:
> 
>  *   updated security consideration with detailed node info
>  *   minor editorial changes
> 
> The draft was originally part of the Segment Routing model, now RFC 9020. It was suggested during AD review to split the MSD part off the SR model since it's a generic MPLS parameter. The model is small and straightforward, and had been literally reviewed many times while it was part of the SR model. We'd like the MPLS WG review it, and request WG adoption.
> 
> If you have any comments, please let us know.
> 
> <tp>
> I started off with some YANG quirks but ended up concluding I really do not understand the purpose of this I-D.
> 
> You create a list indexed by interface-ref for MSD.  MPLS YANG already has a list of interfaces.  Why not use it?
[Yingzhen]: Good suggestion. I’ve made the change.
> 
> You create a list for nodes indexed by msd-type.  Why? and what is the point of  msd-type?
> 
> More generally I do not understand what the identity are doing.  You have no identity for two of the three signalling protocols.  I do not know what the purpose of msd-type is.  Needs justifying in the body of the I-D IMO.
[Yingzhen]: the identity of msd-type is for future extension. In case there are new types created later.
> 
> You specify two protocols for signalling MSD; why not BGP-LS?
[Yingzhen]: I didn’t get this comment. Why BGP-LS here?
> 
> s.1 usually includes RESTCONF
[Yingzhen]: added RESTCONF.
> 
> s.1.1 out of date; the YANG module has the up to date description
[Yingzhen]: fixed.
> 
> YANG
> four authors, three are mailto: one not
[Yingzhen]: fixed.
> 
> MSD needs expanding in the YANG module as that will exist independent of the RFC
[Yingzhen]: fixed. Please let me know if you see places that need expanding.
> 
> identity identifiers have a lot of 'base' which I think redundant
> 'RFC8491: Singling MSD ...'
> 
> erld-msd I think back to front; I prefer msd-erld, msd-….
[Yingzhen]: changed the names. 
> 
> groupings that are only used once often get criticised by a YANG Doctor.  Quite right too IMO it just adds complexity and makes the I-D harder to read for no benefit that I can see.
> 
[Yingzhen]: removed the grouping.

> Tom Petch
> 
> Thanks,
> Yingzhen (on behalf of the co-authors)
> 
> ________________________________
> From: internet-drafts@ietf.org <internet-drafts@ietf.org>
> Sent: Sunday, August 1, 2021 12:01 PM
> To: Acee Lindem <acee@cisco.com>om>; Jeff Tantsura <jefftant.ietf@gmail.com>om>; Stephane Litkowski <slitkows.ietf@gmail.com>om>; Yingzhen Qu <yingzhen.qu@futurewei.com>
> Subject: New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt
> 
> 
> A new version of I-D, draft-qu-mpls-mpls-msd-yang-01.txt
> has been successfully submitted by Yingzhen Qu and posted to the
> IETF repository.
> 
> Name:           draft-qu-mpls-mpls-msd-yang
> Revision:       01
> Title:          A YANG Model for MPLS MSD
> Document date:  2021-08-01
> Group:          Individual Submission
> Pages:          10
> URL:            https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Farchive%2Fid%2Fdraft-qu-mpls-mpls-msd-yang-01.txt&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dxVGZrfMleDR%2B1%2BlkmEXN%2FRJOmL1zXLRD3xKBjNtOzI%3D&amp;reserved=0
> Status:         https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-qu-mpls-mpls-msd-yang%2F&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=sOxeuBLa4ZSUV0to9%2F9SMrpQ2xOE%2Fkxq8hBiPeUlEUc%3D&amp;reserved=0
> Htmlized:       https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fhtml%2Fdraft-qu-mpls-mpls-msd-yang&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=VX8Y40I3tUA%2BKolwyUUNTTV%2BMVt9s5l5MNXiEuIsjA8%3D&amp;reserved=0
> Diff:           https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Frfcdiff%3Furl2%3Ddraft-qu-mpls-mpls-msd-yang-01&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085890780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=SvVf6VTIySZnUBZCgCMfthT%2FSyqkb1gIoES7FYYZg8U%3D&amp;reserved=0
> 
> Abstract:
>   This document defines a YANG data module augmenting the IETF MPLS
>   YANG model to provide support for MPLS Maximum SID Depths (MSDs) as
>   defined in RFC 8476 and RFC 8491.
> 
> 
> 
> 
> The IETF Secretariat
> 
> 
> 
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls