Re: [mpls] working group last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01

Qin Wu <bill.wu@huawei.com> Fri, 27 March 2015 11:37 UTC

Return-Path: <bill.wu@huawei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 652A71ACD6D for <mpls@ietfa.amsl.com>; Fri, 27 Mar 2015 04:37:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.211
X-Spam-Level:
X-Spam-Status: No, score=-4.211 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H3dU3Az98I8v for <mpls@ietfa.amsl.com>; Fri, 27 Mar 2015 04:37:01 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 282451ACD6C for <mpls@ietf.org>; Fri, 27 Mar 2015 04:37:01 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml402-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BQT73675; Fri, 27 Mar 2015 11:36:59 +0000 (GMT)
Received: from NKGEML408-HUB.china.huawei.com (10.98.56.39) by lhreml402-hub.china.huawei.com (10.201.5.241) with Microsoft SMTP Server (TLS) id 14.3.158.1; Fri, 27 Mar 2015 11:36:58 +0000
Received: from NKGEML501-MBS.china.huawei.com ([169.254.2.244]) by nkgeml408-hub.china.huawei.com ([10.98.56.39]) with mapi id 14.03.0158.001; Fri, 27 Mar 2015 19:36:54 +0800
From: Qin Wu <bill.wu@huawei.com>
To: "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: working group last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01
Thread-Index: AQHQYxaymmEqkSnB6UOwcgu2gEley50oNxYAgAgD7mA=
Date: Fri, 27 Mar 2015 11:36:53 +0000
Message-ID: <B8F9A780D330094D99AF023C5877DABA847152CF@nkgeml501-mbs.china.huawei.com>
References: <BY1PR0501MB14303A3E86F750CF628B7234A50E0@BY1PR0501MB1430.namprd05.prod.outlook.com> <550EF528.6040708@mail01.huawei.com>
In-Reply-To: <550EF528.6040708@mail01.huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.145.251]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/9UUNKvgsOW50jybvn4vJUFJmi4c>
Cc: "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>
Subject: Re: [mpls] working group last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Mar 2015 11:37:03 -0000

Hi, Authors of draft-ietf-mpls-lsp-ping-reply-mode-simple-01:
I have read draft-ietf-mpls-lsp-ping-reply-mode-simple-01 and think it is ready to go for publication.
Here are few editorial comments on this draft.
1.section 3.2 said:
"
4.  If a responder LSR understands the Reply Mode Order TLV and the
       TLV is valid, then the responder LSR MUST consider Reply Mode
       values described in the TLV and MUST NOT use the value described
       in the Reply Mode field of received MPLS echo request.
"
I think the value carried in the Reply mode Order TLV overrides the value included in the Reply Mode field of MPLS echo request message header, would it be good to make this more clear and explicit.

2. section 3.2 also said:
"
5.  If a responder LSR understands the Reply Mode Order TLV but the
       TLV is not valid (due to conditions  listed below), then the
       responder LSR MUST only use the value described in the Reply Mode
       field of received MPLS echo request.
"
Not sure where the conditions are specified, suggest to provide a link to the conditions specified in this document

3.section 4.1 said:
"
[RFC7110] has defined that the "Reply Path TLV" can include Sub-TLVs
   describing multiple FECs, from which the responder LSR can chose  the
   FEC to send the MPLS echo reply message on .  
"
s/chose/choose
send the MPLS echo reply message on?
What does "on" mean here? Remove "on" from this sentence?

4. section 4.1.2 said:
"
   Then the MPLS echo request message is to carry:

   o  The Reply Mode Order TLV carrying Reply Modes  {5, 2, 5}
"
Reply mode 5 is not defined in RFC4379.Where reply mode 5 is defined?

5. section 4.2 said:
"
The mechanism defined in this document will work with Proxy LSP Ping
   defined by [I-D.ietf-mpls-proxy-lsp-ping].  MPLS proxy ping request
   can carry a Reply Mode value and  the Reply Mode Order TLV with list
   of Reply Mode values.
"

Suggest To distinct reply mode value carried In the message header and reply mode value carried in the Reply mode order TLV here

6. section 4.2 said:
"
With these procedures, Reply Mode used by the MPLS echo
   reply sender is propagated in the Reply Mode field to the sender of
   MPLS proxy ping request.
"
I am totally confused by this last sentence.
what does " sender" in"the MPLS echo reply" means? Are you saying reply mode value in the echo rely is propagated to proxy ping request? Or propagated to proxy ping reply?
How the sender of MPLS proxy ping request is related to initiator LSR or responder LSR or responding node used in the document?
It will be nice to have a consistence terminologies use.

-Qin
-------- Forwarded Message --------
Subject: 	working group last call for
draft-ietf-mpls-lsp-ping-reply-mode-simple-01
Date: 	Fri, 20 Mar 2015 14:03:52 +0000
From: 	Ross Callon <rcallon@juniper.net>
To: 	mpls@ietf.org <mpls@ietf.org>
CC: 	mpls-chairs@tools.ietf.org <mpls-chairs@tools.ietf.org>, George
Swallow (swallow) <swallow@cisco.com>, Carlos Pignataro (cpignata) <cpignata@cisco.com>, Loa Andersson <loa@mail01.huawei.com>, Mach Chen <mach.chen@huawei.com>, nobo.akiya.dev@gmail.com <nobo.akiya.dev@gmail.com>



Working Group,
This is to initiate a working group last call on draft-ietf-mpls-lsp-ping-reply-mode-simple-01.
Because this WGLC will span the IETF in Dallas, it will be extended to three weeks.
Please send your comments to the mpls wg mailing list (_mpls@ietf.org_ <mailto:mpls@ietf.org>).
There are no IPR disclosures against this document. All the authors have stated that they are not aware of any IPR that relates to this draft.
This working group last call ends Friday  April 10, 2015.
Ross
for the MPLS WG chairs