Re: [mpls] mpls-rt review of draft-zheng-mpls-lsp-ping-yang-cfg

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Fri, 30 November 2018 22:25 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 566B81310E7; Fri, 30 Nov 2018 14:25:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.961
X-Spam-Level:
X-Spam-Status: No, score=-15.961 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NcE2R_piXcHV; Fri, 30 Nov 2018 14:25:23 -0800 (PST)
Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 81B811310F4; Fri, 30 Nov 2018 14:25:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=994; q=dns/txt; s=iport; t=1543616723; x=1544826323; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=59LlOyeiIEAQtg4aUAXB9Fz4C3y6e1B41W5qimNKWS0=; b=BqUByMigsAd8TfW9TBMXNYcgYFoZbEBNkaXNS/ynfVSlWwot/Dyl1Wpz 7dSUHpDQdX+jt3BlTGHh6lV/jfBYmdmYL1GVK6WB8PZdt81meMqijOnzC X6g+01QQ0vQ9jcnuqY9JaPsqYWBYT8ggRGIozfyanmOt8iXvyZLnf0orY k=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AHAADDtwFc/4wNJK1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUwIBAQEBAQsBggOBaDGDb614gXoLAQGEbBmDHSI2Bw0?= =?us-ascii?q?BAwEBAgEBAm0ohT0GIwQNRRIBCBoCJgIEMBUSBAENgyaCAqcOfDOKLYELiw8?= =?us-ascii?q?XgUA/gTgfgkyFAYMEMYImAo8qkQsJApE1GIFMD4UQijSIe487AhEUgScmDSS?= =?us-ascii?q?BVXAVZQGCQpBaQY1ZgR8BAQ?=
X-IronPort-AV: E=Sophos;i="5.56,300,1539648000"; d="scan'208";a="490063435"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 22:25:22 +0000
Received: from XCH-RCD-012.cisco.com (xch-rcd-012.cisco.com [173.37.102.22]) by alln-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id wAUMPL5w028343 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 30 Nov 2018 22:25:22 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-RCD-012.cisco.com (173.37.102.22) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Nov 2018 16:25:20 -0600
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1395.000; Fri, 30 Nov 2018 16:25:21 -0600
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Loa Andersson <loa@pi.nu>, "Shah, Himanshu" <hshah@ciena.com>, Xufeng Liu <Xufeng_Liu@jabil.com>, "Acee Lindem (acee)" <acee@cisco.com>
CC: "draft-zheng-mpls-lsp-ping-yang-cfg@ietf.org" <draft-zheng-mpls-lsp-ping-yang-cfg@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: mpls-rt review of draft-zheng-mpls-lsp-ping-yang-cfg
Thread-Index: AQHUiPuUTZsoea8t8EGSY7/Ptg3owg==
Date: Fri, 30 Nov 2018 22:25:21 +0000
Message-ID: <0D9BF6FB-BBB7-4FE5-BF43-3645B71EB308@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.108.19]
Content-Type: text/plain; charset="utf-8"
Content-ID: <9420DC45139E684098E8CF508D46E260@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.22, xch-rcd-012.cisco.com
X-Outbound-Node: alln-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/CChq-cXDB4z1UtBE_DDkpIUisb8>
Subject: Re: [mpls] mpls-rt review of draft-zheng-mpls-lsp-ping-yang-cfg
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 22:25:32 -0000

Hi Loa, Authors,

I have reviewed this document. Please find my comments below:

The document is for lsp-ping, but do authors plan to include LSP traceroute support in future?

Section 6:
=======
RSVP tunnel uses name (string). Please see TE model.
       :(rsvp)
       |  |  +--ro tunnel-interface?      uint32

control-info -> may be rename to control-parameters, also relevant text. This is similar to scheduling-parameters.

Can we add in the description the unit of the time for the following? 
       min-rtt
       max-rtt
       average-rtt

Should TTL be uint8?
       rw ttl?                   uint32

Any thoughts on other FECs from RFC 8029 (e.g. LDP, Nil-FEC)?

Thanks,
Rakesh