Re: [mpls] mpls-rt review of draft-zheng-mpls-lsp-ping-yang-cfg

Greg Mirsky <gregimirsky@gmail.com> Tue, 04 December 2018 02:18 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0D6AE130DE0; Mon, 3 Dec 2018 18:18:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7QjNC1uNh3LQ; Mon, 3 Dec 2018 18:18:44 -0800 (PST)
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 978A5130DE3; Mon, 3 Dec 2018 18:18:43 -0800 (PST)
Received: by mail-lf1-x132.google.com with SMTP id l10so10727751lfh.9; Mon, 03 Dec 2018 18:18:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZBygaQdaua3Pil2GRD6mNvbgM7jNspzLd6Tgw7p040=; b=eKrsrETozMLu7ABYEZ+jj49iVltuuVvpLz4Ja8REmL84CjkUh4kvDJqp5jecLLDKop 7MJrElYcwZhTqqDG7pvZaEnMJnKqtbcY5qnGEc7l4gSW81+MH+eBRophNi3hcu+6WQ/e DaAlVhm7RFnAQv6b5qXlo8Oa4J363buiPGsXmCpRXLpj9hzOOXhOoOCe2x/T6M+4zfT6 +++yx5bh4efVJmS+mEnBucmo7FQQG8RC0LPqnPY3S7M7QUWKnYU4HiThomf5HwwzkOZa BegKTLHDnpYFalsQ2TUp63Nmfuly1Xa6+I+bNeZaMaaRp/SyeGG9s92/bsVZGdApotDU Ijng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZBygaQdaua3Pil2GRD6mNvbgM7jNspzLd6Tgw7p040=; b=oNkSRabC4V/76HVgY7Ka22SHd2zvMQ7vgycf12hBhSuXHxJZJEGruehRoREWGFHmaQ KeJYQgePy7ACnmV+Li1AUBC8IzmJSStvEy7Gc7agEvkK0r6JUPydOYgNBzc3+WHySVVQ h9Fsu51GI7MpS3Yy0XrbWNlcpQRTzMcUZtrIQAlEHNovw3xg0S+Htb0ZYv9TpF6NlGuy RJqKUk2V2HG2QaVkrp+i0W6tQnQzn4xHHKz77KJ9dknm6AyzmrDlGei9em2zq0L5xv4e mJq8z4Nu+oVYLDNcX2KN6084YFRBZ40y529gjcwyAljoj5abMdjs/WUfdZ13fpEon7QC clqA==
X-Gm-Message-State: AA+aEWbNZc9VKBhhg55E4klI1bACw6v2yh+z6FeazzvWgLLt9nzpMwp1 Rx6eNQ97M+ANhtNGuZ/ykkYlONcXrD3J9rC77gU=
X-Google-Smtp-Source: AFSGD/U2rX+Mnmt673gE45ZYGAIbxLUvi/ipl/XAlW0ZGZZuLdvTB4EN94pPN2vhjJ+B04lVEKszos1h15DRYDAIw0I=
X-Received: by 2002:a19:c650:: with SMTP id w77mr10965881lff.56.1543889921607; Mon, 03 Dec 2018 18:18:41 -0800 (PST)
MIME-Version: 1.0
References: <0D9BF6FB-BBB7-4FE5-BF43-3645B71EB308@cisco.com>
In-Reply-To: <0D9BF6FB-BBB7-4FE5-BF43-3645B71EB308@cisco.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Mon, 3 Dec 2018 18:18:29 -0800
Message-ID: <CA+RyBmXGk7rAv6bSn2V+MZpae=Yb-1_MFNiVt=M2+dpYDzCUHA@mail.gmail.com>
To: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
Cc: Loa Andersson <loa@pi.nu>, "Shah, Himanshu" <hshah@ciena.com>, Xufeng Liu <Xufeng_Liu@jabil.com>, "Acee Lindem (acee)" <acee@cisco.com>, draft-zheng-mpls-lsp-ping-yang-cfg@ietf.org, mpls-chairs@ietf.org, mpls@ietf.org
Content-Type: multipart/alternative; boundary="000000000000598dcb057c28e253"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/EfdSsn84LYa2C8me5Q3e7FkTnlI>
Subject: Re: [mpls] mpls-rt review of draft-zheng-mpls-lsp-ping-yang-cfg
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 02:18:46 -0000

Hi Rakesh,
thank you for the review, detailed questions and the most helpful
suggestions. Please find my answers in-line and tagged GIM>>.



On Fri, Nov 30, 2018 at 2:25 PM Rakesh Gandhi (rgandhi) <rgandhi@cisco.com>;
wrote:

> Hi Loa, Authors,
>
> I have reviewed this document. Please find my comments below:
>
> The document is for lsp-ping, but do authors plan to include LSP
> traceroute support in future?
>
GIM>> Very good question, thank you. At this point the model allows to
realize the traceroute functionality by issuing a series of consecutive LSP
pings while incrementing TTL. Suggestions are always welcome.

>
> Section 6:
> =======
> RSVP tunnel uses name (string). Please see TE model.
>        :(rsvp)
>        |  |  +--ro tunnel-interface?      uint32
>
GIM>> It is a union of uint32 and string types. Will remove uint32 and the
union as unnecessary.

>
> control-info -> may be rename to control-parameters, also relevant text.
> This is similar to scheduling-parameters.
>
GIM>> Thank you for the suggestion. Will do.

>
> Can we add in the description the unit of the time for the following?
>        min-rtt
>        max-rtt
>        average-rtt
>
GIM>>  The theoretical resolution of the NTP time format used in LSP ping
is 233 picoseconds. I think that expressing the RTT measurement in
microseconds (usec) will be sufficiently accurate. What do you think?

>
> Should TTL be uint8?

       rw ttl?                   uint32
>
GIM>> Agree.

>
> Any thoughts on other FECs from RFC 8029 (e.g. LDP, Nil-FEC)?
>
GIM>> Yes, we will work on adding other FECs defined in RFC 8029.

>
> Thanks,
> Rakesh
>
>
>
>
>