Re: [mpls] RtgDir review: draft-ietf-mpls-sfc-04.txt

[Mach Chen <[e-mail]>]

Hi Adrian,

Thanks for your reply!

See some response inline...

> -----Original Message-----
> From: Adrian Farrel [mailto:[e-mail]]
> Sent: Sunday, January 06, 2019 5:03 AM
> To: Mach Chen <[e-mail]>; [e-mail]
> Cc: [e-mail]; [e-mail]; [e-mail]
> Subject: RE: RtgDir review: draft-ietf-mpls-sfc-04.txt
> 
> Hi Mach,
> 
> Thanks for your careful review.
> 
> > Minor Issues:
> > *	Section 13 says:
> > "
> >   b.  When the packet arrives at SFFa it strips any labels associated
> >       with the tunnel that runs from the classifier to SFFa.  SFFa
> >       examines the top labels and matches the SPI/SI to identify that
> >       the packet should be forwarded to SFa.  The packet is forwarded
> >       to SFa unmodified.
> >
> >   c.  SFa performs its designated function and returns the packet to
> >       SFFa.
> >
> >   d.  SFFa modifies the SI in the lower label stack entry (to 254) and
> >       uses the SPI/SI to look up the forwarding instructions.  It sends
> >       the packet with two label stack entries:
> >"
> > From above text, it seems that an SFF will have different process for
> >a
> packet that
> > has the same SPI/SI.
> >  1) if a packet is received from a previous SFF, it will match the
> > SPI/SI
> and determine
> >  to where the packet will be sent.
> >  2) if a packet is received from an SF, it will directly modify the
> > inner
> label, and then
> > by matching the new SPI/SI to determine to where the packet will be sent.
> >
> > Is this the intention ? If so, how does an SFF determine whether a
> > packet
> is from an
> > SFF or from SF?
> 
> You have understood the processing correctly.
> In fact, the same situation exists with NSH processing: the SFF is expected to
> "know" whether the packet has arrived from the previous SFF or from the SF.
> 
> There are probably two answers:
> Firstly, it is entirely possible that the SFF and SF are co-resident. That is, they
> form part of the same implementation, possibly being separated by an API.
> In this case, of course, the question does not arise.
> Secondly, it is reasonable to expect that the SFs are attached to the SFF by
> dedicated tunnels or ports (indeed, SFs are port-attached in the legacy
> service function world) so that a packet arriving on a line interface (from
> another SFF) is easily distinguished from one that arrives from an SF. (You
> might think about port-attached L3VPNs to help clarity how this could work).

If so, it's better to add some text to clarify this. Given the current text, it implies that it could be determined just by matching the SPI/SI.

> 
> > In addition, how does an SFF apply the swap and/or pop operations here.
> E.g., when an SFF looks up the SPI,
> > it matches an item in a local table; what operation (swap or pop) will
> apply to the SPI label? According to " The
> > packet is forwarded to SFa unmodified." It seems implies that there is
> > no
> any operation will be applied. If so,
> > this will not align with the MPLS.
> 
> I think you should also look at this in the manner of a L3VPN. That is, the top
> label is popped to derive the context, the forwarding label is looked up
> within the context and swapped, and the context label is re-imposed as the
> packet is forwarded.
> 
> Of course, there are optimisations on how an SFF might implement this, but
> we don't need to describe those. What we know is that the VPN-like
> approach can be made to work with existing PEs.

As above, it's better to add some text to make it clearer. 

> 
> > If the above issues exist, the " context/SF" case has the similar issues.
> 
> Hope I have explained why this is not an issue.
> 
> Now, we could debate why we have not made these answers more clear in
> the text.
> The first thing is that we are not trying to make any changes to the
> architecture used for NSH, so we did not feel we should go into explanations
> about how the SF/SFF relationship works.
> Additionally, we did not feel that (beyond the short section 14) we should tell
> people how to implement. The purpose of the document is to describe wire
> formats.

IMHO, it may not be enough if just describing the wire formats, the operations/process on the "formats" are necessary to make it an implementable and interoperable protocol. 

Although Section 13 is listed as a worked example, I personally think that they are necessary procedures. I'd suggest to change it to more "formal" section, e.g., Procedures. 

Best regards,
Mach

> 
> Best,
> Adrian