Return-Path: <naikumar@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id AB6071B2E3C
 for <mpls@ietfa.amsl.com>; Sat, 26 Sep 2015 07:24:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level: 
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5,
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5]
 autolearn=ham
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id zkJkzn61pFHE for <mpls@ietfa.amsl.com>;
 Sat, 26 Sep 2015 07:24:09 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 137911B2E38
 for <mpls@ietf.org>; Sat, 26 Sep 2015 07:24:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=cisco.com; i=@cisco.com; l=50117; q=dns/txt;
 s=iport; t=1443277448; x=1444487048;
 h=from:to:cc:subject:date:message-id:in-reply-to: mime-version;
 bh=W+muRsKeoPjHnxnVxuHQvkFXIGF3lvknwN/dulHRw2k=;
 b=OuRdjjPYZmqhA/vSUV+/uXpJstG8FMR/VpKOkJuFPBwIOcMYl6tEys6y
 msd5h8HlWrRLgeYu4DaoPFdV1kW466v/YogaRM++xTSl6cIuqNlVwah8j
 GA1OBnlxdB5xxUh4MnGdHpuQhOrbrYj9oddlzTiUdXarRleC6zqDPLKPr k=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AYAgChqQZW/49dJa1dgldNVGkGhS64CAENgXuEIIFZAoEfOBQBAQEBAQEBgQqEJAEBAQQnBj4ODAIEAQgRAwEBASEBBiIGERQJCAIEAQ0FiBkDEg3GSg2FDAEBAQEBAQEBAQEBAQEBAQEBAQEBARMEBIpmgQaCUIFRCRACASQBBxMNBAcGhCYFhzEDhnuHQQGFFIYKgXCBT4Q2jHh8g1mDbAEfAQFCghEcgVRxh1kCBRkHHIEFAQEB
X-IronPort-AV: E=Sophos; i="5.17,592,1437436800"; d="scan'208,217";
 a="30396174"
Received: from rcdn-core-7.cisco.com ([173.37.93.143])
 by rcdn-iport-8.cisco.com with ESMTP; 26 Sep 2015 14:24:07 +0000
Received: from XCH-RCD-014.cisco.com (xch-rcd-014.cisco.com [173.37.102.24])
 by rcdn-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id t8QEO7HQ029722
 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL);
 Sat, 26 Sep 2015 14:24:07 GMT
Received: from xch-rcd-015.cisco.com (173.37.102.25) by XCH-RCD-014.cisco.com
 (173.37.102.24) with Microsoft SMTP Server (TLS) id 15.0.1104.5;
 Sat, 26 Sep 2015 09:24:06 -0500
Received: from xch-rcd-015.cisco.com ([173.37.102.25]) by
 XCH-RCD-015.cisco.com ([173.37.102.25]) with mapi id 15.00.1104.000; Sat, 26
 Sep 2015 09:24:06 -0500
From: "Nagendra Kumar Nainar (naikumar)" <naikumar@cisco.com>
To: "Dutta, Pranjal K (Pranjal)" <pranjal.dutta@alcatel-lucent.com>, "Loa
 Andersson" <loa@pi.nu>, Curtis Villamizar <curtis@occnc.com>,
 "vishwas.manral@gmail.com" <vishwas.manral@gmail.com>, Lizhong Jin
 <lizho.jin@gmail.com>,
 "draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org"
 <draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org>,
 "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>
Thread-Topic: MPLS-RT review of draft-kumarkini-mpls-spring-lsp-ping
Thread-Index: AQHQ6uZThyQvT/8dOEmUFCIze73HOJ5OavkAgACd6gA=
Date: Sat, 26 Sep 2015 14:24:06 +0000
Message-ID: <D22C229D.81CEF%naikumar@cisco.com>
In-Reply-To: <ABD110CD5D879A4BB51C269846E4CA3128C9CB@SG70YWXCHMBA08.zap.alcatel-lucent.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: Microsoft-MacOutlook/14.3.8.130913
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.223.145]
Content-Type: multipart/alternative;
 boundary="_000_D22C229D81CEFnaikumarciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/H2oLjEOLXxEsMfubg-YKshc1G18>
Cc: "mpls@ietf.org" <mpls@ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-kumarkini-mpls-spring-lsp-ping
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>,
 <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>,
 <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Sep 2015 14:24:13 -0000

--_000_D22C229D81CEFnaikumarciscocom_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

Hi Pranjal,

Thanks for the review and comments. We will address the same and will updat=
e back.

Thanks,
Nagendra

From: <Dutta>, "Pranjal K (Pranjal)" <pranjal.dutta@alcatel-lucent.com<mail=
to:pranjal.dutta@alcatel-lucent.com>>
Date: Friday, September 25, 2015 at 8:58 PM
To: Loa Andersson <loa@pi.nu<mailto:loa@pi.nu>>, Curtis Villamizar <curtis@=
occnc.com<mailto:curtis@occnc.com>>, "vishwas.manral@gmail.com<mailto:vishw=
as.manral@gmail.com>" <vishwas.manral@gmail.com<mailto:vishwas.manral@gmail=
.com>>, Lizhong Jin <lizho.jin@gmail.com<mailto:lizho.jin@gmail.com>>, "dra=
ft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org<mailto:draft-kumarkini-mpl=
s-spring-lsp-ping@tools.ietf.org>" <draft-kumarkini-mpls-spring-lsp-ping@to=
ols.ietf.org<mailto:draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org>>, =
"mpls-chairs@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>" <mpls-chair=
s@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>>
Cc: "mpls@ietf.org<mailto:mpls@ietf.org>" <mpls@ietf.org<mailto:mpls@ietf.o=
rg>>
Subject: RE: MPLS-RT review of draft-kumarkini-mpls-spring-lsp-ping
Resent-From: <pranjal.dutta@alcatel-lucent.com<mailto:pranjal.dutta@alcatel=
-lucent.com>>
Resent-To: <draft-kumarkini-mpls-spring-lsp-ping@ietf.org<mailto:draft-kuma=
rkini-mpls-spring-lsp-ping@ietf.org>>, <mpls-chairs@ietf.org<mailto:mpls-ch=
airs@ietf.org>>
Resent-Date: Friday, September 25, 2015 at 8:58 PM


Hi,

     I have been asked by the WG chairs for MPLS-RT review on this draft. I=
 have reviewed the version  https://tools.ietf.org/html/draft-kumarkini-mpl=
s-spring-lsp-ping-04 and following are my review comments.



1.      Section 4.1 on the problem definition: This section falls short of =
discussing various critical fault scenarios in detail.



For example, following is an important case.





                  +--------+

                  |   L2   |

                  R3-------R6

                 /           \

                /             \

        R1----R2               R7----R8

                \             /

                 \           /

                  R4-------R5



    9136 --> Adjacency Segment ID from R3 to R6 over link L1.

    9236 --> Adjacency Segment ID from R3 to R6 over link L2.

    9124 --> Adjacency segment ID from R2 to R4.

    9123 --> Adjacency Segment ID from R2 to R3.

    9145 --> Adjacency Segment ID from R4 to R5.

    9157 --> Adjacency segment ID from R5 to R7.

    9178 --> Adjacency segment ID from R7 to R8.

    9167 --> Adjacency segment ID from R6 to R7.



Let's say R1 originates a packet with the following label stack:



   9123 + 9136 + 9167 + 9178 + Payload



   R2 pops Adjacency Segment ID 9123 and forwards the packet to the correct=
 next-hop link R2-R3. But R2 is malfunctioning such that it also pops 9136.

   Thus R3 receives the Adjacency Segment ID 9167. By quirk of fate Label/9=
167 =3D label/9236 because both labels are locally significant to advertisi=
ng nodes.

   As a result, R3 forwards the packet to R6 over link L2. R6 receives 9178=
 and drops the packet after finding no state programmed for 9178. The packe=
t

   traverses the intended path till R6 whereas the problem is at R2.



   Similarly, instead of POPPing unwanted labels the malfunctioning node co=
uld PUSH unwanted labels. Such issues may not be due to wrong programming b=
y control plane (or data
   plane out of sync) and can happen due to a few bit flips on faulty h/w o=
r memory.



2.      Sections 5.1 and 5.2: the target FEC stack TLV for a prefix SID MUS=
T include the SID index value and not just the address to be sure this gets=
 checked for overlaps or errors of assigning the SID index value.



3.      Section 6: The DSMAP should not be supported with SR and SR-TE LSP.=
 The DDMAP is required because of the hierarchical nature of the LSP. See n=
ext comment for more details.



4.      Section 7.1: I think what is missing upfront in the document is the=
 modeling in MPLS OAM of a SR or SR-TE LSP. Basically, it should be modeled=
 as a hierarchical LSP which MUST use the DDMAP TLV with the FEC Stack Chan=
ge sub-TLV to operate correctly. The following operations are supported:



a.       A node/prefix SID label that is swapped at an LSR results in the n=
ormal return code of 8  "Label switched at stack-depth <RSC>" as per RFC 43=
79.

b.      A node/prefix SID label which is popped at an LSR results in a FEC =
stack change TLV operation of =93POP=94 as per RFC 6424.

c.       An adjacency SID label popped at an LSR results in a FEC stack cha=
nge TLV operation of =93POP=94 as per RFC 6424. In other words, we are mode=
ling the swap operation into a implicit NULL label as a POP to simplify the=
 tracing operation with DDMAP.



5.      Section 7.1: The text under paragraph titled =93Traceroute=94 is ve=
ry ambiguous and confusing and it may suggest that new behavior is being de=
scribed. In fact, there is nothing new to add here and the behavior of the =
FEC stack change sub-TLV is as per RFC 6424. All what is needed is a clear =
description of the modeling of the SR/SR-TE LSP as per comment above.



  For example, let's apply the procedures in this section to the fault scen=
ario I had discussed in comment 1).



  5.1. R1 initiates Echo Request with TTL=3D1 carrying Targeted FEC stack 9=
123 + 9136 + 9167 + 9178. From the procedures it is not clear  whether R1 w=
ould send DSMAP/DDMAP TLV
         containing the Label stack. IMO, it MUST send Label stack - withou=
t it R2 can't validate if received data plane label stack is same as in rec=
eived DSMAP/DDMAP (see later in 5.5).



  5.2  R2 responds with Echo reply containing FEC stack change/pop for 9123=
.



  5.3. R1 initiates Echo Request with TTL=3D2 carrying Targeted FEC stack 9=
136 + 9167 + 9178 and DSMAP/DDMAP containing corresponding label stack

       9136 + 9167 + 9178. The data plane label stack is 9123 + 9136 + 9167=
 + 9178.



  5.4. The malfunctioning node R2 forwards the packet to R3 with data-plane=
 label stack 9167 + 9178.



  5.5. R3 validates from received Targeted FEC stack that 9136 is the indee=
d an advertised Adjacency ID and corresponding label in DSMAP/DDMAP is corr=
ect. However the label stack
          received in data plane does not correspond to the label stack in =
DSMAP - this is a key point and there is no mention of it in the draft. Thu=
s R3 responds with label_stack_validation
         failure which indicates a data plane fault in R2.



6.      Section 7.2: the popping of the adjacency SID label is performed by=
 the node which assigned it and it is this node which generates the FEC sta=
ck change sub-TLV with the operation of POP.



7.      Section 7.3: while I agree that the implicit NULL label value for t=
he adjacency SID should not be used because the downstream LSR has no conte=
xt for the adjacency SID of his upstream neighbor (adjacency SIDs are local=
ly significant only) but for node SID with PHP, the downstream node has con=
text and actually signaled PHP flag in the prefix SID sub-TLV. Implicit-Nul=
l value is thus valid for node SID.



8.      Section 7.4: This section needs to be written to cover the cases of=
 regular swapping of node/prefix SID and the popping of node SID or adjacen=
cy SID when receiving the FEC stack change sub-TLV. Also, what is exactly =
=93Best return code to 10=94?



9.      Section 7.5: I do not think this section belongs here. If there are=
 recommendations for TTL setting for hierarchical LSPs, they sure are not s=
pecific to SR/SR-TE LSP.





10.  In Section 5



=93Three new sub-TLVs are defined for TLVs type 1, 16 and 21.=94

It is not clear what is meant by TLVs type 1,16 and 21. Suggest to make exp=
licit references.



11. One missing point in MPLS-OAM so far is to let the originator of a Trac=
eroute know that responding node is currently exercising FRR backup next-ho=
p (because primary has failed).
     AFAIK, this is not covered in any MPLS OAM extensions so far. It is go=
od to address this in SR context.



Summary

-------------



1) Whether the document is coherent

  - Yes



2) is it useful (i.e, is it likely to be actually useful in operational net=
works)



  - Yes



3) Is the document technically sound?



  - Need precise modeling of MPLS-OAM of a SR/SR-TE LSP. Need to precisely =
describe procedures in the context of  SR/SR-TE LSP and applicability of RF=
C 4379, 6424.



4) Whether the document is ready to be considered for WG adoption

  - It is a good start but I would like to see the concerns addressed befor=
e publishing the WG draft.



Thanks,

Pranjal





-----Original Message-----
From: Loa Andersson [mailto:loa@pi.nu]
Sent: Wednesday, September 09, 2015 3:00 AM
To: Curtis Villamizar; vishwas.manral@gmail.com<mailto:vishwas.manral@gmail=
.com>; Dutta, Pranjal K (Pranjal); Lizhong Jin; draft-kumarkini-mpls-spring=
-lsp-ping@tools.ietf.org<mailto:draft-kumarkini-mpls-spring-lsp-ping@tools.=
ietf.org>; mpls-chairs@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>
Subject: Fwd: MPLS-RT review of draft-kumarkini-mpls-spring-lsp-ping



Resending, Vishwas mail bounced and forgot to include the authors and my co=
-chairs.



/Loa



Curtis, Vishwas, Pranjal, and Lizhong,



You have be selected as MPLS-RT reviewers for draft-kumarkini- mpls-spring-=
lsp-ping.



Note to authors: You have been CC'd on this email so that you can know that=
 this review is going on. However, please do not review your own document.



Reviews should comment on whether the document is coherent, is it useful (i=
e, is it likely to be actually useful in operational networks), and is the =
document technically sound?



We are interested in knowing whether the document is ready to be considered=
 for WG adoption (ie, it doesn't have to be perfect at this point, but shou=
ld be a good start).



Reviews should be sent to the document authors, WG co-chairs and WG secreta=
ry, and CC'd to the MPLS WG email list. If necessary, comments may be sent =
privately to only the WG chairs.



If you have technical comments you should try to be explicit about what nee=
ds to be resolved before adopting it as a working group document, and what =
can wait until the document is a working group document and the working gro=
up has the revision control.



Are you able to review this draft by September 25, 2015? Please respond in =
a timely fashion.



Thanks, Loa

(as MPLS WG chair)







--





Loa Andersson                        email: loa@mail01.huawei.com<mailto:lo=
a@mail01.huawei.com>

Senior MPLS Expert                          loa@pi.nu<mailto:loa@pi.nu>

Huawei Technologies (consultant)     phone: +46 739 81 21 64



--





Loa Andersson                        email: loa@mail01.huawei.com<mailto:lo=
a@mail01.huawei.com>

Senior MPLS Expert                          loa@pi.nu<mailto:loa@pi.nu>

Huawei Technologies (consultant)     phone: +46 739 81 21 64





--_000_D22C229D81CEFnaikumarciscocom_
Content-Type: text/html; charset="Windows-1252"
Content-ID: <F04119A7171D4A4BB42778DB6031777A@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1=
252">
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-lin=
e-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-fami=
ly: Calibri, sans-serif;">
<div>Hi Pranjal,</div>
<div><br>
</div>
<div>Thanks for the review and comments. We will address the same and will =
update back.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Nagendra</div>
<div><br>
</div>
<span id=3D"OLK_SRC_BODY_SECTION">
<div style=3D"font-family:Calibri; font-size:11pt; text-align:left; color:b=
lack; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM:=
 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid;=
 BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style=3D"font-weight:bold">From: </span>&lt;Dutta&gt;, &quot;Pranjal =
K (Pranjal)&quot; &lt;<a href=3D"mailto:pranjal.dutta@alcatel-lucent.com">p=
ranjal.dutta@alcatel-lucent.com</a>&gt;<br>
<span style=3D"font-weight:bold">Date: </span>Friday, September 25, 2015 at=
 8:58 PM<br>
<span style=3D"font-weight:bold">To: </span>Loa Andersson &lt;<a href=3D"ma=
ilto:loa@pi.nu">loa@pi.nu</a>&gt;, Curtis Villamizar &lt;<a href=3D"mailto:=
curtis@occnc.com">curtis@occnc.com</a>&gt;, &quot;<a href=3D"mailto:vishwas=
.manral@gmail.com">vishwas.manral@gmail.com</a>&quot; &lt;<a href=3D"mailto=
:vishwas.manral@gmail.com">vishwas.manral@gmail.com</a>&gt;,
 Lizhong Jin &lt;<a href=3D"mailto:lizho.jin@gmail.com">lizho.jin@gmail.com=
</a>&gt;, &quot;<a href=3D"mailto:draft-kumarkini-mpls-spring-lsp-ping@tool=
s.ietf.org">draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org</a>&quot; &=
lt;<a href=3D"mailto:draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org">d=
raft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org</a>&gt;,
 &quot;<a href=3D"mailto:mpls-chairs@tools.ietf.org">mpls-chairs@tools.ietf=
.org</a>&quot; &lt;<a href=3D"mailto:mpls-chairs@tools.ietf.org">mpls-chair=
s@tools.ietf.org</a>&gt;<br>
<span style=3D"font-weight:bold">Cc: </span>&quot;<a href=3D"mailto:mpls@ie=
tf.org">mpls@ietf.org</a>&quot; &lt;<a href=3D"mailto:mpls@ietf.org">mpls@i=
etf.org</a>&gt;<br>
<span style=3D"font-weight:bold">Subject: </span>RE: MPLS-RT review of draf=
t-kumarkini-mpls-spring-lsp-ping<br>
<span style=3D"font-weight:bold">Resent-From: </span>&lt;<a href=3D"mailto:=
pranjal.dutta@alcatel-lucent.com">pranjal.dutta@alcatel-lucent.com</a>&gt;<=
br>
<span style=3D"font-weight:bold">Resent-To: </span>&lt;<a href=3D"mailto:dr=
aft-kumarkini-mpls-spring-lsp-ping@ietf.org">draft-kumarkini-mpls-spring-ls=
p-ping@ietf.org</a>&gt;, &lt;<a href=3D"mailto:mpls-chairs@ietf.org">mpls-c=
hairs@ietf.org</a>&gt;<br>
<span style=3D"font-weight:bold">Resent-Date: </span>Friday, September 25, =
2015 at 8:58 PM<br>
</div>
<div><br>
</div>
<div xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micro=
soft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" x=
mlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:/=
/www.w3.org/TR/REC-html40">
<meta name=3D"Generator" content=3D"Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Consolas;
	panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
	{mso-style-priority:99;
	mso-style-link:"Plain Text Char";
	margin:0in;
	margin-bottom:.0001pt;
	font-size:10.5pt;
	font-family:Consolas;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
	{mso-style-priority:34;
	margin-top:0in;
	margin-right:0in;
	margin-bottom:0in;
	margin-left:.5in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";}
span.PlainTextChar
	{mso-style-name:"Plain Text Char";
	mso-style-priority:99;
	mso-style-link:"Plain Text";
	font-family:Consolas;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
/* List Definitions */
@list l0
	{mso-list-id:945430559;
	mso-list-type:hybrid;
	mso-list-template-ids:-947212612 67698703 67698713 67698715 67698703 67698=
713 67698715 67698703 67698713 67698715;}
@list l0:level1
	{mso-level-tab-stop:none;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level2
	{mso-level-tab-stop:1.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level3
	{mso-level-tab-stop:1.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level4
	{mso-level-tab-stop:2.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level5
	{mso-level-tab-stop:2.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level6
	{mso-level-tab-stop:3.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level7
	{mso-level-tab-stop:3.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level8
	{mso-level-tab-stop:4.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l0:level9
	{mso-level-tab-stop:4.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l1
	{mso-list-id:1108281079;
	mso-list-type:hybrid;
	mso-list-template-ids:-1867115982 1850925714 67698713 67698715 67698703 67=
698713 67698715 67698703 67698713 67698715;}
@list l1:level1
	{mso-level-tab-stop:none;
	mso-level-number-position:left;
	margin-left:21.0pt;
	text-indent:-.25in;
	mso-ansi-font-size:12.0pt;
	mso-bidi-font-size:12.0pt;
	font-family:"Times New Roman","serif";}
@list l2
	{mso-list-id:1772582449;
	mso-list-type:hybrid;
	mso-list-template-ids:-691747152 -1306071560 67698713 67698715 67698703 67=
698713 67698715 67698703 67698713 67698715;}
@list l2:level1
	{mso-level-number-format:alpha-lower;
	mso-level-tab-stop:none;
	mso-level-number-position:left;
	margin-left:.75in;
	text-indent:-.25in;}
@list l2:level2
	{mso-level-tab-stop:1.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level3
	{mso-level-tab-stop:1.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level4
	{mso-level-tab-stop:2.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level5
	{mso-level-tab-stop:2.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level6
	{mso-level-tab-stop:3.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level7
	{mso-level-tab-stop:3.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level8
	{mso-level-tab-stop:4.0in;
	mso-level-number-position:left;
	text-indent:-.25in;}
@list l2:level9
	{mso-level-tab-stop:4.5in;
	mso-level-number-position:left;
	text-indent:-.25in;}
ol
	{margin-bottom:0in;}
ul
	{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
<div lang=3D"EN-US" link=3D"blue" vlink=3D"purple">
<div class=3D"WordSection1">
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">Hi,<o:p></o:p></span></p>
<p class=3D"MsoPlainText">&nbsp; <span style=3D"font-size: 12pt; font-famil=
y: 'Times New Roman', serif;">
&nbsp;&nbsp;&nbsp;I have been asked by the WG chairs for MPLS-RT review on =
this draft. I have reviewed the version &nbsp;<a href=3D"https://tools.ietf=
.org/html/draft-kumarkini-mpls-spring-lsp-ping-04">https://tools.ietf.org/h=
tml/draft-kumarkini-mpls-spring-lsp-ping-04</a> and following
 are my review comments.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">1.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 4.1 on the problem definition: This=
 section falls short of discussing various critical fault scenarios in deta=
il.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">For example, following is an important case.<o:p></o=
:p></span></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &#43;--------&#43;<o:=
p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; |&nbsp;&nbsp; L2&nbsp=
;&nbsp; |<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; R3-------R6<o:p></o:p=
></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; R1----=
R2&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp; R7----R8<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;\&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \&nbsp;&nbsp;&nbsp;&nbsp;&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; R4-------R5<o:p></o:p=
></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9136 --&gt; Adjacency Segment =
ID from R3 to R6 over link L1.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9236 --&gt; Adjacency Segment =
ID from R3 to R6 over link L2.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9124 --&gt; Adjacency segment =
ID from R2 to R4.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9123 --&gt; Adjacency Segment =
ID from R2 to R3.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9145 --&gt; Adjacency Segment =
ID from R4 to R5.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9157 --&gt; Adjacency segment =
ID from R5 to R7.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9178 --&gt; Adjacency segment =
ID from R7 to R8.<o:p></o:p></p>
<p class=3D"MsoPlainText">&nbsp;&nbsp;&nbsp; 9167 --&gt; Adjacency segment =
ID from R6 to R7.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">Let's say R1 originates a packet with the following =
label stack:<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp; 9123 &#43; 9136 &#43; 9167 &#43; 9178 &=
#43; Payload<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp; R2 pops Adjacency Segment ID 9123 and f=
orwards the packet to the correct next-hop link R2-R3. But R2 is malfunctio=
ning such that it also pops 9136.
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;Thus R3 receives the Adjacency Seg=
ment ID 9167. By quirk of fate Label/9167 =3D label/9236 because both label=
s are locally significant to advertising nodes.&nbsp;&nbsp;&nbsp;
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;As a result, R3 forwards the packe=
t to R6 over link L2. R6 receives 9178 and drops the packet after finding n=
o state programmed for 9178. The packet
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;traverses the intended path till R=
6 whereas the problem is at R2.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp; Similarly, instead of POPPing unwanted =
labels the malfunctioning node could PUSH unwanted labels. Such issues may =
not be due to wrong programming by control plane
 (or data <br>
&nbsp;&nbsp;&nbsp;plane out of sync) and can happen due to a few bit flips =
on faulty h/w or memory.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">2.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Sections 5.1 and 5.2: the target FEC stack =
TLV for a prefix SID MUST include the SID index value and not just the addr=
ess to be sure this gets checked for
 overlaps or errors of assigning the SID index value.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.5in"><span style=3D"font-si=
ze: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span><=
/p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">3.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 6: The DSMAP should not be supporte=
d with SR and SR-TE LSP. The DDMAP is required because of the hierarchical =
nature of the LSP. See next comment
 for more details.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.5in"><span style=3D"font-si=
ze: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span><=
/p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">4.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.1: I think what is missing upfron=
t in the document is the modeling in MPLS OAM of a SR or SR-TE LSP. Basical=
ly, it should be modeled as a hierarchical
 LSP which MUST use the DDMAP TLV with the FEC Stack Change sub-TLV to oper=
ate correctly. The following operations are supported:<o:p></o:p></span></p=
>
<p class=3D"MsoPlainText" style=3D"margin-left:.5in"><span style=3D"font-si=
ze: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span><=
/p>
<p class=3D"MsoPlainText" style=3D"margin-left:.75in;text-indent:-.25in;mso=
-list:l2 level1 lfo2">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">a.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">A node/prefix SID label that is swapped at =
an LSR results in the normal return code of 8&nbsp; &quot;Label switched at=
 stack-depth &lt;RSC&gt;&quot; as per RFC 4379.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.75in;text-indent:-.25in;mso=
-list:l2 level1 lfo2">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">b.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">A node/prefix SID label which is popped at =
an LSR results in a FEC stack change TLV operation of =93POP=94 as per RFC =
6424.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.75in;text-indent:-.25in;mso=
-list:l2 level1 lfo2">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">c.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">An adjacency SID label popped at an LSR res=
ults in a FEC stack change TLV operation of =93POP=94 as per RFC 6424. In o=
ther words, we are modeling the swap operation
 into a implicit NULL label as a POP to simplify the tracing operation with=
 DDMAP.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.75in"><span style=3D"font-s=
ize: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span>=
</p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">5.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.1: The text under paragraph title=
d =93Traceroute=94 is very ambiguous and confusing and it may suggest that =
new behavior is being described. In fact,
 there is nothing new to add here and the behavior of the FEC stack change =
sub-TLV is as per RFC 6424. All what is needed is a clear description of th=
e modeling of the SR/SR-TE LSP as per comment above.
</span><o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">&nbsp; <span style=3D"font-size: 12pt; font-famil=
y: 'Times New Roman', serif;">
For example, let's apply the procedures in this section to the fault scenar=
io I had discussed in comment 1).<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; 5.1. R1 initiates Echo Request with TTL=3D1 c=
arrying Targeted FEC stack 9123 &#43; 9136 &#43; 9167 &#43; 9178. From the =
procedures it is not clear &nbsp;whether R1 would send DSMAP/DDMAP
 TLV <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;containing the Label =
stack. IMO, it MUST send Label stack - without it R2 can't validate if rece=
ived data plane label stack is same as in received DSMAP/DDMAP (see later i=
n 5.5).
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; 5.2&nbsp; R2 responds with Echo reply contain=
ing FEC stack change/pop for 9123.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;&nbsp;
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;5.3. R1 initiates Echo Request with TTL=
=3D2 carrying Targeted FEC stack 9136 &#43; 9167 &#43; 9178 and DSMAP/DDMAP=
 containing corresponding label stack
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;9136 &#43;=
 9167 &#43; 9178. The data plane label stack is 9123 &#43; 9136 &#43; 9167 =
&#43; 9178.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;&nbsp;&nbsp;
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;5.4. The malfunctioning node R2 forwards=
 the packet to R3 with data-plane label stack 9167 &#43; 9178.<o:p></o:p></=
span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; 5.5. R3 validates from received Targeted FEC =
stack that 9136 is the indeed an advertised Adjacency ID and corresponding =
label in DSMAP/DDMAP is correct. However
 the label stack <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;received in dat=
a plane does not correspond to the label stack in DSMAP - this is a key poi=
nt and there is no mention of it in the draft. Thus R3 responds with label_=
stack_validation
<br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;failure which indicat=
es a data plane fault in R2.&nbsp;&nbsp; <o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.5in"><span style=3D"font-si=
ze: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span><=
/p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">6.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.2: the popping of the adjacency S=
ID label is performed by the node which assigned it and it is this node whi=
ch generates the FEC stack change
 sub-TLV with the operation of POP.<o:p></o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:.5in"><span style=3D"font-si=
ze: 12pt; font-family: 'Times New Roman', serif;"><o:p>&nbsp;</o:p></span><=
/p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">7.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.3: while I agree that the implici=
t NULL label value for the adjacency SID should not be used because the dow=
nstream LSR has no context for the
 adjacency SID of his upstream neighbor (adjacency SIDs are locally signifi=
cant only) but for node SID with PHP, the downstream node has context and a=
ctually signaled PHP flag in the prefix SID sub-TLV. Implicit-Null value is=
 thus valid for node SID.<o:p></o:p></span></p>
<p class=3D"MsoListParagraph"><span style=3D"font-size: 12pt; font-family: =
'Times New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">8.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.4: This section needs to be writt=
en to cover the cases of regular swapping of node/prefix SID and the poppin=
g of node SID or adjacency SID when
 receiving the FEC stack change sub-TLV. Also, what is exactly =93Best retu=
rn code to 10=94?<o:p></o:p></span></p>
<p class=3D"MsoListParagraph"><span style=3D"font-size: 12pt; font-family: =
'Times New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">9.=
<span style=3D"font-style: normal; font-variant: normal; font-weight: norma=
l; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&n=
bsp;&nbsp;&nbsp;&nbsp;&nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">Section 7.5: I do not think this section be=
longs here. If there are recommendations for TTL setting for hierarchical L=
SPs, they sure are not specific to
 SR/SR-TE LSP.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText" style=3D"margin-left:21.0pt;text-indent:-.25in;ms=
o-list:l1 level1 lfo3">
<!--[if !supportLists]--><span style=3D"font-size:12.0pt;font-family:&quot;=
Times New Roman&quot;,&quot;serif&quot;"><span style=3D"mso-list:Ignore">10=
.<span style=3D"font-style: normal; font-variant: normal; font-weight: norm=
al; font-size: 7pt; line-height: normal; font-family: 'Times New Roman';">&=
nbsp;
</span></span></span><!--[endif]--><span style=3D"font-size: 12pt; font-fam=
ily: 'Times New Roman', serif;">In Section 5<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">=93Three new sub-TLVs are defined for TLVs type 1, 1=
6 and 21.=94<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">It is not clear what is meant by TLVs type 1,16 and =
21. Suggest to make explicit references.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">11. One missing point in MPLS-OAM so far is to let t=
he originator of a Traceroute know that responding node is currently exerci=
sing FRR backup next-hop (because primary
 has failed). <br>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;AFAIK, this is not covered in any MPLS OAM ex=
tensions so far. It is good to address this in SR context.<o:p></o:p></span=
></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">Summary<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">-------------<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">1) Whether the document is coherent<o:p></o:p></span=
></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; - Yes<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">2) is it useful (i.e, is it likely to be actually us=
eful in operational networks)<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; - Yes<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">3) Is the document technically sound?<o:p></o:p></sp=
an></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp; - Need precise modeling of MPLS-OAM of a SR/S=
R-TE LSP. Need to precisely describe procedures in the context of&nbsp; SR/=
SR-TE LSP and applicability of RFC 4379, 6424.<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">4) Whether the document is ready to be considered fo=
r WG adoption
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">&nbsp;&nbsp;- It is a good start but I would like to=
 see the concerns addressed before publishing the WG draft.
<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">Thanks,<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;">Pranjal<o:p></o:p></span></p>
<p class=3D"MsoPlainText"><span style=3D"font-size: 12pt; font-family: 'Tim=
es New Roman', serif;"><o:p>&nbsp;</o:p></span></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">-----Original Message-----<br>
From: Loa Andersson [<a href=3D"mailto:loa@pi.nu">mailto:loa@pi.nu</a>] <br=
>
Sent: Wednesday, September 09, 2015 3:00 AM<br>
To: Curtis Villamizar; <a href=3D"mailto:vishwas.manral@gmail.com">vishwas.=
manral@gmail.com</a>; Dutta, Pranjal K (Pranjal); Lizhong Jin;
<a href=3D"mailto:draft-kumarkini-mpls-spring-lsp-ping@tools.ietf.org">draf=
t-kumarkini-mpls-spring-lsp-ping@tools.ietf.org</a>;
<a href=3D"mailto:mpls-chairs@tools.ietf.org">mpls-chairs@tools.ietf.org</a=
><br>
Subject: Fwd: MPLS-RT review of draft-kumarkini-mpls-spring-lsp-ping<o:p></=
o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Resending, Vishwas mail bounced and forgot to inc=
lude the authors and my co-chairs.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">/Loa<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Curtis, Vishwas, Pranjal, and Lizhong,<o:p></o:p>=
</p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">You have be selected as MPLS-RT reviewers for dra=
ft-kumarkini- mpls-spring-lsp-ping.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Note to authors: You have been CC'd on this email=
 so that you can know that this review is going on. However, please do not =
review your own document.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Reviews should comment on whether the document is=
 coherent, is it useful (ie, is it likely to be actually useful in operatio=
nal networks), and is the document technically sound?<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">We are interested in knowing whether the document=
 is ready to be considered for WG adoption (ie, it doesn't have to be perfe=
ct at this point, but should be a good start).<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Reviews should be sent to the document authors, W=
G co-chairs and WG secretary, and CC'd to the MPLS WG email list. If necess=
ary, comments may be sent privately to only the WG chairs.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">If you have technical comments you should try to =
be explicit about what needs to be resolved before adopting it as a working=
 group document, and what can wait until the document is a working group do=
cument and the working group has the
 revision control.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Are you able to review this draft by September 25=
, 2015? Please respond in a timely fashion.<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Thanks, Loa<o:p></o:p></p>
<p class=3D"MsoPlainText">(as MPLS WG chair)<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">-- <o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Loa Andersson&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; email: <a href=3D"mailto:loa@mail01.huawei.com"=
>
<span style=3D"color:windowtext;text-decoration:none">loa@mail01.huawei.com=
</span></a><o:p></o:p></p>
<p class=3D"MsoPlainText">Senior MPLS Expert&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href=3D"mailto:loa@pi.nu">
<span style=3D"color:windowtext;text-decoration:none">loa@pi.nu</span></a><=
o:p></o:p></p>
<p class=3D"MsoPlainText">Huawei Technologies (consultant)&nbsp;&nbsp;&nbsp=
;&nbsp; phone: &#43;46 739 81 21 64<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">-- <o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText">Loa Andersson&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; email: <a href=3D"mailto:loa@mail01.huawei.com"=
>
<span style=3D"color:windowtext;text-decoration:none">loa@mail01.huawei.com=
</span></a><o:p></o:p></p>
<p class=3D"MsoPlainText">Senior MPLS Expert&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <a href=3D"mailto:loa@pi.nu">
<span style=3D"color:windowtext;text-decoration:none">loa@pi.nu</span></a><=
o:p></o:p></p>
<p class=3D"MsoPlainText">Huawei Technologies (consultant)&nbsp;&nbsp;&nbsp=
;&nbsp; phone: &#43;46 739 81 21 64<o:p></o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
<p class=3D"MsoPlainText"><o:p>&nbsp;</o:p></p>
</div>
</div>
</div>
</span>
</body>
</html>

--_000_D22C229D81CEFnaikumarciscocom_--

