Re: [mpls] [Gen-art] review: draft-ietf-mpls-extended-admin-group-05

Eric Osborne <eric@notcom.com> Fri, 25 April 2014 15:28 UTC

Return-Path: <eric@notcom.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38EA71A0572 for <mpls@ietfa.amsl.com>; Fri, 25 Apr 2014 08:28:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.978
X-Spam-Level:
X-Spam-Status: No, score=-1.978 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-0.7] autolearn=unavailable
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kE8n2Rp3yVTC for <mpls@ietfa.amsl.com>; Fri, 25 Apr 2014 08:28:30 -0700 (PDT)
Received: from mail-yh0-f48.google.com (mail-yh0-f48.google.com [209.85.213.48]) by ietfa.amsl.com (Postfix) with ESMTP id F28101A0636 for <mpls@ietf.org>; Fri, 25 Apr 2014 08:28:28 -0700 (PDT)
Received: by mail-yh0-f48.google.com with SMTP id v1so175057yhn.7 for <mpls@ietf.org>; Fri, 25 Apr 2014 08:28:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4/WSSr0/h/jO/uR3jN02snLwL6jRSw65AxfpYheld0Y=; b=k2F9RJ8rFbDSxwXJEivzrpRb6re+y/AghaqPWXsWscOwH0uLOBTEzrKLEsAJfAwghl SvOh+U0J+5mq9dIfOKSTCzhalSAU3q1tWqZxR/i5m2g1VqTz7dqc7b0fL/W15kwLMQ4Q e6yMu0abDSIGB/hv0IZIR8uADVXfP9ejmYfRTWIk6xcCXkMzb9P7qB5omEnnkVT9yboY 197EIK+EcJXJUzEcbLQml+6A/CBIBgiz+AbYidJYWx/Yi53fjO8N+zAHWW/KmG7S3ri8 ouVWKRKuZ5dWemPerYGEMqDuBaok7rV9FN51ufy25a8afqZLyjrVB4KGcqvDSUNLLMfM IySg==
X-Gm-Message-State: ALoCoQkn49UQMazNpl7mebyDK2O/tFrQpGT8J0vYXveLsI0X98GI6eJzqnXHuWumKNEa2+5VvGfl
MIME-Version: 1.0
X-Received: by 10.236.20.194 with SMTP id p42mr12617329yhp.56.1398439702388; Fri, 25 Apr 2014 08:28:22 -0700 (PDT)
Received: by 10.170.60.5 with HTTP; Fri, 25 Apr 2014 08:28:22 -0700 (PDT)
In-Reply-To: <535A7903.2070704@joelhalpern.com>
References: <53597772.6000401@nostrum.com> <53598854.2010201@joelhalpern.com> <CA+97oKPxMJC2zngqUwfRGCNXtP61rqsoRdCbhLAj+_30dZTVeg@mail.gmail.com> <535A7903.2070704@joelhalpern.com>
Date: Fri, 25 Apr 2014 11:28:22 -0400
Message-ID: <CA+97oKPbtmSz8DLP8v6Xt3wwVNQdC7Qib0duj2orgyXwstGaXw@mail.gmail.com>
From: Eric Osborne <eric@notcom.com>
To: Joel Halpern Direct <jmh.direct@joelhalpern.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/H9ONd2KR2iRJe_OiWmtJGXOR2Cs
Cc: "mpls@ietf.org" <mpls@ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [mpls] [Gen-art] review: draft-ietf-mpls-extended-admin-group-05
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Apr 2014 15:28:34 -0000

Works for me.
So

" The EAG sub-TLV is used in addition to the Administrative Groups
when an operator wants to make more than 32 colors available for
advertisement in a network"

I had gone back and forth with Adrian on language to scope this to a
single LSDB, so as to avoid the discussion of signaling EAG desire in
RSVP or PCEP.  I don't want to add that sort of disclaimer here too,
as it makes the sentence clunky and unweildy.



eric


On Fri, Apr 25, 2014 at 11:02 AM, Joel Halpern Direct
<jmh.direct@joelhalpern.com> wrote:
> What if instead of "on the link" it is simoply "in the network".  This
> recommend the use of EAG whenever the operators is using more than 32 colors
> across the link.  It thus actually better aligns with avoiding the
> under-claiming issue by suggesting that operators should use the EAG if they
> have more than 32 candidate colors.
>
> Yours,
> Joel
>
> PS: substituting wants for wishes is probably reasonable.  If we talk about
> network-wide you might even be able to us "intends".
>
>
> On 4/25/14, 10:06 AM, Eric Osborne wrote:
>>
>> Hi Joel-
>>
>>    Thanks for the review.  On your minor issue:
>> ---
>>   I believe it is more accurate to say that it is to be used "when a
>> node wishes to advertise colors for a link which are not represented
>> in the first 32 bits of the color mask."  The node may only wish to
>> advertise colors 7 and 60, but that will require the EAG.
>> ---
>>
>> I see your point, but I'm having trouble coming up with obvious text.
>> Deciding which colors are represented in a color mask is up to the
>> operator, which means it would have to say something like
>>
>> "when a node wishes to advertise colors for a link which the operator
>> has defined to be outside the first 32 bits of the color mask".
>>
>> but this would be the only use of 'color mask' in the document, and
>> it's not one I've seen used in any other docs around link coloring.
>>
>> The whole sentence you refer to is:
>>
>> " The EAG sub-TLV is used in addition to the Administrative Groups
>> when a node wishes to advertise more than 32 colors for a link."
>>
>> If I rephrased it as
>>
>> " The EAG sub-TLV is used in addition to the Administrative Groups
>> when an operator wants to make more than 32 colors available for
>> advertisement on a link"
>>
>> would that do it?
>> s/wishes/wants/ while I'm here.
>>
>>
>>
>> eric
>>
>>
>> On Thu, Apr 24, 2014 at 5:55 PM, Joel M. Halpern <jmh@joelhalpern.com>
>> wrote:
>>>
>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>> Gen-ART, please see the FAQ at
>>>
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>
>>> Please resolve these comments along with any other Last Call comments
>>> you may receive.
>>>
>>> Document: draft-ietf-mpls-extended-admin-group-05
>>>      Extended Administrative Groups in MPLS-TE
>>> Reviewer: Joel M. Halpern
>>> Review Date: 24-April-2014
>>> IETF LC End Date: 06-May-2014
>>> IESG Telechat date: N/A
>>>
>>> Summary: This document is ready for publication as a Proposed Standards
>>> RFC
>>>
>>> Major issues: N/A
>>>
>>> Minor issues:
>>>      I believe that the description of when to use this EAG is slightly
>>> misleading.  The text says that EAG is to be used "when a node wishes to
>>> advertise more than 32 colors for a link."  I believe it is more accurate
>>> to
>>> say that it is to be used "when a node wishes to advertise colors for a
>>> link
>>> which are not represented in the first 32 bits of the color mask."  The
>>> node
>>> may only wish to advertise colors 7 and 60, but that will require the
>>> EAG.
>>>
>>> Nits/editorial comments: N/A
>>>
>>> _______________________________________________
>>> mpls mailing list
>>> mpls@ietf.org
>>> https://www.ietf.org/mailman/listinfo/mpls