[mpls] Warren Kumari's No Objection on draft-ietf-mpls-flow-ident-06: (with COMMENT)

Warren Kumari <warren@kumari.net> Mon, 08 January 2018 23:44 UTC

Return-Path: <warren@kumari.net>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id A7CAB1201F2; Mon, 8 Jan 2018 15:44:35 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Warren Kumari <warren@kumari.net>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-mpls-flow-ident@ietf.org, draft-ietf-mpls-flow-ident@ietf.org, mpls-chairs@ietf.org, Loa Andersson <loa@pi.nu>, mpls-chairs@ietf.org, loa@pi.nu, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.68.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151545507568.9472.16895179835870917877.idtracker@ietfa.amsl.com>
Date: Mon, 08 Jan 2018 15:44:35 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/IKess5iVOTE4S2zHRHHeYF-_guc>
Subject: [mpls] Warren Kumari's No Objection on draft-ietf-mpls-flow-ident-06: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 23:44:36 -0000

Warren Kumari has entered the following ballot position for
draft-ietf-mpls-flow-ident-06: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mpls-flow-ident/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Thank you for writing this, I think it is a useful document -- however, it does
have a number of nits which would be nice to address (if you make any other
edits).

Nits:
Section 1.  Introduction
O: "flow identification.The key"
P: "flow identification. The key"
R: missing space

O: performance monitoring of MPLS flows when MPL is used for the encapsulation
of user data packets. P: performance monitoring of MPLS flows when MPLS is used
for the encapsulation of user data packets. R: Typo for MPLS?

O: Indeed it is important that any flow identification technique be invisible
to them and that no remnant of the identification of measurement process leaked
into their network. P: Indeed it is important that any flow identification
technique be invisible to them and that no remnant of the identification of
measurement process leaks into their network. R: Tense / readability.

Section 3.  Loss Measurement Considerations

O: Modern networks, if not oversubscribed, potentially drop relatively
P: Modern networks, if not oversubscribed, generally drop relatively
C: "potentially" makes it sound like this might happen. If a network isn't
oversubscribed it usually won't drop packets.

Section 4.  Delay Measurement Considerations
O: Most of the existing delay measurement methods are active measurement that
depend on the extra injected test packet to evaluate C: I think that this
should be "active measurements" or "active methods". I'm also confused by the
singular of "packet".

O: Also, for injected test packets, these may not be co-routed with the data
traffic due to ECMP, or various link aggregation technologies all of which
distribute flows across a number of paths at the network, or data-link and
hence at the physical layer. C: This sentence is a run on / really confusing. I
know what you are trying to say, but this doesn't communicate it well. Perhaps
"Due to ECMP (or link aggregation techniques) injected test packets may
traverse other links than the data traffic."? Still not great, but I think
easier to parse.

Section 5.  Units of identification

O: In particular note that there may be a need to impose identify at several
different layers of the MPLS label stack. P: "identity" (or perhaps
"identification"?)

O: Such fine grained resolution may be possible by deep packet inspection, but
this may not always be possible, or it may be desired to minimize processing
costs by doing this only in entry to the network, and adding a suitable
identifier to the packet for reference by other network elements. C: This feels
like a run on. Also I *think* it is "fine-grained" and "on entry to the
network" (nits)

O: This allows for the case of instrumenting multiple LSPs operate between the
same pair of nodes. P: This allows for the case of instrumenting multiple LSPs
operating between the same pair of nodes. C: Readability.