Re: [mpls] working group adoption poll on draft-sitaraman-mpls-rsvp-shared-labels

Hi Pavan,

Sorry for the delay in response. Please see inline:

> -----Original Message-----
> From: Vishnu Pavan Beeram [mailto:vishnupavan@gmail.com]
> Sent: Monday, October 23, 2017 10:49 PM
> To: Dongjie (Jimmy) <jie.dong@huawei.com>
> Cc: Loa Andersson <loa@pi.nu>; mpls@ietf.org; <rtg-ads@ietf.org>
> <rtg-ads@ietf.org>; draft-sitaraman-mpls-rsvp-shared-labels@ietf.org;
> mpls-chairs@ietf.org
> Subject: Re: [mpls] working group adoption poll on,
> draft-sitaraman-mpls-rsvp-shared-labels
> 
> Jie, Hi!
> 
> Thanks for the review and for the support. Please see inline for responses
> (prefixed VPB).
> 
> Regards,
> -Pavan
> 
> On Wed, Oct 18, 2017 at 11:18 AM, Dongjie (Jimmy) <jie.dong@huawei.com>
> wrote:
> > Hi Loa,
> >
> > I've read this document and think it provides a useful function for reducing the
> data plane state of RSVP-TE LSPs. Thus I support the adoption.
> >
> > I concur with Lou's concern about the TE bandwidth/tspec/rspec processing,
> the impact of shared label on this needs to be specified.
> 
> [VPB] Please see if my response to Lou adequately addresses your concern.

The proposed text about the mapping between shared label and the bandwidth reservations would be a good start, and maybe the consequence of the reservation aggregation can also be described.

> >
> > I also have some concerns about the automatic delegation process described
> in section 5.3, maybe I need to reread it, but it seems that in some cases the
> mechanism may not result in an appropriate set of delegation nodes. And what
> would happen if the ETLD value in the received PATH message is bigger than the
> maximum number of labels this node can handle? It seems this case was not
> covered in section 5.3.
> 
> [VPB] Section 5.3.1 says --
> "The ETLD MUST be decremented at each non-delegation transit hop by either 1
> or some appropriate number based on the limitations at that hop."
> 
> The "limitations at that hop" reference is not necessarily limited to the
> "outbound limitation", it could include the "read limitation" as well. Consider a
> transit hop that can read only 6 labels. If this hop receives an ETLD of 8 from the
> previous-hop, then it could adjust the outgoing ETLD to 5 (thus ensuring that it
> can never receive more label-stack-entries than it can read).

Thanks for the explanation. Yes both the send limitation and read limitation need to be taken into consideration. So in many cases decrement by some number other than 1 would be needed. 

Maybe it is worth mentioning that for transit nodes, the ETLD it sent is determined by both the received ETLD from previous hop and its read and send limitation in label processing?

Another point is the ETLD is defined in HOP_ATTRIBUTES subobject, which means the transit node will add a new ETLD Attributes TLV for itself, rather than modifying the ETLD attribute it received from the previous hop. Some update to the description about the ETLD manipulation may be needed to reflect this. 

I think all of the above can be done after the adoption. 

Best regards,
Jie

> 
> >
> > It would be great if the above concerns could be considered either before or
> after the adoption.
> >
> > Best regards,
> > Jie
> >
> > -----Original Message-----
> > From: mpls [mailto:mpls-bounces@ietf.org] On Behalf Of Loa Andersson
> > Sent: Saturday, October 14, 2017 11:20 PM
> > To: mpls@ietf.org
> > Cc: <rtg-ads@ietf.org>;
> > draft-sitaraman-mpls-rsvp-shared-labels@ietf.org; mpls-chairs@ietf.org
> > Subject: [mpls] working group adoption poll on
> > draft-sitaraman-mpls-rsvp-shared-labels
> >
> > Working Group,
> >
> > This is to start a two week poll on adopting
> > draft-sitaraman-mpls-rsvp-shared-labels-02 as a MPLS working group
> document.
> >
> > Please send your comments (support/not support) to the mpls working group
> mailing list (mpls@ietf.org). Please give a technical motivation for your
> support/not support, especially if you think that the document should not be
> adopted as a working group document.
> >
> > There are three IPR disclosures (though one disclosure seems to be an
> > update) against this document.
> >
> > All the authors have stated on the MPLS wg mailing list that they are
> > unaware of any other IPRs that those that has been disclosed
> >
> > The working group adoption poll ends October 29, 2017.
> >
> > /Loa
> > mpls wg co-chair
> > --
> >
> >
> > Loa Andersson                        email: loa@pi.nu
> > Senior MPLS Expert
> > Huawei Technologies (consultant)     phone: +46 739 81 21 64
> >
> > _______________________________________________
> > mpls mailing list
> > mpls@ietf.org
> > https://www.ietf.org/mailman/listinfo/mpls
> >
> > _______________________________________________
> > mpls mailing list
> > mpls@ietf.org
> > https://www.ietf.org/mailman/listinfo/mpls