[mpls] MIB Dr. review of draft-ietf-tp-linear-mib-09

Joan Cucchiara <jcucchiara.ietf@gmail.com> Sat, 08 October 2016 00:53 UTC

Return-Path: <jcucchiara.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED1BD1295DD; Fri, 7 Oct 2016 17:53:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3hovXqhpD9Wm; Fri, 7 Oct 2016 17:53:19 -0700 (PDT)
Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43C60129604; Fri, 7 Oct 2016 17:53:14 -0700 (PDT)
Received: by mail-wm0-x230.google.com with SMTP id b201so70474600wmb.0; Fri, 07 Oct 2016 17:53:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=Ba00RPDfJCJ/ddEcj/h2syhz2BpJlIYiQziwwIVoDhA=; b=J8Ok6RPMy0R4AOZ+snNDGGAIUylPgKpTiGkjYW4WhafJond6L4vZCJtHRGQDyTpnad JJlYTAm581XUyWWQtySvMRgVBDjhHMFEUyWcw93EN7HIsFPBfjl9dE3EWLSFBl5AGIxX b0CQxlojxAduXHaIK3zY2gXTvY47EDPey8R+5gBe22MlGdzvwlzAxPpo9kSOE1emTkeC U4f3o5pxXdPAdwUdc4JhbqI+LsULi1Q8XZVbImwgVl6bm3xRTq/6MUJhAmMirlPZXWl3 R4DPhnXf9tF0QXqmrIU0BxDWgK83O0SFLGI9+mLRn/S5meqAU7SqkJ+297NrEsp+ubXO oDxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Ba00RPDfJCJ/ddEcj/h2syhz2BpJlIYiQziwwIVoDhA=; b=A6a8dqMY9F7WJNOs6XjjdXO8/pNVWovZUAzb9AZ1yPhjuLUUTkgK7K4uaOUflVWKEx LzjhKxy2VEuNUcVyFLOXe/iCQQM+j3Iqq4h4te0OYw2ICRzReQhMX9AiZ6R+FKl3WyGT amlCgrC8FKhWY6fALo+V8FyOQPRkmUMkTTR1NtgiLtmxZgwsAIIuMejS9tqA502urWBO 48I28t9giQum3s5Gt7kL8lh0PYvndzCcaloULaBIhimVMxtDZ0IkBykHOj6sYR6LeFOe VkP9FBZMl+YwftP+ugYEoCqWC3NuhN8zPMXvhsQ4sBdCaPhJp5ksQBtJ9XQPfZM6yROW 9msw==
X-Gm-Message-State: AA6/9RkdZADJV7GHPptgK+2DGmBEIN7rCAWzTXbH+abJUJob/7P7dJZxkDeJbdariMNYV54tPY1JfT5998SqcA==
X-Received: by 10.28.38.131 with SMTP id m125mr880042wmm.133.1475887992849; Fri, 07 Oct 2016 17:53:12 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.80.181.133 with HTTP; Fri, 7 Oct 2016 17:53:12 -0700 (PDT)
From: Joan Cucchiara <jcucchiara.ietf@gmail.com>
Date: Fri, 07 Oct 2016 20:53:12 -0400
Message-ID: <CANSkkOmk8+DP-daKiDMWBsTGOw-AG8NvJ+7kNc8RNwdVLOE_uA@mail.gmail.com>
To: Loa Andersson <loa@pi.nu>, mpls@ietf.org, draft-ietf-mpls-tp-linear-protection-mib@ietf.org, mpls-chairs@ietf.org, mib-doctors@ietf.org
Content-Type: multipart/alternative; boundary="94eb2c03f04e8acd11053e4ff3bc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/J7BEaJOWvVwb-1gLueglPTyM5Nc>
Cc: Benoit Claise <bclaise@cisco.com>
Subject: [mpls] MIB Dr. review of draft-ietf-tp-linear-mib-09
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Oct 2016 00:53:21 -0000

Authors,

Thank you for addressing the comments so thoroughly, and especially for
clarifying the example in section 7.    Much appreciated.

The MIB compiles with smilint and smicngPRO.   Comments are below.

Thank you,
-Joan

Comments:
----------------

1) Section 6.1 Relationship to the MPLS OAM Maintenance Identifiers MIB
Module

   "The mplsLpsMeConfigTable entry is extended by the entry in the
   mplsOamIdMeTable defined in [RFC7697]."

The above statement is backwards....think the intention is to say something
like:
Entries in the mplsOamIdMeTable [RFC7697] are extended by entries in the
mplsLspMeConfigTable.

2) later in this same section, section 6.1

   "An entry of this table is related to a single entry in
mplsOamIdMeTable."

The above is confusing because you've already discuss the sparse augments
relationship.  Please remove
the above sentence.


MIB Module
------------
3)  mplsLpsConfigIndexNext  -   please rename to
mplsLpsConfigDomainIndexNext.
Since this scalar is only used for the mplsLpsConfigDomainIndex index's
values, the name should reflect that.
NOTE:  this name change should be propagated elsewhere in the draft.
Please do a search and replace.

4) mplsLpsConfigDomainIndex  (editorial)
  "Managers should..."

s/Managers/Operators/


5) mplsLpsConfigCommand
Why is there NO DEVAL?   Wouldn't "noCmd" be an appropriate DEFVAL?


6) mplsLpsConfigRowStatus DESCRIPTION clause

RowStatus objects reflect the status of the Row, not a determination of
whether or not values
are "appropriate".  Please remove the last sentence of this DESCRIPTION:

         "...An entry may not exist in the active state unless all
          objects in the entry have an appropriate value."


7)  mplsLpsConfigDomainIndex and mplsLpsMeConfigDomain

Since MIBs often get stripped out of RFCs, the relationship between the
mplsLpsConfigDomainIndex and
the mplsLpsMeConfigDomain needs to be included in the MIB Module itself.

Both DESCRIPTION clauses need to be updated to describe the relationship
between these objects.   Verbage such as "When the
value of mplsLpsConfigDomainIndex is the same as the value of
mplsLpsMeConfigDomain, that means..." and then explain what
this means.

8)  mplsLpsMeConfigDomain DESCRIPTION (editorial)
         "This object holds the value of protection domain index wherein
          this ME included in.

s/included in/is included/

---