[mpls] Re: Secdir last call review of draft-ietf-mpls-mna-usecases-12

Yaron Sheffer <yaronf.ietf@gmail.com> Fri, 13 September 2024 15:50 UTC

Return-Path: <yaronf.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A22F4C151993; Fri, 13 Sep 2024 08:50:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.005
X-Spam-Level:
X-Spam-Status: No, score=-2.005 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jK9eDLDLJpUL; Fri, 13 Sep 2024 08:50:13 -0700 (PDT)
Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA3B7C15152C; Fri, 13 Sep 2024 08:50:13 -0700 (PDT)
Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a8d2b4a5bf1so295439166b.2; Fri, 13 Sep 2024 08:50:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726242612; x=1726847412; darn=ietf.org; h=content-transfer-encoding:cc:to:references:message-id:in-reply-to :thread-topic:subject:from:date:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WA+dt3/6OWmTj4NRocaFYRlMzcPthBpfqVPfaZfJ0j4=; b=KLaqoBu/F6m5+XIL3pXd+sI0l+fveMvEd4IgCXUikeO/ty0pRWkJo3IgjNa8/3SF4r aCpc2yRm066+5bINlTb7ar7wrH6V1hmfGIgpullE09igYdEsuNri5/FppwPAGqMhRXBz Na1Fh+3gqT4zA+GcWHCgOm0a6oH9dH7l6/qukyc4PKbm2Hi+pLthrn4q2S5NFUNFl1N2 d/74vOCm+MJdB4XFzk5IY5ohfNUyx0kKnxhkXnVWOxotd/idAxkovYVyTTEdGL8At8r6 5qmqkv2+OV+6UP6KUVPjKeW4PgEwarnadFDIo+K/A0ADLoDssTJ9vovhvijAmjr+TXx1 O0ug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726242612; x=1726847412; h=content-transfer-encoding:cc:to:references:message-id:in-reply-to :thread-topic:subject:from:date:mime-version:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WA+dt3/6OWmTj4NRocaFYRlMzcPthBpfqVPfaZfJ0j4=; b=pg8d7hX4kXXeDyK5u7A+v1M03FzclrB8Cx8PURYzuWX46Z19TxDaWtbH5lcHpVeGnI 82Uxus94rpK+78PdUwX5yaD3hE9NORJdAQIXZ/4oswH5/SxphNQlguXzLzWYn52vNtKn 3A0of2DkbUoMoHtL6pmifiiY6V7EgOK1FCgXxKSqVz6GxBgZFkoH/iK5ji4Ml+CjjXof t99gfgzjWRymoYg0QSDzcoItSNiDcd3OjRQVI24kCPO0ZkoS4Yl/VCNcqttaaRQH4osm 46VOWU2/yRDkjjCTtOnqBiI++JxH3lstsSXOtEyLcZxJEjrZFCqWThZ4TeGB171bdHAd GQOw==
X-Forwarded-Encrypted: i=1; AJvYcCUrg19bdQN2HlH67r2hT/pD49MiBWYz+JL7qRAKZ1/c8qSO1ZbpzxtYXXARoFCTieET5i/jDqUoDN+OOEWzkBDfmDwbF65/vYq+c2Whpuzn8A==@ietf.org, AJvYcCVCxk6MA9BCVKSOCYzL+RKJ+MufU8h6TlFWaIYYv4Ry/5gMbUU8n4igtUciQV+2RdiQ3Uo8QZCWRYk2@ietf.org, AJvYcCW9Igi+VGFr09UDB3IPq/S387CHE1cUxLzZxkHXZkaO3xbgyng9yc2IUPJTR5t84ISjAhdvTA==@ietf.org
X-Gm-Message-State: AOJu0YzyhRtjn4nvPFYFLbosaBMDka+urAULPjNEgft2CkZbdJZzkVpG quz9j+VW2m8IUkeXSO93JEYP6OnTG/HPZxWFM3Q1QNm8WVHC6VziEe31aPWK
X-Google-Smtp-Source: AGHT+IHTZp58XrCJqQbuurfx+NFXV+NEr99ibIoD3H2JPwym7W9Kalo3/HT5aUcb+5Vw+OSdfMfQjQ==
X-Received: by 2002:a17:907:3f9b:b0:a8d:4b02:3351 with SMTP id a640c23a62f3a-a90296eac34mr748075066b.50.1726242611093; Fri, 13 Sep 2024 08:50:11 -0700 (PDT)
Received: from macos-F7LQR2FV6V (IGLD-84-229-146-74.inter.net.il. [84.229.146.74]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25c72e56sm877886766b.124.2024.09.13.08.50.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Sep 2024 08:50:10 -0700 (PDT)
MIME-Version: 1.0
Date: Fri, 13 Sep 2024 18:50:07 +0300
From: Yaron Sheffer <yaronf.ietf@gmail.com>
Thread-Topic: Re: Secdir last call review of draft-ietf-mpls-mna-usecases-12
In-Reply-To: <CA+RyBmU_FyeRedH+_eWb2b+UNO11OkSo6tMbL_eACfHmxqNDrg@mail.gmail.com>
Message-ID: <40187EC2-9B34-854A-AA91-F541B951ED86@hxcore.ol>
References: <172623476741.3388439.10172931974011368249@dt-datatracker-68b7b78cf9-q8rsp>,<CA+RyBmU_FyeRedH+_eWb2b+UNO11OkSo6tMbL_eACfHmxqNDrg@mail.gmail.com>
To: Greg Mirsky <gregimirsky@gmail.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"
Message-ID-Hash: 4YHXJM656DZITIMFONIJ76E37J4B2TZI
X-Message-ID-Hash: 4YHXJM656DZITIMFONIJ76E37J4B2TZI
X-MailFrom: yaronf.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-mpls.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "secdir@ietf.org" <secdir@ietf.org>, "draft-ietf-mpls-mna-usecases.all@ietf.org" <draft-ietf-mpls-mna-usecases.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [mpls] Re: Secdir last call review of draft-ietf-mpls-mna-usecases-12
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/JFB0Kfwnv-8Q4Y6TPOZL8GBR1FA>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Owner: <mailto:mpls-owner@ietf.org>
List-Post: <mailto:mpls@ietf.org>
List-Subscribe: <mailto:mpls-join@ietf.org>
List-Unsubscribe: <mailto:mpls-leave@ietf.org>

Hi Greg,

 

As I said in my review: if the authors have verified that the security considerations in the Framework document provide good coverage of the use cases that you describe here then Yes.

 

I am not an MPLS expert and certainly not an MPLS security expert, so I cannot contribute much towards this analysis.

 

Thanks,

                Yaron

 

From: Greg Mirsky <gregimirsky@gmail.com>
Date: Friday, 13 September 2024 at 17:24
To: Yaron Sheffer <yaronf.ietf@gmail.com>
Cc: secdir@ietf.org <secdir@ietf.org>, draft-ietf-mpls-mna-usecases.all@ietf.org <draft-ietf-mpls-mna-usecases.all@ietf.org>, last-call@ietf.org <last-call@ietf.org>, mpls@ietf.org <mpls@ietf.org>
Subject: Re: Secdir last call review of draft-ietf-mpls-mna-usecases-12

Hi Yaron,

thank you for your comments and suggestion adding the reference. Would the following address your concern:

NEW TEXT:

6.  Security Considerations

 

   This document introduces no new security considerations beyond those

   outlined in Section 7 of [I-D.ietf-mpls-mna-fwk].

 

Regards,

Greg

 

 

On Fri, Sep 13, 2024 at 6:39AM Yaron Sheffer via Datatracker <noreply@ietf.org> wrote:

Reviewer: Yaron Sheffer
Review result: Has Issues

This document reviews multiple use cases for a new extension to MPLS, Network
Action Indicators.

The entirety of the Security Considerations section reads:

This document introduces no new security considerations.

I am not convinced, and I think an explanation is needed on why MNA are more or
less susceptible to attacks than the way these use cases are signaled today.
That *could* lead to discussion of new security controls.

Specifically I would recommend to address the more difficult migration and
coexistence scenarios listed in Sections 3 and 4.

In fact, even a reference to
https://www.ietf.org/archive/id/draft-ietf-mpls-mna-fwk-10.html#name-security-considerations" rel="nofollow">https://www.ietf.org/archive/id/draft-ietf-mpls-mna-fwk-10.html#name-security-considerations
may do the job, assuming the authors believe the Security Considerations over
in that document cover the use cases listed here.