Re: [mpls] Updated rev -08 posted [Re: Éric Vyncke's No Objection on draft-ietf-mpls-ldp-yang-07: (with COMMENT)]

"Eric Vyncke (evyncke)" <evyncke@cisco.com> Fri, 28 February 2020 07:13 UTC

Return-Path: <evyncke@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F14603A11D4; Thu, 27 Feb 2020 23:13:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.6
X-Spam-Level:
X-Spam-Status: No, score=-9.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=f+jAgFJc; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=I4v8Naen
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AUrccbsK5ByT; Thu, 27 Feb 2020 23:13:30 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 436863A11D3; Thu, 27 Feb 2020 23:13:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4472; q=dns/txt; s=iport; t=1582874010; x=1584083610; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=VLP3eUZTLBOGcih9AOFVLqY9i8thneia9aanoXtJYo8=; b=f+jAgFJcD7NYVJUGKxLYG35xfC581IWgdBw+NyThxMMqpKGAFVzXa2TT tp5rySTGMoyLD4b+avq+x1QNqKcC0a6ok1/oDdWSK25FxqkHqfBT6toKQ VN9DFXxKGUn9+13KFbF6sX0nei9aw9+vlBcaHZmyHiHJ23l3+4mvaco9Z 0=;
IronPort-PHdr: =?us-ascii?q?9a23=3AQ+mwVh06NS+TcsrusmDT+zVfbzU7u7jyIg8e44?= =?us-ascii?q?YmjLQLaKm44pD+JxKHt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8RVgOIdJSw?= =?us-ascii?q?dDjMwXmwI6B8vQBFPqKvXpYgQxHd9JUxlu+HToeUU=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DNBQB8vFhe/4UNJK1mHAEBAQEBBwE?= =?us-ascii?q?BEQEEBAEBgXuBVFAFgUQgBAsqhBSDRgOKZYJfiWOOMYJSA1QJAQEBDAEBLQI?= =?us-ascii?q?EAQGEQAIXgXEkOBMCAw0BAQUBAQECAQUEbYU3DIVjAQEBAQMSEREMAQE3AQs?= =?us-ascii?q?EAgEIEQMBAgMCHwcCAgIfERUFAwgCBAENBSKDBIJLAy4BowICgTmIYnWBMoJ?= =?us-ascii?q?/AQEFhRUNC4IMCYEOKowlGoFBP4ERJyCCTD6CG4IwgxEygiyNcII6O55FLEQ?= =?us-ascii?q?KgjyNHoURhDYcgkmIG5BKg0yLJIsqkB0CBAIEBQIOAQEFgWkigVhwFWUBgkF?= =?us-ascii?q?QGA2OHTiDO4RZhXx0gSmOCwEB?=
X-IronPort-AV: E=Sophos;i="5.70,493,1574121600"; d="scan'208";a="438691934"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 28 Feb 2020 07:13:29 +0000
Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by alln-core-11.cisco.com (8.15.2/8.15.2) with ESMTPS id 01S7DSdP027816 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 28 Feb 2020 07:13:28 GMT
Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 28 Feb 2020 01:13:28 -0600
Received: from xhs-aln-002.cisco.com (173.37.135.119) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 28 Feb 2020 01:13:27 -0600
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 28 Feb 2020 01:13:27 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdWiiltfnbik4CWjH1o2oe8xKsBiBLGTKq7XkKMlrJd7nbMafMwVLahovcjOobqKdLbA2Vn6KypaBmJlbAlmvThTOEO7UtQoblYHlQ2zze4wHPfrQwxveix+GtEx7J2/Sza3hSd9j1QTf36vaVxqxSsvv3tRiyiibi67cBbaGvFe9QWC2O4ruH/eQqGpn4++Xx/0xMjSuabULlzGXc/0h/Xrnq66zWVznqns9AXbRk2W6lT+ZUNiwQ6SV4thaQtwKw/ztzXj9p89ZF6BCakFmc6EjoG5qeUO7VEdFE9QgIBxg2AGpF1FmV7ohHr4EVbsZqURSEgpqIRi8RoR8Cy0PQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLP3eUZTLBOGcih9AOFVLqY9i8thneia9aanoXtJYo8=; b=NY2qxqesyx8TJeR7eR0t+2LhTPDDHZhLhWJOUSYmgOQYs4UotkJeFAVQamUmnQaxQJX1z8ht06NH/7fqB1ezVVeSNJiVrNdSk0AV/gFDbowZ6RHPZhyJwp0HEjOZFwUXWs3iJBEK8neE28a0rAg0lsCut0FXWlgR2ZV+vW0NxKx9KcMgQ3aoyFT1NfW3Ai5fTCegbCegFL5jUPL52gFUEDzEIPQ8CtRrYFDN8U2mIYWvwrLEtFUWBZy5bWqm8sGbxbhgY1WdIjdn/WzftCAenu67moK3YTK2ahMEYPNKHc0Hny7XCsHGk3g7nIg6+J3eCcV2uiTCHY1OAP5TAHFm6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VLP3eUZTLBOGcih9AOFVLqY9i8thneia9aanoXtJYo8=; b=I4v8Naenn9OYpe8uLEv0qcKHxpPwXkFgdmwIpVOezhLbMv3VL7E1R+yeurZ7lI6qHAMs4XtVY1y2Q2EY1TtDz3AMEFIgaEhHfhiKxKVVIxX6pjT+iIoRUOaKwWndt0UdriWxidZbg9mRWgfKUa6lvs9oTyEmdyn+KghjzZeOlJ8=
Received: from DM5PR11MB1753.namprd11.prod.outlook.com (2603:10b6:3:10d::13) by DM5PR11MB1243.namprd11.prod.outlook.com (2603:10b6:3:8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Fri, 28 Feb 2020 07:13:26 +0000
Received: from DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::680d:e22e:72d5:67ca]) by DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::680d:e22e:72d5:67ca%3]) with mapi id 15.20.2772.012; Fri, 28 Feb 2020 07:13:25 +0000
From: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
To: "Kamran Raza (skraza)" <skraza@cisco.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-mpls-ldp-yang@ietf.org" <draft-ietf-mpls-ldp-yang@ietf.org>, Tarek Saad <tsaad.net@gmail.com>, Nicolai Leymann <n.leymann@telekom.de>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: =?utf-8?B?VXBkYXRlZCByZXYgLTA4IHBvc3RlZCBbUmU6IMOJcmljIFZ5bmNrZSdzIE5v?= =?utf-8?B?IE9iamVjdGlvbiBvbiBkcmFmdC1pZXRmLW1wbHMtbGRwLXlhbmctMDc6ICh3?= =?utf-8?Q?ith_COMMENT)]?=
Thread-Index: AQHV7fG8569iomnCM069YUu39CA/7agwQgKA
Date: Fri, 28 Feb 2020 07:13:25 +0000
Message-ID: <9EFFDB7C-EB0C-40D9-96DE-B03B849EAD35@cisco.com>
References: <D87ED156-5BF8-4E56-A5DF-BD4C17A4EEA0@cisco.com>
In-Reply-To: <D87ED156-5BF8-4E56-A5DF-BD4C17A4EEA0@cisco.com>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.22.0.200209
authentication-results: spf=none (sender IP is ) smtp.mailfrom=evyncke@cisco.com;
x-originating-ip: [2001:420:c0c1:36:a9f4:c451:2f33:1823]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 68f59898-7653-4dc3-bf6a-08d7bc1db435
x-ms-traffictypediagnostic: DM5PR11MB1243:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR11MB1243F758B7A29EC3B4ACE45FA9E80@DM5PR11MB1243.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0327618309
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(199004)(189003)(6512007)(64756008)(33656002)(86362001)(66476007)(76116006)(71200400001)(15650500001)(2616005)(36756003)(6486002)(91956017)(53546011)(66946007)(478600001)(6506007)(224303003)(66556008)(186003)(110136005)(54906003)(81156014)(5660300002)(4326008)(81166006)(316002)(8936002)(2906002)(66446008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR11MB1243; H:DM5PR11MB1753.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: NwuZxfbjuyfVv70ms9PYnDH60mP1vizb5Z4/LURqm/TWA5iMYxdSrphnKRndfGANbGj1uRMaasdgWwYin/H9YW15qZ5olZy2Uc1rfnbkobS4uRFptWZle0QdLJsvFIQntgxr3niKPoEispwz95G24tXFeCKVrhOFe0IoXN7plh873hoA/ojPD70elGVpgLK9HZ/QTLovUt3FFC5tUzOXG4u7Mt2FD4lNcoGQp4GumLov873mU6ompocwDtWqEYnbgHSJrT8VZwSoEewMs52+ws4L/MURnly6n1b9LqR8xu7aHSBh/v4KL7qxsNyTipW/nTQOAwNQgBFdhETc+JdnF9GU0l6MToT6NCI+te+txgxESaEyvGI2aypoYE6b3X2h02hFBofLEBQpKRioxRMnV2LlG0H+KuQY0TpkOEAtYtYBvtAJsOxBIIyYrw9J/ZBi
x-ms-exchange-antispam-messagedata: KpoS/ze0AN++y8XuoCvUtN+kEpG9X8iXeO9g1C53Bsm/Hd8O0UYGr19pdjhpND4YLjfVeFhLohVHkJI8WHTFznX7fF77yqvpcvvpKnu4k83Gw7gdsT99nWCDt8RARmB00pjIFKZPHyg/elUyf3BDDa+MbowgT6Z82l6ro4M4Zk5gqFP+fX+GpGvIlU5WQuum15YH5eu8oDTqp3kopb0fWg==
Content-Type: text/plain; charset="utf-8"
Content-ID: <4ABDE9229EF25F4D89DFA91F8EF81B73@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 68f59898-7653-4dc3-bf6a-08d7bc1db435
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2020 07:13:25.9249 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nmz53e5Yov0jcN9cOk91HOCGpm+1ilQtmLbqBxpBtNrNV/t/E0fcZJ99aH4HJwBxKvcWLtt1NXsqjim9mgdMVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1243
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com
X-Outbound-Node: alln-core-11.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/Jr8J0-GiOeWeQ79C3YaPsCjdbxg>
Subject: Re: [mpls] =?utf-8?q?Updated_rev_-08_posted_=5BRe=3A_=C3=89ric_Vynck?= =?utf-8?q?e=27s_No_Objection_on_draft-ietf-mpls-ldp-yang-07=3A_=28with_CO?= =?utf-8?q?MMENT=29=5D?=
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2020 07:13:32 -0000

Thank you for addressing my COMMENTs

-éric

-----Original Message-----
From: "Kamran Raza (skraza)" <skraza@cisco.com>
Date: Friday, 28 February 2020 at 05:44
To: Eric Vyncke <evyncke@cisco.com>om>, The IESG <iesg@ietf.org>
Cc: "draft-ietf-mpls-ldp-yang@ietf.org" <draft-ietf-mpls-ldp-yang@ietf.org>rg>, Tarek Saad <tsaad.net@gmail.com>om>, Nicolai Leymann <n.leymann@telekom.de>de>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>rg>, "mpls@ietf.org" <mpls@ietf.org>
Subject: Updated rev -08 posted [Re: Éric Vyncke's No Objection on draft-ietf-mpls-ldp-yang-07: (with COMMENT)]

    Eric, 
    Thanks for your review and comments.
    We have posted a new rev -08 that takes care of your comments and comments from other IESG reviewers.
    On behalf of authors, please see further inline [skraza]:
    
        
        
        ----------------------------------------------------------------------
        COMMENT:
        ----------------------------------------------------------------------
        
        Thank you for the work put into this document.
        
        I fully support Ben Kaduk's DISCUSS about IPv6 (about why IPv6 is in the
        extended section 6.1.2).  I would have balloted a DISCUSS if Ben haven't
        balloted before me.
    [skraza]: Please see our response to Ben's review.
        
        Also concerned about Suresh's question about the "rw ipv4 (or ipv6)" in section
        6.2.1. and 6.2.2. and other places. Thank you, though, for the IPv6 example in
        Appendix A.
    
    [skraza]: Fixed. Also, Added more IPv6 in examples.
        
        Answers to my COMMENTs below will be welcome,
        
        Regards,
        
        -éric
        == COMMENTS ==
        
        -- Section 4 --
        Why having the YANG subtrees for IPv4 and IPv6 different order of their
        subtrees in ietf-mpls-ldp/mpls-ldp/address-families/ipv[46] ?
    
    [skraza]: This is due to augmentation and pyang tools puts the augmentation at the very end - this ordering is not controlled by us but the tool.
        
        -- Section 5.1.2 --
        Another difference about IPv4 and IPv6 in the tree: IPv6 has an "enable" leaf
        but IPv4 does not. Why is that ?
        
    [skraza]: IPv4 was/is defacto AFI for LDP and was enabled by default in all implementations. LDPv6 was an add-on and was enabled on demand - hence "enable" is needed here.
    BTW, conversely, a "disable" leaf is provided under ipv4.if someone wants to disable IPv4. 
    
        -- Section 5.2.1.1. --
        In the text "this document recommends an operator to pick a routable IPv4
        unicast address as an LSR Id", what is meant by "routable" ? Globally routable
        ? Domain routable ?
        
    [skraza]: LDP typically works within IGP domain so I'd say IGP routing domain or perhaps just routing domain.
    Added the text in the draft.
     
    
        Also, it is expected that design recommendations are done in a document about
        data model?
     
    [skraza]: Fair point but this LSR-ID topic had been an important one in the context of manageability of LDP, we thought it better to highlight and recommend.