Re: [mpls] RtgDir review: draft-ietf-mpls-lsp-ping-reply-mode-simple-03.txt

Nobo Akiya <nobo.akiya.dev@gmail.com> Sun, 30 August 2015 08:19 UTC

Return-Path: <nobo.akiya.dev@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A54F1A92EA; Sun, 30 Aug 2015 01:19:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IE2ccGySyILi; Sun, 30 Aug 2015 01:19:36 -0700 (PDT)
Received: from mail-lb0-x22b.google.com (mail-lb0-x22b.google.com [IPv6:2a00:1450:4010:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E38041A877C; Sun, 30 Aug 2015 01:19:35 -0700 (PDT)
Received: by lbbtg9 with SMTP id tg9so47127703lbb.1; Sun, 30 Aug 2015 01:19:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=C2N/6acHsL7F8t3EnctdSmn6XFcoFu8pMbqd+V2BxE0=; b=m1SBz8/2nVZvklh2JerNWbYKsHaRqCJR+hbj22BFubDevnuyYPIU/RZcLgeOR+jzfG 8WDRB4bo5twxAfZtXZKDX1Da3eau1f/zOC5+zgZWMXA5KtEzr2H0cHTsICnioFeqP0ON /YeM/5gigGQHhPeKk2b6xdpxvZUGokpEog2cfMoOPBhucZy3+JxrETdw9MBnSgq4m9EK R0M4vuGIAOLgGJnJNXyMKfSpRmu9cw/h8VaDtxkePAdfMOU+a1YuK6SOBrvTc/cV4z02 TyTvprs/LZK4sCBe931JPUmyXkMiHQ3oAqT6z3PLxzEvF4bQ8PAr0COB6338OGRwpInW RV+g==
MIME-Version: 1.0
X-Received: by 10.152.25.196 with SMTP id e4mr8087825lag.15.1440922774306; Sun, 30 Aug 2015 01:19:34 -0700 (PDT)
Received: by 10.112.12.198 with HTTP; Sun, 30 Aug 2015 01:19:34 -0700 (PDT)
In-Reply-To: <1440002992.3391528.360465129.4D684834@webmail.messagingengine.com>
References: <1440002992.3391528.360465129.4D684834@webmail.messagingengine.com>
Date: Sun, 30 Aug 2015 17:19:34 +0900
Message-ID: <CAFqGwGupg+Ts0OUr9+Y+4vg1MmqG_OYZZquf-D98Cq_b6EgiKQ@mail.gmail.com>
From: Nobo Akiya <nobo.akiya.dev@gmail.com>
To: Dan Frost <frost@mm.st>
Content-Type: multipart/alternative; boundary=089e0158cb821c8a81051e82fa8e
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/LFl3ourwKupcpntgMS19CE3ZGPg>
Cc: rtg-dir@ietf.org, mpls <mpls@ietf.org>, "draft-ietf-mpls-lsp-ping-reply-mode-simple@tools.ietf.org" <draft-ietf-mpls-lsp-ping-reply-mode-simple@tools.ietf.org>, rtg-ads@tools.ietf.org
Subject: Re: [mpls] RtgDir review: draft-ietf-mpls-lsp-ping-reply-mode-simple-03.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Aug 2015 08:19:39 -0000

Hi Dan,

Thanks for reviewing this document!

Please see replies in-line with [NOBO].

On Thu, Aug 20, 2015 at 1:49 AM, Dan Frost <frost@mm.st> wrote:

> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft.
> The Routing Directorate seeks to review all routing or routing-related
> drafts as they pass through IETF last call and IESG review, and
> sometimes on special request. The purpose of the review is to provide
> assistance to the Routing ADs. For more information about the Routing
> Directorate, please see
> ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it
> would be helpful if you could consider them along with any other IETF
> Last Call comments that you receive, and strive to resolve them through
> discussion or by updating the draft.
>
> Document: draft-ietf-mpls-lsp-ping-reply-mode-simple-03.txt
> Reviewer: Dan Frost
> Review Date: 19 Aug 2015
> Intended Status: Standards Track
>
> Summary:
>
> I have some minor concerns about this document that I think should be
> resolved before publication.
>
> Comments:
>
> This document addresses an important practical limitation affecting the
> use of LSP Ping in deployed networks today.  It is for the most part
> clearly written and complete, and contains helpful examples.
>
> Major Issues:
>
> No major issues found.
>
> Minor Issues:
>
> - Section 2, last paragraph: "This document adds one Reply Mode value to
> describe the reverse LSP, ...".
>
> This document does not appear to add a Reply Mode value, but rather to
> modify the semantics of the "Reply via Specified Path (5)" Reply Mode,
> as stated at the beginning of Section 3, so this sentence needs
> changing.
>

[NOBO] Thanks for catching that ... left over from previous proposal. I
have updated to:

      This document updates the "Reply via Specified Path (5)" Reply Mode
      to easily indicate the reverse the reverse LSP, and adds one optional
      TLV to describe an ordered list of reply modes.


> - Section 3.1, first paragraph: Suggest adding RFC references for
> associated LSPs, e.g. RFC 5960 for MPLS-TP.
>

[NOBO] Yes that will be helpful to readers, added.


>
> - Section 3, general comment: This document is changing the semantics of
> Reply Mode 5, and in particular changing the case of Mode 5 without a
> Reply Path TLV from invalid to valid.  However, the document does not
> appear to discuss interoperability issues in networks with a mix of
> "old" and "new" LSRs.  This looks like something that should be
> addressed explicitly.
>
>
[NOBO] Good point. I have added a new sub-section to clarify this.

4.1.  Backwards Compatibility with Reply via Specified Path (5) Reply
      Mode

   [RFC7110] has introduced the "Reply via Specified path (5)" Reply
   Mode, and defined that usage of the "Reply via Specified path (5)"
   Reply Mode without also including the "Reply Path TLV" to be invalid.
   This document relaxes this semantic by defining the use of the "Reply
   via Specified path (5)" Reply Mode without the "Reply via Specified
   path (5)" to indicate the reverse LSP.  In other words, what was
   considered invalid is now valid.  If the initiator LSR, which sent an
   MPLS echo request message with the "Reply via Specified path (5)"
   Reply Mode but without including the "Reply Path TLV", receives back
   an MPLS echo reply message with the return code being "Malformed echo
   request received", then the initiator LSR SHOULD assume that the
   responder LSR does not support the mechanism defined in this document.



> - Section 3.1, last paragraph: This paragraph is very confusing and
> either needs to be deleted or completely rewritten.  If, as it appears,
> it is not changing existing requirements for IP addressing of LSP Ping
> packets per RFCs 4379 and 7110, it should just be deleted.
>
>
[NOBO] I believe this text was suggested by someone to be added, but since
this is already described in RFC 7110, I will delete it as suggested.


> - Section 4.1, preference ordering of reply options: The document
> specifies that reply paths are to be preferred according to the order in
> which they appear in the Reply Mode Order TLV.  However, it's not clear
> from this document and RFC 7110 what the order semantics are of
> including a Reply Path TLV with multiple sub-TLVs.  For instance, in
> Section 4.1.1's example, FEC X and FEC Y are listed as different return
> paths.  If they are different, what is their preference ordering and
> where is this defined?
>

[NOBO] That should have been clarified in the RFC 7110, but unfortunately
not. Folks, including myself, assumed that selection is done via walking
the Sub-TLVs from "top to bottom". Do you suggest that we attempt to
clarify this in this document?


> - General comment: It may be valuable for the authors to include a
> Manageability Considerations or similar section to provide guidance to
> implementors on configuration options, defaults, etc., particularly
> given the operational difficulties that led to this document in the
> first place.
>

[NOBO] Good point. I have a Manageability Considerations section.

   Section 2 described the problems which increases the complexity with
   respect to operations and implementations.  In order to to simplify
   operations and to allow for the LSP Ping/Traceroute to function
   efficiently whilst preserving the code simplicity, it is RECOMMENDED
   that implementations allow devices to have configuration options to
   set operator preferred Reply Modes.  For example:

   o  For those operators who are more interested in MPLS echo reply
      packets reaching back to the initiator LSR:

      1.  Reply via an IPv4/IPv6 UDP packet (2)

      2.  Reply via application level control channel (4)

      3.  Reply via Specified Path (5)

   o  For those operators who are more interested in MPLS echo reply
      packets testing the paths related to the forward LSP:

      1.  Reply via Specified Path (5)

      2.  Reply via application level control channel (4)

      3.  Reply via an IPv4/IPv6 UDP packet (2)



>
> Nits:
>
> There are a lot (too many to list here) of minor English grammar
> problems, such as missing articles, throughout the text.  I would
> suggest the editors do a grammatical review pass to clean these up as
> much as possible before the RFC Editor stage.
>

[NOBO] I will have one of the native English speaker do a cleanup.

Again, thanks for reviewing the document Dan. Please let me know what you
would like for the Sub-TLV preference within the Reply Path TLV ... which
is really an issue with RFC 7110.

Regards,
Nobo


>
> Cheers,
> -d
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls
>