IETF Logo Mail Archive

[mpls] Comments on draft-gandhi-spring-ioam-sr-mpls

Tarek Saad <tsaad.net@gmail.com> Mon, 22 July 2019 13:42 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23A8F120297; Mon, 22 Jul 2019 06:42:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oUZJDjK8VhyA; Mon, 22 Jul 2019 06:41:59 -0700 (PDT)
Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 45A041202E7; Mon, 22 Jul 2019 06:41:56 -0700 (PDT)
Received: by mail-qt1-x82b.google.com with SMTP id k10so38579828qtq.1; Mon, 22 Jul 2019 06:41:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :accept-language:content-language:mime-version; bh=ZM0klZnNKdug2CnJyoAg5/FVh5RZ/AOR69B1+uj8dn8=; b=AZn1ubSsfrdbrhqCUwrUMhNIZgl1GBURRU0//GQZprEV1Bi2gI2cDXKSnDKHYISwsh aQEDKxZKT9oO66ZI7Y1w7Hb2XGUJNVsr5fa4ZFCrvZGKHqKM27X6q/jSJH2J5Jz5Mc87 37VAoHLPbqLjdg+laqD29qBcX/x3Msq2KAkDs5oWnEBsQyq/tOTIW+z/78JgdrSi6/zz ArcQ09/A69IhU+k3xYkApSSvt+lElMZLDlPyO6ljD2eUhrn0xXFCyKt/0yRkLVEKsZeZ QINuMVfPxUR3jZjTb4tO++OyKO8B9QPkIRwZyOijWKx5wwaD0UxiCF0SkNOPdgaK7Ipu PvZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:accept-language:content-language:mime-version; bh=ZM0klZnNKdug2CnJyoAg5/FVh5RZ/AOR69B1+uj8dn8=; b=BnbUHPnkDb1eu1YTrU6j4Hcqb8P/vI7kqYxvDkiOWNbGXxr544cwdmtQM/zT6lXTPn p3Y84XtyT+n8oBr/HEaeLy3pajH48Eh3VUCvAUbfwD+sg81NMJZQP8sD7jvScqldbAjZ pztGjqmi3Ym3gNl4JdJEzpnXvaYA2iF3ab+iHM7P3Ca85psDOeaYWHcK6X5KzTv96XH7 CigBv4VDdl1atX/e3C3g0aawpclgYK16Oat89sjdFmm0UYlXrkV6I+fxpn8hgCa3jRlL /ULIcSrF2cjbAKgpR8VK10/ZsfNfS7JTcvL5mavOiCYvct/4THiJ6qs1RxcCmNMQvXPJ uVnw==
X-Gm-Message-State: APjAAAVKZd8HybPVPLLBj9YTjoEYBRNf0yoI9PtNFbUfqejoAMMrnNqt as9nWPh2kuCjLF0zE9yrwH/H5f1i
X-Google-Smtp-Source: APXvYqzeqquaOb6bWaPDd4kLBTBmOxanmVURlDUPbqmgix1nVaZERcQZY49xUadWZzWIY7u5umC/4g==
X-Received: by 2002:a0c:bd91:: with SMTP id n17mr50089291qvg.128.1563802915272; Mon, 22 Jul 2019 06:41:55 -0700 (PDT)
Received: from BYAPR19MB3415.namprd19.prod.outlook.com ([2603:1036:307:293b::5]) by smtp.gmail.com with ESMTPSA id r40sm22636897qtr.57.2019.07.22.06.41.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jul 2019 06:41:54 -0700 (PDT)
From: Tarek Saad <tsaad.net@gmail.com>
To: "draft-gandhi-spring-ioam-sr-mpls@ietf.org" <draft-gandhi-spring-ioam-sr-mpls@ietf.org>
CC: "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: Comments on draft-gandhi-spring-ioam-sr-mpls
Thread-Index: AQHVQJM17/Zw54Sy+kyF0fdYyMqfNA==
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Mon, 22 Jul 2019 13:41:48 +0000
Message-ID: <BYAPR19MB3415B39AB092291FDAE9C035FCC40@BYAPR19MB3415.namprd19.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: multipart/alternative; boundary="_000_BYAPR19MB3415B39AB092291FDAE9C035FCC40BYAPR19MB3415namp_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/AFGC9JBhNi_gQPPze0FIPtzjysk>
Subject: [mpls] Comments on draft-gandhi-spring-ioam-sr-mpls
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jul 2019 13:42:06 -0000

Hi authors,

>From reviewing this draft, have the following comments:
   The ingress node needs to make sure the IOAM TLV does not start with
   a well known protocol type (e.g. 0x4 for IPv4 and 0x6 for IPv6) and
   does not alter the hashing function that uses the IP header.

How the ingress guarantee it does not alter hashing (on any transit LSR) that uses the IP header with inclusion of IOAM?
Most transit MPLS LSR(s) would do deep packet inspection to read up to the IP header so they do proper loadbalancing, I see introducing the IOAM data after the bottom of stack will have implications on ECMP hashing and may break ECMP..

Regards,
Tarek

v2.23.0 | Report a Bug | By Email