[mpls] Genart last call review of draft-ietf-mpls-sr-over-ip-02

Robert Sparks <rjsparks@nostrum.com> Wed, 20 February 2019 15:47 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E817D130E5F; Wed, 20 Feb 2019 07:47:46 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Sparks <rjsparks@nostrum.com>
To: gen-art@ietf.org
Cc: mpls@ietf.org, ietf@ietf.org, draft-ietf-mpls-sr-over-ip.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.91.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <155067766687.31388.18349714938448955572@ietfa.amsl.com>
Date: Wed, 20 Feb 2019 07:47:46 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/M-B0lDdwrdsiW-bfoIL_2pkvux0>
Subject: [mpls] Genart last call review of draft-ietf-mpls-sr-over-ip-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2019 15:47:47 -0000

Reviewer: Robert Sparks
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at


Document: draft-ietf-mpls-sr-over-ip-02
Reviewer: Robert Sparks
Review Date: 2019-02-20
IETF LC End Date: 2019-02-26
IESG Telechat date: Not scheduled for a telechat

Summary: Ready, but with nits that should be addressed before publication as a
Standards Track RFC


The 2nd sentence of the introduction is complex. It should be easy to simplify.

It would help to place the reference to draft-ietf-mpls-spring-entropy label at
"If encoding of entropy is desired". (Or if some other reference is better, use

In that same paragraph, something is wrong at "make use of entropy label
mechanism." Should that be "the entropy label mechanism"?

SRGB is used without expansion.

Where is "the lower bound" of an SRGB defined? The string "lower bound" doesn't
occur in either of the routing-extensions drafts referenced where SRGB is first

Section 3.1 is about ostensibly about constructing a FIB entry, but its last
step is sending a packet.

The first sentence in section 3.2 is more complex than it needs to be. It
should be easy to simplify.

It would be nice if you could make the differences between the routers in
figures 3 and 4 visually apparent rather than relying on text to explain the
difference. Something like (view in a fixed width font):

s-----s      i-----i
|  A  +------+  B  +--
s-----s      i--+--i

At the first paragraph on page 9: s/and then process/and then processes/