Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang

tom petch <ietfc@btconnect.com> Sun, 01 March 2020 10:52 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B8AD3A0CF3; Sun, 1 Mar 2020 02:52:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 62hex8JnYAm4; Sun, 1 Mar 2020 02:51:59 -0800 (PST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60109.outbound.protection.outlook.com [40.107.6.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6DB43A0CF0; Sun, 1 Mar 2020 02:51:58 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; =?utf-8?q?b=3DFddzPPNGPU4wl94VA0ZINIkStio8pU0Ggmx1+vxml3iE5/Tv5M6MswSF0yFOV?= =?utf-8?q?FXbyx6J5DOMK5xycnQ72uQQMNJqicrkxRsAuBJoTVtsdoYd1sWkPjnTbiHFIs8/CZ?= =?utf-8?q?No9DJhg+5E03p/c1uarYp18otcgMQaOQW6ozwat7elWSUoZ7omqQ4v5FfYyZedOIg?= =?utf-8?q?xPg04ot1WfTcqYtsFQQGedeZEw/rglaSdRo5Q9GcCrLEZoeisdSi7s6SATjjgSsJs?= =?utf-8?q?/WMpxov3jn4LjfvPQlsWQ4DDuwHmK1RUgqgrlJ/7eB0WsO8Ntymp9Uq3XUEwy3yml?= =?utf-8?q?rIO4T5//w5h2svLVssgWQ=3D=3D?=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AMessage-ID=3ACont?= =?utf-8?q?ent-Type=3AMIME-Version=3AX-MS-Exchange-SenderADCheck=3B?= =?utf-8?q?bh=3D6HhZyZ2UMiZR2RbsmdORiOcF2dhHvs39X39MUtpMNnA=3D=3B_b=3DNBTZpw?= =?utf-8?q?Zk+e8xAdXs4O8X4M9a+s7a8LQ3EQrXmvg5ELcZ/NY4flVTK0rkBACgpDipRoFnhH1?= =?utf-8?q?lRHgbWv2l32/rMlipJeD+XhvKQUbmOx7oyXnP/yHJdecKcbi8xBIwsRgMaJ2KHJiU?= =?utf-8?q?b+tt/IHe2OJo1Rtjs374Of/3FDBTiIlwzkiWJMMXgFdDJ1kX4IadykS9cDVDDVtKa?= =?utf-8?q?mSJJAYCbmfKfThAAZcqxI8vmD0Ju05bv44ULPn0HdOsOFMqx+7OTkC586uCZ6ANtA?= =?utf-8?q?og2ODGkxk93b3I2LP1x0bHeOh8EOnn7jI4lBh5sGKyTb6nGfAf819OnuQDCnroLNV?= =?utf-8?q?zrC6BHDV9rA=3D=3D?=
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AMessage-ID=3AContent-Type=3AMIME-Vers?= =?utf-8?q?ion=3AX-MS-Exchange-SenderADCheck=3B?= =?utf-8?q?bh=3D6HhZyZ2UMiZR2RbsmdORiOcF2dhHvs39X39MUtpMNnA=3D=3B_b=3Diwaqg6?= =?utf-8?q?B07jIWnbOlS8e7QeRKmfvksshvxAsB7glGR54mLYlJmPnXGaIcBmud6Y31YnBme7C?= =?utf-8?q?6Dy+cyDVhubL/yi+cGZosUKN4JOtH0Lr6mD3Hii2K9F9TMGB5JbiA1OEIfwLkgYXv?= =?utf-8?q?rA2fAynq0bJyy4vIx722DwxoF6vYEAgsazM=3D?=
Received: from DB7PR07MB5657.eurprd07.prod.outlook.com (20.178.85.222) by DB7PR07MB5594.eurprd07.prod.outlook.com (20.178.43.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.10; Sun, 1 Mar 2020 10:51:56 +0000
Received: from DB7PR07MB5657.eurprd07.prod.outlook.com ([fe80::a438:bbc9:2ffe:33ee]) by DB7PR07MB5657.eurprd07.prod.outlook.com ([fe80::a438:bbc9:2ffe:33ee%5]) with mapi id 15.20.2793.009; Sun, 1 Mar 2020 10:51:56 +0000
From: tom petch <ietfc@btconnect.com>
To: Tarek Saad <tsaad@juniper.net>, Loa Andersson <loa@pi.nu>, "mpls@ietf.org" <mpls@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-ietf-mpls-base-yang@ietf.org" <draft-ietf-mpls-base-yang@ietf.org>
Thread-Topic: [mpls] MPLS wglc draft-ietf-mpls-base-yang
Thread-Index: AQHVtlY6DqL/m7q1BUSyzqpktbiPc6fr772sgAlRoUKALSWZAIADz/8ggAgTxoCABbUNKQ==
Date: Sun, 1 Mar 2020 10:51:56 +0000
Message-ID: =?utf-8?q?=3CDB7PR07MB56578EEC4746544E58F4E3F8A0E60=40DB7PR07MB5?= =?utf-8?q?657=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?=
References: <2e2ce194-ed62-d225-ca7e-97e373c9c5c9@pi.nu> =?utf-8?q?=3CDB7PR0?= =?utf-8?q?7MB565756000718666B19277A81A0370=40DB7PR07MB5657=2Eeurprd07=2Epro?= =?utf-8?q?d=2Eoutlook=2Ecom=3E_=3CDB7PR07MB5657487FF5F4DB2E0F2006FCA00D0=40?= =?utf-8?q?DB7PR07MB5657=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?= =?utf-8?q?=3C080939AD-4BE0-4138-AAF6-34141CD36385=40juniper=2Enet=3E_=3CDB7?= =?utf-8?q?PR07MB56577E28162DFB1CC17028FAA0120=40DB7PR07MB5657=2Eeurprd07=2E?= =?utf-8?q?prod=2Eoutlook=2Ecom=3E=2C?= <06CEB2BB-716E-4401-9669-E458A1B11CFA@juniper.net>
In-Reply-To: <06CEB2BB-716E-4401-9669-E458A1B11CFA@juniper.net>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Name=Juniper Business Use Only; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; =?utf-8?q?MSIP=5FLabel=5F9784d817-3396-4a4f-b60c-3ef6b345fe55=5FSiteId=3Dbe?= =?utf-8?q?a78b3c-4cdb-4130-854a-1d193232e5f4=3B?= MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ContentBits=0; =?utf-8?q?MSIP=5FLabel=5F9784d817-3396-4a4f-b60c-3ef6b345fe55=5FMethod=3DSt?= =?utf-8?q?andard=3B_MSIP=5FLabel=5F9784d817-3396-4a4f-b60c-3ef6b345fe55=5FA?= =?utf-8?q?ctionId=3D5c7ae61b-4200-4976-b63d-00007479d7aa=3B?= MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SetDate=2020-02-19T05:55:45Z;
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-originating-ip: [81.131.229.19]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 16d706a0-a480-4b2b-9894-08d7bdce8f5a
x-ms-traffictypediagnostic: DB7PR07MB5594:
x-microsoft-antispam-prvs: =?utf-8?q?=3CDB7PR07MB55942AD6541B64D0DBA7D3F3A0E?= =?utf-8?q?60=40DB7PR07MB5594=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?=
x-ms-oob-tlc-oobclassifiers: OLM:1443;
x-forefront-prvs: 0329B15C8A
x-forefront-antispam-report: SFV:NSPM; =?utf-8?q?SFS=3A=2810019020=29=283960?= =?utf-8?b?MDMpKDEzNjAwMykoMzQ2MDAyKSgzNzYwMDIpKDM2NjAwNCkoMzk4NjA0MDAwMDIp?= =?utf-8?b?KDE5OTAwNCkoMTg5MDAzKSg1MzU0NjAxMSkoOTY2MDA1KSg1NTAxNjAwMikoOTY4?= =?utf-8?b?NjAwMykoMjYwMDUpKDc2MTE2MDA2KSg2Njk0NjAwNykoMTg2MDAzKSg4MTE1?= =?utf-8?b?NjAxNCkoOTE5NTYwMTcpKDg2NzYwMDIpKDg5MzYwMDIpKDY2NTU2MDA4KSg2?= =?utf-8?q?4756008=29=2866446008=29=2866476007=29=2871200400001=29=286506007?= =?utf-8?b?KSg4MTE2NjAwNikoNTI1MzYwMTQpKDU2NjAzMDAwMDIpKDQzMjYwMDgpKDI5?= =?utf-8?q?06002=29=28478600001=29=287696005=29=2833656002=29=2854906003=29?= =?utf-8?q?=28110136005=29=2886362001=29=28316002=29=3B?= DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB5594; H:DB7PR07MB5657.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: =?utf-8?q?sRf3zKnnYNse45gLpoxElFk7Tw8cIZG?= =?utf-8?q?8hOjC8qO1/u8ZQEfXWC7fpNNLtX0F6LhcjLRQZDRf6VWhz4uIzE+tqNUGWlzZIMeG?= =?utf-8?q?QOAlxZWBciXBzeywyS2KilOFgb033nK67YvPNKN1wq41bSjvplIHXKpC055id4Fk9?= =?utf-8?q?dWsyeuvILasC5R4tToU1MdDS41bvR4xWfROaRQt2iZgXywnVXfb0YxgNGhijODVDn?= =?utf-8?q?nXxEwznenIhyEVoW4mhSeSWllW0ySIVhvmWknxUZ2pSFjXCzlDZcE8YP7zGNKxEiv?= =?utf-8?q?fANRDN0bhSnStLpInkOM7Lnk3LIhkyxtnwdTH6iItlaLESTYTpHFe9avNOAHLkZuZ?= =?utf-8?q?SgbNawuwVUlP+RNdghPhotHAlCqwJCovXpexkpKOfQ3hdzZcVzAufA38xI61R8N71?= =?utf-8?q?75LAGCeYaHV3Xd3Naj4D1IDrLOYwg3cMuy1s8QB8Gh+nxAjYfdlWNG+wx/ReprsGH?= =?utf-8?q?hSJMC86gu5aIB9PcbiEmrRkNUyEOefEDpFQe+WbS4jetosXw=3D=3D?=
x-ms-exchange-antispam-messagedata: =?utf-8?q?W8kyx4JYOWBfnY3Ccqidavl3qALDfQ?= =?utf-8?q?NSWXHZPy4mL9cZSzNU9OAXnb5RNY30xGwSGV9/phNFOc2QT242rGRGvlkJ04Iaweb?= =?utf-8?q?qBuGiMfUUAJWTY7qOGRoEP4c+3OwylIMzeFLWVxaxXqhF21sbQLeB/g=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16d706a0-a480-4b2b-9894-08d7bdce8f5a
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2020 10:51:56.0937 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: =?utf-8?q?pXPbvGPpiN1QZ5Xrvx0Aw?= =?utf-8?q?5FWbMykI7DjkqlASdurzRZRE3TAhN93Vvwa4V1wdVzl5OpLEoEB8HtBKwaLPco7ng?= =?utf-8?q?=3D=3D?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB5594
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/VlI_4MtLho5vGkEVRNFZYwHG2X8>
Subject: Re: [mpls] MPLS wglc draft-ietf-mpls-base-yang
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Mar 2020 10:52:03 -0000

_______________________________________
From: Tarek Saad <tsaad@juniper.net>
Sent: 26 February 2020 19:34

Hi Tom,

Thanks again. Please see inline for more responses. We will upload a new rev once you ack ok for below.

<tp>

Basically yes either OK or <tp2> in response 

Tom Petch

On 2/21/20, 11:30 AM, "tom petch" <ietfc@btconnect.com> wrote:

    Tarek

    progressing ... <tp> inline

    ________________________________________
    From: Tarek Saad <tsaad@juniper.net>
    Sent: 19 February 2020 06:00

    Thanks much for your review and useful comments. We have posted a new revision -12 at https://urldefense.com/v3/__https://tools.ietf.org/html/draft-ietf-mpls-base-yang-12__;!!NEt6yMaO-gk!RFlhNE079NN1bKO-FktmwgK2FeDnE2z--K8tf-tk57WePssEoox0hX_EJhhQwA$  that addresses those. Let us know if you have further comments.
    Also, see inline for responses on closure.

    On 1/21/20, 7:38 AM, "tom petch" <ietfc@btconnect.com> wrote:

    Some more technical thoughts on this I-D

            Abstract

            LSP is not in the RFC Editor list of 'so well known ...'
    [TS]: it is listed at https://urldefense.com/v3/__https://www.rfc-editor.org/materials/abbrev.expansion.txt__;!!NEt6yMaO-gk!RFlhNE079NN1bKO-FktmwgK2FeDnE2z--K8tf-tk57WePssEoox0hX9YKDyWLw$

    <tp> as Acee points out, it lacks the asterisk that says that no expansion is needed :-(
[TS]: yes, admittedly I was ignorant about that.

OK
            s.2.1
               The other MPLS route(s) that are non-IP prefix routes are modelled by
               introducing a new "mpls" address-family RIB as per recommendation .

            Where is that?

    <tp> I was looking for a reference for the recommendation - is this the routing RFC, RFC8349 s.5.2?
[TS]: Yes, that would be RFC8349 section 3:
"
   o  The data model should be suitable for the common address families
      -- in particular, IPv4 and IPv6 -- and for unicast and multicast
      routing, as well as Multiprotocol Label Switching (MPLS).
"

OK

    [TS]: Please refer to identity below defined in the model which has rt:address-family as base.
      identity mpls {
            base rt:address-family;
            description
              "This identity represents the MPLS address family.";
      }

OK

            s.2.2
               interfaces-mpls:
                      A YANG grouping that describes the list of MPLS enabled interfaces
                      on a device.

               label-blocks:
                      A YANG grouping that describes the list of MPLS enabled interfaces
                      on a device.

            um
    [TS]: we corrected the description. See below:
    NEW:
    A YANG grouping that describes the list of assigned MPLS label blocks and its properties.

OK

            YANG Module
                     Copyright (c) 2018 IETF Trust

                    leaf loadshare {
            I  would  value a reference for this.
    [TS]: rfc3031 section 3.11 and  3.12.

    <TP>  well sort of; those sections talk about sharing across equal cost paths which seems somewhat simpler - I understand the YANG DESCRIPTION but would expect it to be described in an RFC somewhere.
[TS]: I've across yet another reference that tackles optimizing distribution of traffic on ECMP/LAG -- rfc7424 (e.g. sec 5.4). Let me know if you are OK with this and we can refer to it.

<tp2> yes please add it is a better description although I cannot find a use of loadshare.  I will dig around to see if I can find the term used anywhere else but meantime go ahead with this one.  To date I can only find it in SS7:-)


              grouping interface-mpls-properties {
            ...
                      type boolean;
                      description
                       "'true' if mpls encapsulation is enabled on the interface.
                       'false' if mpls encapsulation is enabled  on the interface.";

    <tp> so true means enabled and false means ..  enabled ; clear but logical?
[TS]: thanks for spotting this. We will correct this typo.

OK

                    leaf mtu {  type uint32; description
                            "MPLS Maximum Transmission Unit (MTU) in bytes";

            um what is included in MTU here  c.f.draft-ietf-netmod-intf-ext-yang-07
            which  includes L2 header but not FCS in Layer 2 MTU;
            a reference might help
    [TS]: includes L2 MTU + maximum MPLS label stack size. rfc3032 section 3.2.

    <tp> well no; MTU does not appear in RFC3032 s.3.1; other terminology does and I want to map the terminology of this I-D - MTU- to the terminology of s.3.1
[TS]: the section we referenced (RFC3032 section 3.2) has:

"
3.2. Maximum Initially Labeled IP Datagram Size

   Every LSR which is capable of

      a) receiving an unlabeled IP datagram,
      b) adding a label stack to the datagram, and
      c) forwarding the resulting labeled packet,

   SHOULD support a configuration parameter known as the "Maximum
   Initially Labeled IP Datagram Size", which can be set to a non-
   negative value.
"

Would renaming the leaf to maximum-labeled-packet-size help in any way?

<tp2>
 yes that would be a good change

</tp>

Regards,
Tarek


    That is all

    Tom Petch
    </tp>

              grouping interfaces-mpls {    description "List of MPLS interfaces";
                    list interface {   key "name";  description "List of MPLS
            interfaces";
                      leaf name {   type if:interface-ref;
                            description   "The name of a configured MPLS interface";

            no conditional so every RIP or dial up X.25 e.g.is going to get this:-( probably ok

              augment "/rt:routing" {
            ditto, although probably less significant
    [TS]: added feature mpls, and added if-feature check under the augmentations.

              augment "/rt:routing/rt:ribs/rt:rib/rt:routes/rt:route/"
                            + "rt:next-hop/rt:next-hop-options/rt:simple-next-hop" {
                    description
                      "Augment 'simple-next-hop' case in IP unicast routes.";

            other I-D augment control plane/protocols/static-routes
    [TS]: the MPLS Static model is a separate model that is described in draft-ietf-mpls-static-yang.

    Regards,
    Tarek

            Tom Petch