[mpls] Eric Rescorla's No Objection on draft-ietf-mpls-rfc3107bis-02: (with COMMENT)

Eric Rescorla <ekr@rtfm.com> Wed, 02 August 2017 18:16 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EA240126C22; Wed, 2 Aug 2017 11:16:22 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Eric Rescorla <ekr@rtfm.com>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-mpls-rfc3107bis@ietf.org, Loa Andersson <loa@pi.nu>, mpls-chairs@ietf.org, loa@pi.nu, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.58.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150169778295.5791.7064986991890318485.idtracker@ietfa.amsl.com>
Date: Wed, 02 Aug 2017 11:16:22 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/N3tpetlMIEqnF5elJ4SvYVIw1Rk>
Subject: [mpls] Eric Rescorla's No Objection on draft-ietf-mpls-rfc3107bis-02: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 18:16:23 -0000

Eric Rescorla has entered the following ballot position for
draft-ietf-mpls-rfc3107bis-02: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mpls-rfc3107bis/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Document: draft-ietf-mpls-rfc3107bis-02.txt

S 2.1
I note that you use 255 to mean "any number of labels" and 0 is marked
ignore. Is there a reason not to use 255 as a concrete number and 0
to mean "any number"? This is just for my information.


S 2.3.
      Note that failure to set the S bit in the last label will make it
      impossible to parse the NLRI correctly.  See Section 3 paragraph j
      of [RFC7606] for a discussion of error handling when the NLRI
      cannot be parsed.

It would be helpful if you explicitly said that you parse this value
by reading labels one at a time until you get a non-zero S bit. It's
implicity, but having it be clear would be nice.