Re: [mpls] New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt

tom petch <ietfc@btconnect.com> Mon, 02 August 2021 10:01 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C9B783A166C; Mon, 2 Aug 2021 03:01:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Y6vrdCS2H5a; Mon, 2 Aug 2021 03:01:09 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10126.outbound.protection.outlook.com [40.107.1.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 692F63A1669; Mon, 2 Aug 2021 03:01:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WMNv4oLVy5It4YjfbSk4Pb81iV3O2ThnqMn6SQLPr2PxuceT1nUHrd1nmJo3nVANVLXA4WfFn5SCQ8f+FTtkYbNA+GLKwbaJKgstGP4ATvKHPb5t8whDXNe2/L4zwdu1bpsX4wb17yA8OGOAMpPA9AT5rQEwXfgzJxvvYQzHZuobABNIgrO38/nBVJAF5OHXGbHx1I94TKTQ9hZa4w2hRgk0HMRdPAnn5WrFz+cczPZGOWvc++c7PzuE6jatuaaNAepjyB1al8+8dcOWXY82ZQYawHNdRZy77jTH6EdaUSFqtqN9GL1fB+g2FTD+4fndnUPYqaZJ331yui4UVs/vIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T4RGpYDbTgoUdbf2PzuOEM/vJciCP6Qhnw53Iho7crk=; b=m5LKqRyYy09wgXwVUsfOceIeRAKVWy4mTJ7eVJCGBHB8HnWBKuqo9RzYE9tnIHXHjHLgvVoh8Og8GIST5eBYcQL6G9gEMDiMqtXBO8hP/VM61mq8jnMrs4/EKHqR+giAbIa25xCoEKT4O6s6hPZo7uEG7g7LZYLp5TFYBGNT2m+pINqyjm3JimjnFkp3IpDZBiDkGinxHCj2OrXVicyfM02qd/EvQVHWfYpUsWprEo+a3LHD+1g0KcxnLFGI0F5kQXM1QNYhDbvoe3XoNuziKEDrpE0HBwrjSpMWCPmSA8QoW8dYzkZT2uCPvFDdlzjlBmU/orjq/Lz9HXN3qHlnRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T4RGpYDbTgoUdbf2PzuOEM/vJciCP6Qhnw53Iho7crk=; b=PwA7Dvu6BMX8v4p+r0wSSC6PRHvIi6qJxdxcDZXmd3FcjSZxN2K9VrLMPzecmO+C5q2WDMWQDf2VnXa9O0se2G4n41VgC/xcjwMRiP2S+qwl7U/YcQY6RL9FaOgjI4epU7wJ97pK8NaSGyIneL5zVzverB4Wf3KI79+6CsQWoxs=
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com (2603:10a6:20b:134::11) by AM6PR07MB4965.eurprd07.prod.outlook.com (2603:10a6:20b:3e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.9; Mon, 2 Aug 2021 10:01:05 +0000
Received: from AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::f0df:b211:32dd:d5d8]) by AM7PR07MB6248.eurprd07.prod.outlook.com ([fe80::f0df:b211:32dd:d5d8%4]) with mapi id 15.20.4394.015; Mon, 2 Aug 2021 10:01:05 +0000
From: tom petch <ietfc@btconnect.com>
To: Yingzhen Qu <yingzhen.qu@futurewei.com>, "mpls@ietf.org" <mpls@ietf.org>, "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>
CC: "draft-qu-mpls-mpls-msd-yang@ietf.org" <draft-qu-mpls-mpls-msd-yang@ietf.org>
Thread-Topic: New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt
Thread-Index: AQHXhwetQSjXEgYqikCtDxkc4g5OeKtfnWimgABWpt4=
Date: Mon, 2 Aug 2021 10:01:05 +0000
Message-ID: <AM7PR07MB6248410CF95AE457D9CB47A2A0EF9@AM7PR07MB6248.eurprd07.prod.outlook.com>
References: <162784450568.13184.7481638186028270876@ietfa.amsl.com>, <BY5PR13MB304858C756AEA5D8AB06A688E1EF9@BY5PR13MB3048.namprd13.prod.outlook.com>
In-Reply-To: <BY5PR13MB304858C756AEA5D8AB06A688E1EF9@BY5PR13MB3048.namprd13.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: futurewei.com; dkim=none (message not signed) header.d=none;futurewei.com; dmarc=none action=none header.from=btconnect.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b741029-2a35-458b-f98a-08d9559c713c
x-ms-traffictypediagnostic: AM6PR07MB4965:
x-microsoft-antispam-prvs: <AM6PR07MB4965F8249D15B792BEC64689A0EF9@AM6PR07MB4965.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: oUuuk86d6ogu7cbXtQh5Er/dsAHdkmWdiCMK82HxybKGLJ91jRa/A4MpL7OTIzctW2VC2U6oZu8IUeyioID1CrLjEluCPUY93Nq2FocCkXN42Q2d4C04j8rSZFzwRGLCUg9D452kek9ccngIaXH5U8KB8ZBYQFCCxZ7uccLdniTfolUwoN4Sq7EmTfm+HgPDeS/qABlmaMjVlHVfPpIsXZ1zAfnWeo3qtADxxho9Ulswqd8gByvzta2egiB3rxBZU2a1RFHXaRc1J39YGz4P0GXKj5gwtmO5AYmtO7O2ZjRhX6InrZ7ZFJ4YwQrlrSJXVKSyNgy/HHpA+XiyqzDgUZcgosQnngojXnd+UnBGAlSe4C01fbXCmS/1/akuFI7uD8NybQD1DUNtpMx9LzZm7IYgxKq5yMiWxqY2ioevRLSrJ2wsoOudu5joSxS0ZkNQStOjg+IgNJ/lpuTDMGHDs5DAxMRm/HBJl20t5YwwE4rtjaMVBpaVH5ktLtgZoke2ZavVGH+MIlWnMmpIzOOLnkjSt/MtrpkkUIS/OEYO591C/0qpldDtV/bf4DjZZfaBVce/8ZYMONBwEHCV6X4h/np+CWtE4odn6LoFzIBjaDZacu2s6H5xl6QE3R/hLt/dTw3GnbqfaJ2OvCI9Ak5EyFrrPcLLNjanvfU9hRa6RvQA1KVdi9uQ2lhvQ9TqnvK/7SYVcs4TQwZsYZIBXRJTI/Azp9H3FJOj430n6B4PSyGUssYGTpg2ib3A3nUSibb9n+9bzXDiyrcRSZUDiQFVHi7KvX/iPvVkIsWVdcXklg4a+XC675eTeD4hxkg4KAsn
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB6248.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(136003)(366004)(396003)(39860400002)(8676002)(66946007)(52536014)(7696005)(33656002)(966005)(91956017)(8936002)(15650500001)(66574015)(478600001)(83380400001)(110136005)(76116006)(4326008)(316002)(38070700005)(5660300002)(53546011)(6506007)(26005)(2906002)(71200400001)(9686003)(45080400002)(38100700002)(122000001)(86362001)(55016002)(186003)(64756008)(66476007)(66446008)(66556008); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4YWtWjnXkrPef55CAFfd1arQ+SFoXRSU1Z/hcIZiyJEWJBDMu3Ezj67l24?= =?iso-8859-1?Q?/T53kjZETCqCtGGHmIvIou+1ZJLkuDE+Cu392SNZ79fkPIxvHbUMfVpDwR?= =?iso-8859-1?Q?YnleIOq53wvU9RN97NaB8Bb9N1SgM6SliIgMIUzwA3HFnWfjnlR2jcAWpQ?= =?iso-8859-1?Q?3xotuvlG0stR8rB0gHJ7DXxHOq4WZFMsyiwht7FqazCyjrUFeZ7mRc64fP?= =?iso-8859-1?Q?wfBKDRD5n7gwNNePftERMoN9ke7YT5d8W1wucDbMGIR3FYf33maSTNMnov?= =?iso-8859-1?Q?R8H+Dv6bG2pEyojGbVQCDiCk+oQvvR8qAgcDrhNiGlMHKxy5wd3MQhsRp2?= =?iso-8859-1?Q?+0cvCy5ncZYBVE+g1+cL0HQhANFgiSo2PDdD/9eX8GbZUQrJ7Mfb8tQ3fX?= =?iso-8859-1?Q?AUVNq7R5ISnaB5DttAjEUuwN57kZDrlhs2tzApYeiJyyPUAjPsJKxcohuq?= =?iso-8859-1?Q?J8HYaYX2PZpFBcRS6P/YsVtsUBg7X6S1Xef07AILf/GwVIO9wdsRRLRX1b?= =?iso-8859-1?Q?MuXfEbF4cPdt4127DGB8p6Q/F/bjHEzarc6ROYmkicPk1Q4zA0FCf73rh9?= =?iso-8859-1?Q?dwHY4mQ0lMyews6cCDLbcM2Wf7/JFGCKFUpeLbJpXY9PisbaDI/QeYzAbr?= =?iso-8859-1?Q?Yy5rBoYvHme58EOs0n80qSvMfac/5Zhm8eUGsbUPbvScHaPD97Qur9nqYM?= =?iso-8859-1?Q?9NdtGbZVHfTYFlnLWZNmBDFzJsp/3m540ADUHp1gcpFm6RmGzli9/MwHjr?= =?iso-8859-1?Q?YzCh+iN5VJB9qRiiHHe2TlJxumYnk25lam4BtVP6ffXCDa7o7efmWq0Ld3?= =?iso-8859-1?Q?1LRHvX48huWXulZF2nuWYKCPfEWNM3laLcMfXd1nojeSXtqK28BkYToVf6?= =?iso-8859-1?Q?YWgg6uuxEqVyUoT8KKfmerpHKbRsGe5q91li0BVPRgXvizam4zUtbJZL3w?= =?iso-8859-1?Q?+nFgihHTCpqEdoQtU10f5+eCOSl5dq7G7BH/CJUed8UyJbeTSmMFhEwxPh?= =?iso-8859-1?Q?SJmFnyF2KL1miFL08GA5S01YAtOp12ZBZ4CX777eJSQl5M/T7bDiDqUVFe?= =?iso-8859-1?Q?93v5PdYN7/wcda2gHMMsPvQuxQ5rmKzs/xaJ5wmXM9a1FEOiDULl1CttZ9?= =?iso-8859-1?Q?OVPEqq6ddIdd0xV/QDdfHzZIGjvAjWXFE2XihhhnS1j9M61W2uVYKVqWUY?= =?iso-8859-1?Q?ypsTluMQXLEBe4TPkhEzbUkaWKst2TP3EmnD5KZXk14yovTAnlZjbhAghi?= =?iso-8859-1?Q?lo+Em9adrwAOqISfkjWXljNDejcsVG/pW9PqstACanmgAkSkHORPnua8Zd?= =?iso-8859-1?Q?dRdWad0CsA6vIjI6OEuR8SmI2RraXzqtw3WvgFwTBTCEndw=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB6248.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b741029-2a35-458b-f98a-08d9559c713c
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2021 10:01:05.1173 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /0Bh6h9h/8iDctrwZrpidCbvltTXyRi/oY5MNbuy8wjSdrggAfwLA0d/p05gkJUjMPj0bNYNUZbkuZ6cNn9WaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB4965
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/O233EumGp4kz8lt1QlrtRsQC96w>
Subject: Re: [mpls] New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Aug 2021 10:01:15 -0000

From: mpls <mpls-bounces@ietf.org> on behalf of Yingzhen Qu <yingzhen.qu@futurewei.com>
Sent: 02 August 2021 05:41

Hi all,

We just submited a new version of the draft. Here is a summary of chagnes:

  *   updated security consideration with detailed node info
  *   minor editorial changes

The draft was originally part of the Segment Routing model, now RFC 9020. It was suggested during AD review to split the MSD part off the SR model since it's a generic MPLS parameter. The model is small and straightforward, and had been literally reviewed many times while it was part of the SR model. We'd like the MPLS WG review it, and request WG adoption.

If you have any comments, please let us know.

<tp>
I started off with some YANG quirks but ended up concluding I really do not understand the purpose of this I-D.

You create a list indexed by interface-ref for MSD.  MPLS YANG already has a list of interfaces.  Why not use it?

You create a list for nodes indexed by msd-type.  Why? and what is the point of  msd-type?

More generally I do not understand what the identity are doing.  You have no identity for two of the three signalling protocols.  I do not know what the purpose of msd-type is.  Needs justifying in the body of the I-D IMO.

You specify two protocols for signalling MSD; why not BGP-LS?

s.1 usually includes RESTCONF

s.1.1 out of date; the YANG module has the up to date description

YANG
four authors, three are mailto: one not

MSD needs expanding in the YANG module as that will exist independent of the RFC

identity identifiers have a lot of 'base' which I think redundant
'RFC8491: Singling MSD ...'

erld-msd I think back to front; I prefer msd-erld, msd-....

groupings that are only used once often get criticised by a YANG Doctor.  Quite right too IMO it just adds complexity and makes the I-D harder to read for no benefit that I can see.

Tom Petch

Thanks,
Yingzhen (on behalf of the co-authors)

________________________________
From: internet-drafts@ietf.org <internet-drafts@ietf.org>
Sent: Sunday, August 1, 2021 12:01 PM
To: Acee Lindem <acee@cisco.com>om>; Jeff Tantsura <jefftant.ietf@gmail.com>om>; Stephane Litkowski <slitkows.ietf@gmail.com>om>; Yingzhen Qu <yingzhen.qu@futurewei.com>
Subject: New Version Notification for draft-qu-mpls-mpls-msd-yang-01.txt


A new version of I-D, draft-qu-mpls-mpls-msd-yang-01.txt
has been successfully submitted by Yingzhen Qu and posted to the
IETF repository.

Name:           draft-qu-mpls-mpls-msd-yang
Revision:       01
Title:          A YANG Model for MPLS MSD
Document date:  2021-08-01
Group:          Individual Submission
Pages:          10
URL:            https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Farchive%2Fid%2Fdraft-qu-mpls-mpls-msd-yang-01.txt&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=dxVGZrfMleDR%2B1%2BlkmEXN%2FRJOmL1zXLRD3xKBjNtOzI%3D&amp;reserved=0
Status:         https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-qu-mpls-mpls-msd-yang%2F&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=sOxeuBLa4ZSUV0to9%2F9SMrpQ2xOE%2Fkxq8hBiPeUlEUc%3D&amp;reserved=0
Htmlized:       https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fhtml%2Fdraft-qu-mpls-mpls-msd-yang&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085880786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=VX8Y40I3tUA%2BKolwyUUNTTV%2BMVt9s5l5MNXiEuIsjA8%3D&amp;reserved=0
Diff:           https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Frfcdiff%3Furl2%3Ddraft-qu-mpls-mpls-msd-yang-01&amp;data=04%7C01%7Cyingzhen.qu%40futurewei.com%7C2cc7aa1a9ead41568d1108d9551ecf5f%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637634413085890780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=SvVf6VTIySZnUBZCgCMfthT%2FSyqkb1gIoES7FYYZg8U%3D&amp;reserved=0

Abstract:
   This document defines a YANG data module augmenting the IETF MPLS
   YANG model to provide support for MPLS Maximum SID Depths (MSDs) as
   defined in RFC 8476 and RFC 8491.




The IETF Secretariat