Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt

tom petch <ietfc@btconnect.com> Tue, 19 March 2019 17:31 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7CBD6131578 for <mpls@ietfa.amsl.com>; Tue, 19 Mar 2019 10:31:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.247
X-Spam-Level:
X-Spam-Status: No, score=0.247 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z5Mdl3g3OOWo for <mpls@ietfa.amsl.com>; Tue, 19 Mar 2019 10:31:42 -0700 (PDT)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130130.outbound.protection.outlook.com [40.107.13.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F14CA131571 for <mpls@ietf.org>; Tue, 19 Mar 2019 10:31:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3Ehr0K6YFH071wd5NAaKpK96I81j76rbuLBhs5kAZI=; b=RJ2W1mHUQ6NRuLF4UodP/1TEVgnjJCSA2NhXt9lLVP3RBX1Fdb0ccV04FSsJpsDgMnIQdD0UQ4ns+Z/jxC3rFNhEuoZ/Mfa+Nuu9ABwYRByNRZPy6afab7JpxubNLdN9UgnKfZgB9Yyi4mXAFSJ5Xaga4uBibo5T38MP0mW2EhU=
Received: from AM6PR07MB5731.eurprd07.prod.outlook.com (20.177.189.85) by AM6PR07MB3959.eurprd07.prod.outlook.com (52.134.116.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.15; Tue, 19 Mar 2019 17:31:38 +0000
Received: from AM6PR07MB5731.eurprd07.prod.outlook.com ([fe80::c981:391e:4943:3dba]) by AM6PR07MB5731.eurprd07.prod.outlook.com ([fe80::c981:391e:4943:3dba%2]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 17:31:38 +0000
From: tom petch <ietfc@btconnect.com>
To: Tarek Saad <tsaad.net@gmail.com>
CC: "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt
Thread-Index: AQHU03nqrT5RoCK7iEOJgW5Sst/P5g==
Date: Tue, 19 Mar 2019 17:31:38 +0000
Message-ID: <034601d4de79$44f06000$4001a8c0@gateway.2wire.net>
References: <155155736768.27158.1653954565392604255@ietfa.amsl.com> <016901d4d379$a1e91e60$4001a8c0@gateway.2wire.net> <CAHVfGYrtzs_Q+7Q1v2yeTmhjKRMarVZOD_1kynOJVxHFcpmZVw@mail.gmail.com> <068601d4d4e3$c5dc4980$4001a8c0@gateway.2wire.net> <BN8PR06MB62890074D29EA4440AC6F170FC4D0@BN8PR06MB6289.namprd06.prod.outlook.com> <BN8PR06MB62891CBCD1C236D82C172682FC4D0@BN8PR06MB6289.namprd06.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0161.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::29) To AM6PR07MB5731.eurprd07.prod.outlook.com (2603:10a6:20b:36::21)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.215.234]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8d5c2641-9922-4f62-89a9-08d6ac90bdbe
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7193020); SRVR:AM6PR07MB3959;
x-ms-traffictypediagnostic: AM6PR07MB3959:
x-ms-exchange-purlcount: 9
x-microsoft-antispam-prvs: <AM6PR07MB39593D3F7C0707FDB5CCC39FA0400@AM6PR07MB3959.eurprd07.prod.outlook.com>
x-forefront-prvs: 0981815F2F
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(136003)(366004)(376002)(346002)(13464003)(199004)(189003)(53936002)(5660300002)(62236002)(86362001)(81166006)(256004)(50226002)(66066001)(68736007)(97736004)(8676002)(9686003)(81156014)(6306002)(305945005)(86152003)(4326008)(6246003)(6512007)(44716002)(4720700003)(8936002)(7736002)(476003)(71190400001)(486006)(44736005)(386003)(2906002)(478600001)(61296003)(71200400001)(6916009)(6486002)(106356001)(105586002)(966005)(99286004)(229853002)(6506007)(84392002)(25786009)(446003)(6116002)(316002)(52116002)(76176011)(3846002)(102836004)(53546011)(81686011)(1556002)(81816011)(93886005)(66574012)(14496001)(186003)(26005)(14454004)(6436002)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR07MB3959; H:AM6PR07MB5731.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: VgZ5UNfbiBQK+bLwpjmCHrNFi9doA7bTM+47qK5SFdhfHIxXrZcPSPwHtV57qEPGFKi7xPJO//2m1JuoGR+rqtnWRiWyOVt5VRl7a54rK2NBE7zElgQRjZzXLyw8aGWnLEcALdWg8xMrbhlZejpR/jJ8eF1O4utEqHuW6nONXwuPZsqbrqLd8rmyGl5D5TM7Dw8j4swGyKTLMjf5OyxYZJq6H4YDnYzF3y83/OtF9lVvy2bSo8tlwz3ygncn2eur2LgK5mUezHUS62zU7lEMcjhrcwGLuyqh/G5iKN9gaaxkuVsB4WtUDLcv1iiLIGTyP7oaZbo5w5/pbg29Q1PGZM0g3E2butTlUmlD5hxPGrwjk21ZfReTrW91F78DydTKO48E1TtSPIKAgd2Y6VGANLtFpD6Re0OmnJaK2gKDWgI=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D745B49882D12940898810A7BB9E9E40@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d5c2641-9922-4f62-89a9-08d6ac90bdbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2019 17:31:38.0974 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB3959
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/OMGtAJeYxsXQstGpf3htWm4GJ-M>
Subject: Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Mar 2019 17:31:44 -0000

---- Original Message -----
From: "Tarek Saad" <tsaad.net@gmail.com>;
Sent: Friday, March 08, 2019 7:13 PM

> Thanks Tom. The comments are addressed in version -09:
> https://tools.ietf.org/html/draft-ietf-mpls-static-yang-09
>
> And diff:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-static-yang-09

Indeed they are.  Two more technical thoughts

IANA Considerations has

      prefix:     ietf-mpls-static-extended

which I was about to say was rather long for a prefix and then I saw

   module ietf-mpls-static-extended { ...
     prefix "mpls-static-ext";

which is not so long, probably short enough (if that is the right one!).

Second, I am wont to check such statements as
       leaf lsp-priority-hold { type uint8 {
           range "0..7";  }
         description "LSP hold priority";
against the original specification, since I know of rtgwg YANG modules
where the YANG contradicts the published RFC; but there is no reference
clause for objects such as this one, so I would have to go digging for
the relevant RFC, which was easy in 2001 because there were so few RFC
but now ...

If you add references, I will go look up the relevant sections - if not,
...

Up to you:-)

Tom Petch

> Regards,
> Tarek
>
> On 3/8/19, 1:14 PM, "Tarek Saad" <tsaad.net@gmail.com>; wrote:
>
>     Hi Tom,
>
>     Thanks. We'll unify to "Mbps" and keep this consistent in units
and description.
>
>     Regards,
>     Tarek
>
>     On 3/7/19, 7:48 AM, "tom petch" <ietfc@btconnect.com>; wrote:
>
>         Tarek
>
>         One point I keep noticing but do not think I have raised
before is
>
>               units mbps;
>               description
>                 "Bandwidth in Mbps,
>
>         I have known systems fail because one party was using mbps,
another
>         Mbps, so seeing a mix of the two, as here, raises a flag for
me.  I note
>         that
>         draft-ietf-teas-yang-te-types
>         has
>                units "Mbps";
>         which I prefer - if they really mean Mbps and not mbps; I have
my
>         doubts! - but then
>          draft-ietf-l2sm-l2vpn-service-model-10
>         has
>                 units "mbps";
>                 default "10";  description
>                   "LACP speed. By default, the lacp speed is 10Mbps.";
>
>         Perhaps in the context of MPLS there is no ambiguity but it
would be
>         nice to have consistency at least within an I-D.
>
>         Tom Petch
>
>         ----- Original Message -----
>         From: "Tarek Saad" <tsaad.net@gmail.com>;
>         Sent: Wednesday, March 06, 2019 2:53 PM
>
>
>         > Hi Tom,
>         >
>         > As usual, thanks for your review on this one and for your
patience.
>         More
>         > Inline..
>         >
>         > On Tue, Mar 5, 2019 at 12:36 PM tom petch
<ietfc@btconnect.com>; wrote:
>         >
>         > > A long and winding road!
>         > >
>         > >  module ietf-mpls-static {
>         > > .....
>         > >    import ietf-routing-types {
>         > >      prefix "rt-types";
>         > >      reference "RFC8294: Common YANG Data Types";
>         > >
>         > > I see, in the RFC Index,
>         > >
>         > > 8294 Common YANG Data Types for the Routing Area.
>         > > i.e. a different title
>         > >
>         > > [TS]: yes, unfortunately a deja vu (fixed in another
module). We'll
>         take
>         > care of this in the new version.
>         >
>         > >
>         > > module ietf-mpls-static-extended {
>         > > ....
>         > >   import ietf-routing {    prefix "rt";
>         > >     reference "RFC6991: Common YANG Data Types";
>         > > I suggest
>         > >      reference "RFC8349: A YANG Data Model for Routing
Management";
>         > >
>         > > [TS]: yes, will take of this.
>         >
>         >  reference "RFC XXXX: Extended YANG Data Model for MPLS
Static LSPs";
>         > > um - I see this I-D as titled
>         > > A YANG Data Model for MPLS Static LSPs
>         > >
>         > > [TS]: OK for this one too.
>         >
>         > Regards,
>         > Tarek
>         >
>         >
>         > >
>         > > Tom Petch
>         > >
>         > >
>         > > ----- Original Message -----
>         > > From: <internet-drafts@ietf.org>;
>         > > To: <i-d-announce@ietf.org>;
>         > > Cc: <mpls@ietf.org>;
>         > > Sent: Saturday, March 02, 2019 8:09 PM
>         > >
>         > > > A New Internet-Draft is available from the on-line
Internet-Drafts
>         > > directories.
>         > > > This draft is a work item of the Multiprotocol Label
Switching WG
>         of
>         > > the IETF.
>         > > >
>         > > >         Title           : A YANG Data Model for MPLS
Static LSPs
>         > > >         Authors         : Tarek Saad
>         > > >                           Rakesh Gandhi
>         > > >                           Xufeng Liu
>         > > >                           Vishnu Pavan Beeram
>         > > >                           Igor Bryskin
>         > > > Filename        : draft-ietf-mpls-static-yang-08.txt
>         > > > Pages           : 18
>         > > > Date            : 2019-03-02
>         > > >
>         > > > Abstract:
>         > > >    This document contains the specification for the MPLS
Static
>         Label
>         > > >    Switched Paths (LSPs) YANG model.  The model allows
for the
>         > > >    provisioning of static LSP(s) on Label Edge Router(s)
LER(s)
>         and
>         > > >    Label Switched Router(s) LSR(s) devices along a LSP
path
>         without
>         > > the
>         > > >    dependency on any signaling protocol.  The MPLS
Static LSP
>         model
>         > > >    augments the MPLS base YANG model with specific data
to
>         configure
>         > > and
>         > > >    manage MPLS Static LSP(s).
>         > > >
>         > > >
>         > > > The IETF datatracker status page for this draft is:
>         > > >
https://datatracker.ietf.org/doc/draft-ietf-mpls-static-yang/
>         > > >
>         > > > There are also htmlized versions available at:
>         > > >
https://tools.ietf.org/html/draft-ietf-mpls-static-yang-08
>         > > >
>
https://datatracker.ietf.org/doc/html/draft-ietf-mpls-static-yang-08
>         > > >
>         > > > A diff from the previous version is available at:
>         > > >
https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-static-yang-08
>         > > >
>         > > >
>         > > > Please note that it may take a couple of minutes from
the time of
>         > > submission
>         > > > until the htmlized version and diff are available at
>         tools.ietf.org.
>         > > >
>         > > > Internet-Drafts are also available by anonymous FTP at:
>         > > > ftp://ftp.ietf.org/internet-drafts/
>         > > >
>         > > > _______________________________________________
>         > > > I-D-Announce mailing list
>         > > > I-D-Announce@ietf.org
>         > > > https://www.ietf.org/mailman/listinfo/i-d-announce
>         > > > Internet-Draft directories:
http://www.ietf.org/shadow.html
>         > > > or ftp://ftp.ietf.org/ietf/1shadow-sites.txt
>         > >
>         > > _______________________________________________
>         > > mpls mailing list
>         > > mpls@ietf.org
>         > > https://www.ietf.org/mailman/listinfo/mpls
>         > >
>         >
>
>
>
>