Re: [mpls] [Gen-art] Genart last call review of draft-ietf-mpls-egress-protection-framework-05

Alissa Cooper <alissa@cooperw.in> Wed, 10 July 2019 18:54 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAF611206B8; Wed, 10 Jul 2019 11:54:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=sSpfujD4; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=dNPuZsxS
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yWDHR4w-7WqN; Wed, 10 Jul 2019 11:54:04 -0700 (PDT)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3114D120703; Wed, 10 Jul 2019 11:54:04 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D75BA44D; Wed, 10 Jul 2019 14:54:02 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 10 Jul 2019 14:54:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=h ytDn4ebaSUYGH3cOeE5KcTVEHD2d3Vv7Yrh476XpuQ=; b=sSpfujD42yCwAPxjn HsDlWcWvInp0iF3PGqjMkplGKGsTM2gPZSKsVBWMTUkywIbKbMR/ymtZC0kit/nR SSZI2qUuPBfaqeIpxAua0I+Ta2LaFH8NpVVF92HqEab84VtjuSUMAZ2GAZwKO20W 5VcMoKzZL4Cn+wh5KGN9EI6X6e0tiFgVLuUkz3b6ez11vHtUCHjfepz5z8JujBgR N+C1MKF+DZ5sj9kM15UbjOs5ieOqmnbspR+k2rp6i7HILRdsYc2azUuUfZtHX382 uF3Cdmb8KBlrgcCtmyrm94bPbBVM/1Qnv2AiK6NXGxZrxwuC4g8eHDwXDk6sbA/3 avwrQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hytDn4ebaSUYGH3cOeE5KcTVEHD2d3Vv7Yrh476Xp uQ=; b=dNPuZsxS2lrjZ3L7XUSmYAYtUDYTpkNfysjhKfjaGrSZ5M+roolcF2vSr T8FJ+AAiHO/RnDj3wq+5asjK6Jp5gKmwAxHChMVbVrMCxNpgWEQ5QJ5sG05gyqHA ul1uFalnxbK0BEOzbzZ6iPAK30CSyz333xhV8wAPROd9dVv31TC3tsxX+z+Us3UM z0LBUsfehH+azMoH8ohOGRNTlh43u/bRHfQW9+GXztpzMU1Cj6XaoZ1AxS7i5QqT HpLqJ6dd2djqvSTVBESausxeLIO12YRumKYNv9LoC+BnBQ78Uymekbs8Pev4EDYC ovqJGyD6VwB4BDFtpEbG3Sh2z8zvg==
X-ME-Sender: <xms:STQmXV0j0xjIhGjb813j8FeDH3wGgrt30gtw_h2kurNcNYr-ByYrkg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeeigddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgpdhprhhoohhfphhoihhnthdrtghomhenucfkphepudejfedr feekrdduudejrdeludenucfrrghrrghmpehmrghilhhfrhhomheprghlihhsshgrsegtoh hophgvrhifrdhinhenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:SjQmXTFdluanJ8bFA8el88AzQ3asVx7QsbLLdue8c8rvXJNYgUpjdw> <xmx:SjQmXa7B1Rrbn1v-MC5MLljMJCoMCQaFmks_r2A1mkeLmJNerN2x5g> <xmx:SjQmXRvZjcIkzMg3sN21MHN3k79bobS9ubI-W8E05e6g39gYE-S3wg> <xmx:SjQmXRCQ9viLRLKp8jMYJBgVNXg149KrBvh-k7i70IhZ4VyvLePIZw>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.91]) by mail.messagingengine.com (Postfix) with ESMTPA id 11A7E80066; Wed, 10 Jul 2019 14:54:01 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <27FE6E4F-FBF7-466A-857E-7BD9EF22C4CD@juniper.net>
Date: Wed, 10 Jul 2019 14:54:00 -0400
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mpls-egress-protection-framework.all@ietf.org" <draft-ietf-mpls-egress-protection-framework.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "BRUNGARD, DEBORAH A" <db3546@att.com>, "mpls@ietf.org" <mpls@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8AD01B6D-3E79-4955-BD4F-A6E10CA5C68A@cooperw.in>
References: <156109261821.12295.3031530485744900655@ietfa.amsl.com> <27FE6E4F-FBF7-466A-857E-7BD9EF22C4CD@juniper.net>
To: Yimin Shen <yshen=40juniper.net@dmarc.ietf.org>, Peter Yee <peter@akayla.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/PEncgQzidkr-UJmyAyY31f2CLUs>
Subject: Re: [mpls] [Gen-art] Genart last call review of draft-ietf-mpls-egress-protection-framework-05
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jul 2019 18:54:07 -0000

Peter, thank you for your review. Yimin, thanks for addressing Peter’s comments. I entered a No Objection ballot.

Alissa

> On Jun 25, 2019, at 8:48 AM, Yimin Shen <yshen=40juniper.net@dmarc.ietf.org> wrote:
> 
> Hi Peter,
> 
> Thanks very much for your detailed review for this draft! We will fix these issues in the next version.
> 
> Thanks,
> 
> -- Yimin Shen
> 
> On 6/21/19, 12:50 AM, "Peter Yee via Datatracker" <noreply@ietf.org> wrote:
> 
>    Reviewer: Peter Yee
>    Review result: Ready with Nits
> 
>    I am the assigned Gen-ART reviewer for this draft. The General Area
>    Review Team (Gen-ART) reviews all IETF documents being processed
>    by the IESG for the IETF Chair.  Please treat these comments just
>    like any other last call comments.
> 
>    For more information, please see the FAQ at
> 
>    <https://urldefense.proofpoint.com/v2/url?u=https-3A__trac.ietf.org_trac_gen_wiki_GenArtfaq&d=DwICaQ&c=HAkYuh63rsuhr6Scbfh0UjBXeMK-ndb3voDTXcWzoCI&r=2-nT7xvtgxYac4wpYxwo_jh5rZM2uwTLxgRhaObwYug&m=61TkOv7C_RPT7dnqd0XVzhHp5Z3upqOSAqO5uQS1Pd8&s=L5X3khIidqv94LrBgsAHkZ66kkCliEdYqP0bbir_w-w&e= >.
> 
>    Document: draft-ietf-mpls-egress-protection-framework-05
>    Reviewer: Peter Yee
>    Review Date: 2019-06-20
>    IETF LC End Date: 2019-06-17
>    IESG Telechat date: Not scheduled for a telechat
> 
>    Summary: Ready with Nits.  I didn't really find any substantial issues with the
>    document, although I admit this one is quite out of my area of expertise.  I'm
>    reduced to making sure it sounds logical (it does) and trying to reduce the
>    (future) burden on the RFC Editor.
> 
>    Major issues:
> 
>    Minor issues:
> 
>    Nits/editorial comments:
> 
>    General:
> 
>    For each occurrence of "e.g." and "i.e.", make sure that it is followed by a
>    comma and a single space.  There are some occurrences of double spaces and
>    pretty much no commas.
> 
>    Change "aka." to "aka" or to "a.k.a."
> 
>    Specific:
> 
>    Page 1, Abstract, 3rd sentence: change "context based" to "context-based".
> 
>    Page 3, section 1, 2nd paragraph, 1st sentence: change "repair based" to
>    "repair-based".  Insert "and" before "[RFC7812]" or put the sequence of
>    references inside of parentheses.
> 
>    Page 3, section 1, 2nd paragraph, 2nd sentence: delete the comma and "i.e."
>    after "PLR".  Put "point of local repair" in brackets.  Delete the comma and
>    "i.e." after "MP" and place "merge point" inside brackets.
> 
>    Page 7, section 4, 1st bullet item: append a comma after the first occurrence
>    of "MP2P".
> 
>    Page 7, section 4, 4th bullet item, 2nd sentence: insert "on a" before
>    "per-service-destination".
> 
>    Page 9, 1st bullet item: change "Or" to "or".
> 
>    Page 10, 1st partial paragraph, last sentence: change "It" to "it".
> 
>    Page 10, section 5.4, 2nd paragraph, 3rd sentence: delete extraneous space
>    between "{E, P1}" and the following comma.
> 
>    Page 11, section 5.7 title: change "context based" to "context-based".
> 
>    Page 14, item 3, 4th sentence: change "any-cast" to "anycast".
> 
>    Page 14, item 3, last sentence: I can't parse the end of that sentence.  Do you
>    want one or the other of "to" and "in", or is there a word or words missing in
>    there?
> 
>    Page 15, 1st paragraph, 1st sentence: append "of" after "AS'".  And I'll just
>    say that that's a very labored construction to avoid using "ASs" or "AS's" in
>    the sentence.  It took be a while to parse what was meant.
> 
>    Page 16, 1st full paragraph, 1st sentence: insert "the" before "PLR".
> 
>    Page 18, 1st paragraph, last sentence: change the first occurrence of "in" to
>    "if".
> 
>    Page 19, 1st partial paragraph, 1st full sentence: change "Figure-3" to "Figure
>    3" to match the figure's actual labeling.
> 
>    Page 21, section 8, 1st sentence: append a comma after "far".
> 
>    Page 25, section 11, 2nd paragraph, 2nd sentence: insert "of" before "trust".
> 
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art