Re: [mpls] George can yu look at this - Re: end of WGLC, RE: working group last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01

Nobo Akiya <nobo.akiya.dev@gmail.com> Sat, 25 April 2015 04:49 UTC

Return-Path: <nobo.akiya.dev@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2687F1A000B for <mpls@ietfa.amsl.com>; Fri, 24 Apr 2015 21:49:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.399
X-Spam-Level:
X-Spam-Status: No, score=-1.399 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, J_CHICKENPOX_15=0.6, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y01q_7rCH0Kh for <mpls@ietfa.amsl.com>; Fri, 24 Apr 2015 21:49:55 -0700 (PDT)
Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D06BA1A004A for <mpls@ietf.org>; Fri, 24 Apr 2015 21:49:54 -0700 (PDT)
Received: by labbd9 with SMTP id bd9so48084837lab.2 for <mpls@ietf.org>; Fri, 24 Apr 2015 21:49:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gCvucJmtc3gcTrkdC5koHbA80atSWCpoK6XbirO0A2k=; b=Tc1Y4s84SLY03TgJxepUwwYjuMOatYhAgB67pKhfqK5OKbRFljtIG/wDBmw/8YpP6N Qf2ui2Nycbec74l/NxFG9jvCjkWEqQ2vdpZ5mTG6CAn77KKAHuZiorIgWLCmsOHJ4SUV buqFaCJKhHMzywUUoo3aQJeaEXYZTUfoNtHGylAWm8Bbf04atT3hexMWRoN0Esjyuqpv j2aRwvr1aNRfocKGykAz/HNORa24u6NsB8fVnF6j756J+7SIbH8DKvHZACqr+Ro6ylLZ 4yzG/iJUOP5OeNZTBCq7DX5CI3k1U0pweuTKzzuOkoTGLLhOwpAZggZqqTDI2nzdlNxx fSxQ==
MIME-Version: 1.0
X-Received: by 10.152.36.73 with SMTP id o9mr1421168laj.48.1429937393331; Fri, 24 Apr 2015 21:49:53 -0700 (PDT)
Received: by 10.112.154.168 with HTTP; Fri, 24 Apr 2015 21:49:53 -0700 (PDT)
In-Reply-To: <020701d07e1e$a79bf940$f6d3ebc0$@olddog.co.uk>
References: <BY1PR0501MB14303A3E86F750CF628B7234A50E0@BY1PR0501MB1430.namprd05.prod.outlook.com> <BY1PR0501MB143031F1768A8854BA4CB30EA5E70@BY1PR0501MB1430.namprd05.prod.outlook.com> <CAFqGwGuKaR-pRiCS9hnzD0mGmY1dRWd2LANgaBf4MJdT+MYRpQ@mail.gmail.com> <001901d0786b$0c1ceb40$4001a8c0@gateway.2wire.net> <CAFqGwGsq2hZOnQWpzZuwvqAnGvNdmkE3bUkxk6LS9NZ6VOf10Q@mail.gmail.com> <00f701d07a80$44770e00$4001a8c0@gateway.2wire.net> <CAFqGwGuxK85W3anJ6omabHw+16HhUtSdw_yrsdt-weS1Z-abNw@mail.gmail.com> <55379EE5.8000801@pi.nu> <033c01d07db5$0ecb4720$4001a8c0@gateway.2wire.net> <5538EC97.8050204@pi.nu> <020701d07e1e$a79bf940$f6d3ebc0$@olddog.co.uk>
Date: Fri, 24 Apr 2015 21:49:53 -0700
Message-ID: <CAFqGwGtt72yTA7yDd_yHG5ad6=HhpRg_1VE2Xtziguqf=KbUUg@mail.gmail.com>
From: Nobo Akiya <nobo.akiya.dev@gmail.com>
To: adrian@olddog.co.uk
Content-Type: multipart/alternative; boundary="089e0160adf86173b20514853eed"
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/QLHUgacUVruv1OLacniBC5eG-q0>
Cc: mpls <mpls@ietf.org>, "draft-ietf-mpls-lsp-ping-reply-mode-simple@tools.ietf.org" <draft-ietf-mpls-lsp-ping-reply-mode-simple@tools.ietf.org>, Ross Callon <rcallon@juniper.net>, "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>
Subject: Re: [mpls] George can yu look at this - Re: end of WGLC, RE: working group last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Apr 2015 04:49:58 -0000

Hi Adrian, Tom, Loa,

This extension is currently structured such that it allows for backwards
compatibility (i.e., transit LSR not supporting this mechanism will not
return "malformed request" ... because the TLV is optional).

The result is that this mechanism becomes a best effort mechanism, and we
will not get the full benefit until all LSRs along the LSP (and other LSRs
which could falsely receive the echo request) implements this extension.

One way to allow the initiator LSR to determine whether or not the
responder LSR understood this TLV, and still keeping the backwards
compatibility, is that we keep the Reply Mode Order TLV as an optional TLV,
but require (i.e., MUST) the responder LSR understanding this TLV to
include the Reply Mode Order TLV in the echo reply, potentially with result
of parsing/handling that TLV.

However, that's probably not the path we want to go, as all (or most)
optional TLVs will have to do something similar (i.e., include the same TLV
in the echo reply). This will quickly result in echo reply packet bloat ...
we should prevent that as echo reply usually tends to include more
information (ILS, DSMAP/DDMAP per nexthop, multipath Sub-TLVs per nexthop,
etc).

To me, the right way to solve this is to create a capability TLV that
mandates the reponder LSR to return which features it supports in bitmaps
or something very compact. But this can be done in a separate effort/draft.

In short, my preference for this document is to go as is (after
incorporating comments from Tom).

Thanks!

-Nobo

On Thu, Apr 23, 2015 at 4:38 PM, Adrian Farrel <adrian@olddog.co.uk> wrote:

> Thanks Loa,
>
> You captured it. The edge cases need to be nailed down.
>
> Personally I have no particular preference for where it is nailed, but I
> don't
> want it flapping in the breeze.
>
> A
>
> > -----Original Message-----
> > From: mpls [mailto:mpls-bounces@ietf.org] On Behalf Of Loa Andersson
> > Sent: 23 April 2015 13:59
> > To: t.petch; Nobo Akiya
> > Cc: Ross Callon; mpls; mpls-chairs@tools.ietf.org;
> draft-ietf-mpls-lsp-ping-reply-
> > mode-simple@tools.ietf.org
> > Subject: [mpls] George can yu look at this - Re: end of WGLC, RE: working
> group
> > last call for draft-ietf-mpls-lsp-ping-reply-mode-simple-01
> >
> > Tom,
> >
> > The question you and Adrian asks is what to do if the Reply Mode
> > Order TLV is missing.
> >
> > There is something fishy here, I'd like George to look at this.
> >
> > The LSP Ping design says that TLVs from this range may be silentsly
> > dropped, my take is that we don't need to specify anything more
> > than that.
> >
> > Now, we say that it MUST be present, and after thinking around a bit
> > I wonder if the TLV should be assigned from the mandatory range instead?
> >
> > Or if the MUST be present means that the message will be malformed if
> > it is not there, and the message should be discarded.
> >
> > OK - now I'm confused.
> >
> > /Loa
> >
> > On 2015-04-23 13:02, t.petch wrote:
> > > ---- Original Message -----
> > > From: "Loa Andersson" <loa@pi.nu>
> > > Sent: Wednesday, April 22, 2015 2:15 PM
> > >
> > >> Tom,
> > >>
> > >> On 2015-04-20 00:07, Nobo Akiya wrote:
> > >>>      <tp>
> > >>>
> > >>>      Yes but ... I think that it is a change of meaning.  Is is
> > > enough just
> > >>>      to ignore the TLV or should the whole PDU be discarded?  I find
> > > it
> > >>>      difficult to know but don't feel strongly about that choice so
> > > will go
> > >>>      with what you suggest.
> > >>>
> > >>>      </tp>
> > >>
> > >> So I don't misunderstand what you are saying. It seems to me like the
> > >> comments made by Adrian and you actually requires a "change of
> > > meaning",
> > >> that is kind of essence of a "comment", right?
> > >>
> > >> As for what to do with if the TLV is not recognized, it is
> > >> intentionally requested from a space where it can be silently dropped
> > >> (i.e. "ignored").
> > >>
> > >>      The new TLV Type value should be assigned from the range
> > >>      (32768-49161) specified in [RFC4379] section 3 that allows the
> TLV
> > >>      type to be silently dropped if not recognized.
> > >>
> > >>        Type   Meaning                            Reference
> > >>        ----   -------                            ---------
> > >>        TBD1   Reply Mode Order TLV               this document
> > >>
> > >> What is it that I miss?
> > >
> > > Nothing serious.  My initial thought was to echo Adrian, that, at least
> > > in this context, there should be an indication what to do if a MUST or
> > > SHOULD was violated without just then having a clear sense of what it
> > > should be instead.
> > >
> > > The I-D did require (MUST) one entry in the TLV and wanted (SHOULD)
> > > more.  Adding what to do if that did not happen I was seeing as
> > > clarification.  I then read Nobo as proposing going a bit further
> saying
> > > requires (MUST) one or more.  Which might lead to boxes taking a
> > > simplistic approach and always putting in the new TLV with a single
> > > entry and ignoring the traditional TLV.  Not a problem just a change
> > > from what others might think that they have consented to.
> > >
> > > On the question of what to do when the rules are violated, again I did
> > > not initially think of what the action should be.  On reflection, I am
> > > still unsure.  I understand that the Reply Mode Order TLV  is optional
> > > and so can be ignored when not understood; that's fine.  But if it is
> > > understood and can be seen to be defective, should the box with that
> > > knowledge discard just that TLV and accept the remainder of the
> message?
> > > Or should it argue that if this TLV is defective, then likely the rest
> > > is as well and should be ignored?  I am unsure.
> > >
> > > If there is scope for a breach of security, or taking a hit in
> > > performance, then ignore is the right policy. If the requirement is to
> > > get as much data as possible from a failing network, then use it is the
> > > right policy.  As long as the I-D is clear, I am not too fussed which
> > > way it goes.  I am content with the changes that Nobo has proposed.
> > >
> > > Tom Petch
> > >
> > >> /Loa
> > >>
> > >> --
> > >>
> > >>
> > >> Loa Andersson                        email: loa@mail01.huawei.com
> > >> Senior MPLS Expert                          loa@pi.nu
> > >> Huawei Technologies (consultant)     phone: +46 739 81 21 64
> > >
> >
> > --
> >
> >
> > Loa Andersson                        email: loa@mail01.huawei.com
> > Senior MPLS Expert                          loa@pi.nu
> > Huawei Technologies (consultant)     phone: +46 739 81 21 64
> >
> > _______________________________________________
> > mpls mailing list
> > mpls@ietf.org
> > https://www.ietf.org/mailman/listinfo/mpls
>
>