Re: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr

Huaimo Chen <huaimo.chen@futurewei.com> Tue, 09 June 2020 03:52 UTC

Return-Path: <huaimo.chen@futurewei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C94393A0845; Mon, 8 Jun 2020 20:52:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.089
X-Spam-Level:
X-Spam-Status: No, score=-2.089 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E5ftdt_1JLTE; Mon, 8 Jun 2020 20:52:24 -0700 (PDT)
Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680120.outbound.protection.outlook.com [40.107.68.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1C8E23A0841; Mon, 8 Jun 2020 20:52:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KTrKxXAp6OZwigR/V5kYqqq+Iqm/fBUuxVV6o5A72b7BLFx0IAHlEyDi5PQBrNr9zROQnb3V05OqEWxz9zs8GnD2kB8a/gJrfa4d/DsTwY29T98U7FCPac/aF3D/aFL0PIkDAIdZ7fv+aiU+fwMiTb0ULtrd4N4Gzzpm97eZ9FSc4UXORDUJV7TGFQMb5vRH1inoVXdpasncCQy7MjA+isGeWmAK7HMgBt5g/greloxJ0wtTlrzh4a5edasrBrfyjhqKqvZKM1OoNRbsiyu5J2RtPMuNUNMTf74QF+GGAMOblDDpHrS6JP2zZUgIx8ULmzpGvOnV4GQOr5f51Uhj8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHlw59+ITiov2Khok3efDe/GC4UU71HRKAfJ4AOjGrw=; b=eYZgcMPY/7oFq2tvkXoim2HWVAkaY5ay9T5Yh+bSboBqj8lqB+WLy5kXAppnwUuQsjA+JsEMDzFbA5l8mYZ4DfXeov0f0tSIfDXW7PHbBMBtgSc4Laub1t/dPEYRi3KFcD155szSUkQe5X7Fr7f9DXrJGVNE2ZG/n1hs112L5bCCWt7MaPyGCC5UfGYcaj+Yyt5BbMOc5OuYyMkvQOr1aqarkBAU1fnPuDNYVOZvdec/tNGoHk/MiDzU0WjCZ34bu22ttY+BB/Z6dh+a9hPQAopsFHDAQWdNWFPoWQ4BTIJGtBtQSFvgsWt7BLukjr6g0IZxaL4pHTLXpHeML7+RZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XHlw59+ITiov2Khok3efDe/GC4UU71HRKAfJ4AOjGrw=; b=YnL3b+BpSBclixZZHlVwTGROa0sAS6t6GYUes+wVAHy+CSPkNn521bNQy4OsoxDSktNGdkf14lGp76RNpLlZPYFfdZ1PMVLcoeW8t3FVutfH11fI0/T54J6yLO+5wHcOzbp2VK6YQtOz0CxBbvewsAaZDSUpV1xcp4aY75Yxa74=
Received: from MN2PR13MB3117.namprd13.prod.outlook.com (2603:10b6:208:13a::20) by MN2PR13MB3725.namprd13.prod.outlook.com (2603:10b6:208:1e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.10; Tue, 9 Jun 2020 03:52:21 +0000
Received: from MN2PR13MB3117.namprd13.prod.outlook.com ([fe80::d5b6:8550:9c40:eec2]) by MN2PR13MB3117.namprd13.prod.outlook.com ([fe80::d5b6:8550:9c40:eec2%7]) with mapi id 15.20.3088.016; Tue, 9 Jun 2020 03:52:21 +0000
From: Huaimo Chen <huaimo.chen@futurewei.com>
To: Tarek Saad <tsaad.net@gmail.com>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-gandhi-mpls-rfc6374-sr@ietf.org" <draft-gandhi-mpls-rfc6374-sr@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr
Thread-Index: AQHWI7UWOG/zz9wDNU+Ica/MrmV3JqjPxRCt
Date: Tue, 9 Jun 2020 03:52:20 +0000
Message-ID: <MN2PR13MB3117086E43C785B4A327D942F2820@MN2PR13MB3117.namprd13.prod.outlook.com>
References: <CH2PR19MB40241A395AAD7976CD74FE11FCA40@CH2PR19MB4024.namprd19.prod.outlook.com>
In-Reply-To: <CH2PR19MB40241A395AAD7976CD74FE11FCA40@CH2PR19MB4024.namprd19.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=futurewei.com;
x-originating-ip: [2601:199:4300:8e5a:aca9:5327:a72:f506]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56b60548-2ccd-471a-9c3a-08d80c288310
x-ms-traffictypediagnostic: MN2PR13MB3725:
x-microsoft-antispam-prvs: <MN2PR13MB372555EAD44121DE56F6B095F2820@MN2PR13MB3725.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 042957ACD7
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gBaGbxxKa92ovY2O0qv3vnAHOLXLRYCcGgDSIqu8CSzQpkeRYEbKgpZNT/rj6Ns5XFk+NC9ri4KGt89ICZn4ZRKztJMZNBmHXmU0ZfGWntSgBLIERQjzXTCyqdJGk6x+j0clok6zhkMiSTwdLm2NrF4dTtumG2jr+8wSBZaBVyRnDFIWJ2zoIV33L81D7diYwwpN6wHmwYQtvd0CwQSlt9Pto0AlU75KWtWxYie8SnejjjvUjC6r70v+6mzulUZ0Im7+3wDJ+ZtjMDalX1zTNwpvAKKqKNx8+mtl1uZsz2c8bz3QU/3FdcCcFbqoEgbh
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR13MB3117.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(376002)(346002)(366004)(39850400004)(66446008)(64756008)(186003)(2906002)(7696005)(71200400001)(316002)(76116006)(66946007)(66556008)(66476007)(33656002)(52536014)(19627405001)(8936002)(86362001)(5660300002)(8676002)(6506007)(44832011)(83380400001)(55016002)(6916009)(9686003)(54906003)(4326008)(478600001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: +N8r5pUTN6nFRczN6OQu8uD0OQK44hFn794gP4kTcOPJQkT3tCKtCW/TRAr6LXWuYDOPHxVL8wYY6Xgo0pfjO3C96yqNBrt5ceTMZoE6P0RSzEfPsvd51kbePDReCC2yRpZQDKIZ3aR2oc30R6ti2Bn3CWSbkcbXEygSiXBw6XQI5NVAiUNVELi9rl0KkdtLIOODTfVxySq9gBiH+JIxMoSTirE+mgpWcSY2eJSQRqM2aO4+Tsy5Evdbl+wCvF6hGeBbKlczfeuAyg4Qk6v7vhpsnVPdQCeE/rMT3WvRdDywTLWgLz38rA6mH34GHOoyNO3RFKBivYxorVjDYlrRif2SMDj8YFdMWddOzcf5+l6Myypw565Qk5lTB6JOVzYy/1cOjCtlXQzVf5Z3Qlj9N0TbkIEKiHuFdjgaBX2HbNccj5J/68jpChDFfC+qcCVRf8EOo5WqB0Tv5sqBnqwe+FmGo5XWnhc+LN7cK0AidMtX2uC1G5diKytEMQtXOq63ST+fcJUjJ/rK3AhpuzOsDI1EsjD2xmaqIwILG58GHkM=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_MN2PR13MB3117086E43C785B4A327D942F2820MN2PR13MB3117namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56b60548-2ccd-471a-9c3a-08d80c288310
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 03:52:20.9564 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4TGStHx+BiuOCWjH1C8MgihtWfPK5rbZW1sBrJMi2wCCy/9ilUdMA0W2zjINLuxLSmwhQzE9usus1cnIW/Woew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3725
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/qmkcM4lKizbvucpRyY2ZMScWifQ>
Subject: Re: [mpls] MPLS-RT experts review for draft-gandhi-mpls-rfc6374-sr
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 03:52:26 -0000

Hi All,

    I have reviewed the document and have the following comments.

    1.  The document is useful and technically sound. It can be considered for WG adoption.

    2.  The document seems talking about the Loss Measurement Message and Delay Measurement Message. Should it have some texts for Combined Loss/Delay Measurement Message?

    3.  There are a couple of IETF drafts about SR P2MP Path. The document just mentions one of them and the Performance Measurement for a SR P2MP Path (or policy) is based on this one draft. Should the Performance Measurement for a SR P2MP Path (or policy) be general enough for all?

    4.  It seems that the Performance Measurement for a SR P2MP Path (or policy) is limited to one way and out-of-band. Should the document add some texts talking about these limitations?

    5.  The registry for the newly defined Return Path TLV Type and Block Number TLV Type is missing in the document. Is it the "MPLS Loss/Delay Measurement TLV Object" registry?

    6.  It seems that a new registry should be defined for the Sub-TLV types under the Return Path TLV in the document.

    7.  In section 5.1. and section 6.1., Should "For both SR Links and end-to-end measurement for SR-MPLS Policies" be changed to something like "For both SR Links and end-to-end SR-MPLS Policies measurements"?

    8.  In section 6.2., should something like a user case be added into the sentence "The Block Number TLV is Mandatory when used."?


Best Regards,
Huaimo