Re: [mpls] MPLS-RT review of draft-bonica-mpls-self-ping

Eric Gray <eric.gray@ericsson.com> Mon, 16 March 2015 15:37 UTC

Return-Path: <eric.gray@ericsson.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B3E631A8757 for <mpls@ietfa.amsl.com>; Mon, 16 Mar 2015 08:37:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7FYMemCQW50v for <mpls@ietfa.amsl.com>; Mon, 16 Mar 2015 08:37:41 -0700 (PDT)
Received: from usevmg21.ericsson.net (usevmg21.ericsson.net [198.24.6.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE7CE1A1A91 for <mpls@ietf.org>; Mon, 16 Mar 2015 08:37:40 -0700 (PDT)
X-AuditID: c6180641-f790b6d000004359-25-55069746377c
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id CA.2C.17241.64796055; Mon, 16 Mar 2015 09:41:43 +0100 (CET)
Received: from EUSAAMB107.ericsson.se ([147.117.188.124]) by EUSAAHC002.ericsson.se ([147.117.188.78]) with mapi id 14.03.0210.002; Mon, 16 Mar 2015 11:37:38 -0400
From: Eric Gray <eric.gray@ericsson.com>
To: Ronald Bonica <rbonica@juniper.net>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>, Gregory Mirsky <gregory.mirsky@ericsson.com>, "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>, "draft-bonica-mpls-self-ping@tools.ietf.org" <draft-bonica-mpls-self-ping@tools.ietf.org>
Thread-Topic: MPLS-RT review of draft-bonica-mpls-self-ping
Thread-Index: AQHQXN6YwFyPxHc7rEytr3W8I9B8jp0fIZ6g
Date: Mon, 16 Mar 2015 15:37:37 +0000
Message-ID: <48E1A67CB9CA044EADFEAB87D814BFF632CAC16B@eusaamb107.ericsson.se>
References: <54EC4776.5040402@pi.nu> <54F7C742.10906@pi.nu> <7347100B5761DC41A166AC17F22DF1121B91CA76@eusaamb103.ericsson.se> <CO1PR05MB44272B31CD58E4CC42D040EAE060@CO1PR05MB442.namprd05.prod.outlook.com> <010301d05cd5$4bd9d1a0$e38d74e0$@olddog.co.uk> <CO1PR05MB4424DBEDC620A84443865DFAE060@CO1PR05MB442.namprd05.prod.outlook.com>
In-Reply-To: <CO1PR05MB4424DBEDC620A84443865DFAE060@CO1PR05MB442.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.10]
Content-Type: multipart/alternative; boundary="_000_48E1A67CB9CA044EADFEAB87D814BFF632CAC16Beusaamb107erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsUyuXSPn677dLZQg7/7uSx+9Nxgtuhtn89u seRlB7vF90tLWCxuLV3JanHgu4MDm8eSJT+ZPK43XWX3WLF5JaPHl8uf2QJYorhsUlJzMstS i/TtErgybjW8Yy7YsYq5YsqtXawNjGvmM3cxcnJICJhI7P89ix3CFpO4cG89G4gtJHCEUWLG fMcuRi4gezmjRNu7g0wgCTYBDYljd9YygiREBBYwScy+fY0VJMEsECXRdPck2FRhASuJ/Wcv gk0VEbCWeH9lAguEbSQxp2En2CAWAVWJF0fOgW3jFfCVeLfvGDPEtktMEu++/AVr5hSIlvix 4jYjiM0IdN73U2uYIJaJS9x6Mp8J4mwBiSV7zkO9Iyrx8vE/VghbSWLS0nNANgdQfb7Eos9c ELsEJU7OfMIygVF0FpJJsxCqZiGpgghrSqzfpQ9RrSgxpfshO4StIdE6Zy47svgCRvZVjByl xalluelGhpsYgRF5TILNcQfjgk+WhxgFOBiVeHg3XGMNFWJNLCuuzD3EKM3BoiTOW3blYIiQ QHpiSWp2ampBalF8UWlOavEhRiYOTqkGRuuQlpPv9z07qjQn19A37AfnBd0LB/0FI7vEhIyV JyoJLc29Ejlvk5N64qJZMraCW8P+XI12C6k4fc3zht+RHhtN2SnNW+9XXTv/+PrlK92Lr9o4 8txfKHdo3kOejklJFw9Oltn4Y1VvIud9l94PbXv3hi7lPPz9t9Ej9g/7Nlb8YT6QtJf7Q5AS S3FGoqEWc1FxIgAQHodBqQIAAA==
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/UH2FcJFQvFgQBQ3qpMumLSTE5Jo>
Cc: "mpls-ads@tools.ietf.org" <mpls-ads@tools.ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-bonica-mpls-self-ping
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2015 15:37:44 -0000

Ron,

                I would be careful in using RFC 2119 language, to address only those
things that are externally visible.  There are not many in this draft, but a few
cases exist where use of SHOULD could tighten up the specification.

                I have a few comments as well.

                I noticed an ambiguity in the last bullet on page 4 (carried forward to
page 5):  I assume the intention is that optional use of a back-off algorithm
applies only to the timer expiry case (the current phrasing separates the step
of decrementing the retry from the optional additional step of increasing the
retry timer).  I suggest changing the last two sentences to read:

“Otherwise, decrement retries and, optionally, increase the value of retry-timer
  according to an appropriate back-off algorithm.”

                In section 3, it would be clearer why the bi-directional LSP case remains
distinct from bi-directional LSP Ping, if the word “independently” were added
between “LSP endpoint” and “tests LSP readiness” – however, there is still an
area of confusion that exists in this case: independent testing means readiness
is determined independently.

                This is fine if the only thing each LSP endpoint is trying to find out is if it
can forward packets using the LSP.  It is not as useful, if the status of the LSP is
dependent at either endpoint (e.g. – the initiator of the LSP setup) on the status
of the bidirectional LSP connectivity.

                This might be the case, for example, if a bi-directional LSP is used by an
implementation as an interface and the interface status depends on the ability
to use it in both directions.

                Should the draft say anything along these lines?

                The scenario in the Security Considerations section seems more than
usually contrived (i.e. – the vulnerability seems to be that of an attack that is
extremely feeble).

                The intent of the draft – as I understand it – is to ensure that traffic is
not switched onto an LSP that may not yet be functional as a result of a narrow
window of opportunity resulting from a race condition introduced by providing
a RESV message with label binding in parallel with the somewhat independent
installation of forwarding state information corresponding to the label binding.

                The window of opportunity for attack is then the time during which an
ingress LSR has received label binding information, and the time when each of
the LSRs on the LSP have actually installed corresponding forwarding state.  In
fact, the window is slightly narrower than that, given control and data plane
forwarding delays that allow slightly more time for forwarding state installation.

                During this time, an attacker needs to become aware that the ingress is
attempting to determine if the LSP is fully functional before transferring traffic
from some other path onto the LSP (it is possibly worth noting that – if there is
no other path, then there is little difference between forwarding them on a
possibly incomplete LSP or discarding them directly).

                As this window should be very narrow, the most likely scenario for this
to become a problem is if the attacker is a subverted LSR on the LSP, which may
then monitor LSP data traffic looking for this type of message, intercept it and
return it to the sending ingress LSR.

                If a transit LSR has been subverted, it is fairly obvious that this would be
the feeblest form of attack that the subversion might take, given that it could do
so many other things.

                If we really want to list this potential vulnerability, we should probably
say something about the associated (very low) risk, mitigating circumstances
and means of detection.

                Meanwhile, another form of attack might be if one or more LSRs in a
given MPLS domain were to start sending these self-ping messages at capacity
speeds.  Because they are at the data-plane, this attack vector might be harder
to detect at any affected egress LSR.  Meanwhile these messages consume at
least some of the network capacity across the network in both directions.

--
Eric

From: mpls [mailto:mpls-bounces@ietf.org] On Behalf Of Ronald Bonica
Sent: Thursday, March 12, 2015 12:06 PM
To: adrian@olddog.co.uk; Gregory Mirsky; mpls-chairs@tools.ietf.org; draft-bonica-mpls-self-ping@tools.ietf.org
Cc: mpls-ads@tools.ietf.org; mpls@ietf.org
Subject: Re: [mpls] MPLS-RT review of draft-bonica-mpls-self-ping



Works for me!

                   Ron


From: Adrian Farrel [mailto:adrian@olddog.co.uk]<mailto:[mailto:adrian@olddog.co.uk]>
Sent: Thursday, March 12, 2015 11:01 AM
To: Ronald Bonica; 'Gregory Mirsky'; mpls-chairs@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>; draft-bonica-mpls-self-ping@tools.ietf.org<mailto:draft-bonica-mpls-self-ping@tools.ietf.org>
Cc: mpls-ads@tools.ietf.org<mailto:mpls-ads@tools.ietf.org>; mpls@ietf.org<mailto:mpls@ietf.org>
Subject: RE: MPLS-RT review of draft-bonica-mpls-self-ping

Looks informational to me. And looks like 2119 language is appropriate.

Thanks,
Adrian

From: Ronald Bonica [mailto:rbonica@juniper.net]
Sent: 12 March 2015 01:24
To: Gregory Mirsky; mpls-chairs@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>; draft-bonica-mpls-self-ping@tools.ietf.org<mailto:draft-bonica-mpls-self-ping@tools.ietf.org>
Cc: mpls-ads@tools.ietf.org<mailto:mpls-ads@tools.ietf.org>; mpls@ietf.org<mailto:mpls@ietf.org>
Subject: RE: MPLS-RT review of draft-bonica-mpls-self-ping

Greg,

In the message below, you question whether draft-bonica-mpls-self-ping should be INFORMATIONAL or PS. In a similar vein, you ask whether RFC 2119 language should be used.

When I wrote the draft, I considered both, couldn’t decide, and tossed a coin ;-)

AFAIKS, the IETFs criteria for PS are a bit fuzzy. You might argue that the draft should be PS because it defines “bits on the wire”. But on the other hand, you might argue that it doesn’t need to be PS because:


-          It doesn’t address interoperability requirements (because the sender and receiver are the same node)

-          It doesn’t request any IANA assignments

I would be very happy to let somebody else decide whether the draft should be INFORMATIONAL or PS. Maybe the chairs or ADs can offer an opinion?

                                                                                                   Ron



From: Gregory Mirsky [mailto:gregory.mirsky@ericsson.com]
Sent: Monday, March 09, 2015 5:02 PM
To: mpls-chairs@tools.ietf.org<mailto:mpls-chairs@tools.ietf.org>; draft-bonica-mpls-self-ping@tools.ietf.org<mailto:draft-bonica-mpls-self-ping@tools.ietf.org>
Cc: mpls-ads@tools.ietf.org<mailto:mpls-ads@tools.ietf.org>; mpls@ietf.org<mailto:mpls@ietf.org>
Subject: RE: MPLS-RT review of draft-bonica-mpls-self-ping

Dear All,
I've been assigned to review draft-bonica-mpls-self-ping.
The document is very well written, the problem in focus is clearly stated, and the proposed solution well described.
I do have a number of concerns with the status of the document and the approach as presented:
•         document intended track is Informational even though the solution being positioned as "new, light-weight protocol". If this is indeed new protocol or even extension of the existing one, then I expect there must be requests to IANA allocations. At this time "This document makes no request of IANA." Either LSP Self-ping can be characterized through re-use of already existing protocols and approaches, or document should be switched to Standards track;