Re: [mpls] MPLS-RT review on draft-ninan-mpls-spring-inter-domain-oam-02

Mach Chen <mach.chen@huawei.com> Fri, 04 June 2021 01:55 UTC

Return-Path: <mach.chen@huawei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 983253A232F; Thu, 3 Jun 2021 18:55:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mm7Mj4MYVB4Z; Thu, 3 Jun 2021 18:55:12 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 09EB53A2328; Thu, 3 Jun 2021 18:55:12 -0700 (PDT)
Received: from fraeml742-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Fx5Jg4yLsz6F81j; Fri, 4 Jun 2021 09:48:35 +0800 (CST)
Received: from dggpemm500001.china.huawei.com (7.185.36.107) by fraeml742-chm.china.huawei.com (10.206.15.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 03:55:08 +0200
Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 09:55:06 +0800
Received: from dggpemm500002.china.huawei.com ([7.185.36.229]) by dggpemm500002.china.huawei.com ([7.185.36.229]) with mapi id 15.01.2176.012; Fri, 4 Jun 2021 09:55:06 +0800
From: Mach Chen <mach.chen@huawei.com>
To: Shraddha Hegde <shraddha@juniper.net>, "draft-ninan-mpls-spring-inter-domain-oam@ietf.org" <draft-ninan-mpls-spring-inter-domain-oam@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: MPLS-RT review on draft-ninan-mpls-spring-inter-domain-oam-02
Thread-Index: AddXYNePcnIVic4hQKi6eG9X0nDXKwAb904gAETnlEA=
Date: Fri, 04 Jun 2021 01:55:06 +0000
Message-ID: <44283e3adaa1487d860630f97c57d85b@huawei.com>
References: <5c57943cc68c4457ae622086cd484500@huawei.com> <CY4PR05MB35768F1AC7E75407EE4C1E88D53C9@CY4PR05MB3576.namprd05.prod.outlook.com>
In-Reply-To: <CY4PR05MB35768F1AC7E75407EE4C1E88D53C9@CY4PR05MB3576.namprd05.prod.outlook.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.108.243.140]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/UXdChzljHDvJr0t-3RUIiobQPYY>
Subject: Re: [mpls] MPLS-RT review on draft-ninan-mpls-spring-inter-domain-oam-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2021 01:55:17 -0000

Hi Shraddha,

Thanks for considering the comments, looking forward to the revision.

Best regards,
Mach

> -----Original Message-----
> From: Shraddha Hegde [mailto:shraddha@juniper.net]
> Sent: Thursday, June 3, 2021 12:30 PM
> To: Mach Chen <mach.chen@huawei.com>;
> draft-ninan-mpls-spring-inter-domain-oam@ietf.org
> Cc: mpls-chairs@ietf.org; mpls@ietf.org
> Subject: RE: MPLS-RT review on draft-ninan-mpls-spring-inter-domain-oam-02
> 
> Hi Mach,
> 
> Thanks for the review.
> Pls see inline ...
> 
> 
> Juniper Business Use Only
> 
> -----Original Message-----
> From: Mach Chen <mach.chen@huawei.com>
> Sent: Wednesday, June 2, 2021 9:29 AM
> To: draft-ninan-mpls-spring-inter-domain-oam@ietf.org
> Cc: mpls-chairs@ietf.org; mpls@ietf.org
> Subject: MPLS-RT review on draft-ninan-mpls-spring-inter-domain-oam-02
> 
> [External Email. Be cautious of content]
> 
> 
> Hi,
> 
> I am selected as a MPLS-RT reviewer of
> draft-ninan-mpls-spring-inter-domain-oam.
> 
> After review, I think the problem that the draft is trying to address is valid and
> useful. The solution is overall workable. My comments are mainly about Type 3
> and Type 4 segment sub-TLV, I think it's better to address these comments
> before the adoption.
> <Shraddha> Sure.
> 
> Type 3 and 4 sub-TLVs are supposed to be used when the headend/PMS does
> not have the labels or SRGB information of the remote nodes, <Shraddha> yes
> because  these remote nodes lie in a different domain and SRGB information
> may not be available at the headend in some cases.
> 
>  and assume that the receiving node (egress node) can derive the MPLS labels
> according to the IPv4/IPv6 addresses.
> <Shraddha>
> I will add a section with  example of multi-domain network with different SRGB
> and explain how Type 3 and Type 4 Segments can be used while building the
> return path dynamically for traceroute. The key is only the top segment has to be
> Type 3/Type 4 the remaining segments to be of type label. For the Top segment,
> label has to be derived from the SRGB of the receiving node (not someone else's)
> so its expected to be available.
> 
> 
> This assumption may not hold, because given that the headend/PMS does not
> have the information, it is very likely that the receiving node has no the
> information either. So the draft should add more text to clarify the use cases of
> type 3, 4 sub-TLVs, or just remove them.
> <shraddha> I'll add more text to describe clearly how type3/Type 4 should be
> used.
> 
> In addition, given type 3 and 4 have valid use case, the optional SID fields of type
> 3 and 4 are redundant, I think that they should be removed.
> <shraddha> SIDs are optional anyway. I would prefer to keep it in order to be
> consistent with segment routing
> path description.
> 
> Section 4,
> "Below types of segment sub-TLVs are applicable for the Reverse Path
>    Segment List TLV."
> 
> Should the "Reverse Path Segment List TLV" be "Return Path TLV"?
> <shraddha> Good catch. I'll fix it.
> 
> Best regards,
> Mach