[mpls] MPLS-RT review of draft-esale-mpls-ldp-rmr-extensions-02

"Andrew G. Malis" <agmalis@gmail.com> Tue, 12 June 2018 18:53 UTC

Return-Path: <agmalis@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2BA56130E5A; Tue, 12 Jun 2018 11:53:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FB74u2BwrYGx; Tue, 12 Jun 2018 11:53:27 -0700 (PDT)
Received: from mail-ot0-x232.google.com (mail-ot0-x232.google.com [IPv6:2607:f8b0:4003:c0f::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5A2D0130E77; Tue, 12 Jun 2018 11:53:27 -0700 (PDT)
Received: by mail-ot0-x232.google.com with SMTP id w13-v6so29308296ote.11; Tue, 12 Jun 2018 11:53:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=OLKL0Vfpo2MRDuiWngsTpKqS55JUMyfoF3eejXFn3fE=; b=Sr5X2SNxbb49NFCwqkpqPNlrJWzyirE0a4GWowF6moPU2onFtSCEH9c9rapmKZpdhB YOenZVY8ubjQ2UfUI/jS9Qw9GAV+y3kgZjaWK8PsP7Q7dIvb5lIfz1ZuLuRIHkH9RCdw rDrJ1vGgdORno8cM9BnzdBMg5Um2kqQ+bz9fG7Kzo1bgv0/OjJZGfBgfVpvQm6+7zRlP ZUjTla84iCUndYsiJCw3uAaQKgbW4oUdnZgQGqY7E1sSMLdehOelop+FplWsl6ZYEoZs Akcelm41JTW74dlnl5F5RKt8yDht36Kw+BE9bw1v0HCogPphXYzhbVs+Lt1QzAGp/IVe AG2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=OLKL0Vfpo2MRDuiWngsTpKqS55JUMyfoF3eejXFn3fE=; b=VzD9RtIY6idbKqXSq6dGbg2xLsPxp0v8dIsXcUw+pKg7t7dd1uJaBePMAppY5fPgJR NSOnsTGOpqyCXJ/ulfTz8ZXuwqEenXrXR4eRhNIgMZhmvQ1s83ZSy2y0Isw7axWKNm/Y P0MBCr1zhT05QCNGs0YN8dUPS8hnjRkxFGlit99csRIlWs9Aw7OIfpMCAHrjVD1+/SK8 7BwApYZ40+jkqwqK6PeYkIoGrZd32BGNLnX8bTL84kIG4BaxCD5akOSZeTlGr/9qKjBx thtiC5fuJ2Oie629dRk2AP0FZI2rJ8jAzeccmmTCh15PIVgKD0GoeU9ynOU7THV0jx2n lc+Q==
X-Gm-Message-State: APt69E0QGJQJBYi1h/oahY1i2rV4UtxIVUEAcIxvE20rm0lNORPRakIW RCG9Vv+iEBqvAQtGQtYToWiUWK3TP9wgZjnQ04yJMQ==
X-Google-Smtp-Source: ADUXVKLtVZYO/SQFr2RwKsFqjWpre0MG7bx9tzUe/AWsE5EWLhFVl6AeXe91qavL+ukMpF0ijevde1/eV3JRe8DxGmw=
X-Received: by 2002:a9d:42b0:: with SMTP id r45-v6mr1218090ote.44.1528829606473; Tue, 12 Jun 2018 11:53:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a9d:30c3:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 11:53:06 -0700 (PDT)
From: "Andrew G. Malis" <agmalis@gmail.com>
Date: Tue, 12 Jun 2018 14:53:06 -0400
Message-ID: <CAA=duU0dKCTHbZCw6XuVJSo72ExUuXVxRgzWwhvw1f3HbrGHuA@mail.gmail.com>
To: mpls@ietf.org
Cc: draft-esale-mpls-ldp-rmr-extensions@ietf.org, mpls-chairs <mpls-chairs@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000009db38b056e766152"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/VzpMtgU6M_oQPw_SU3apSh4mnhU>
Subject: [mpls] MPLS-RT review of draft-esale-mpls-ldp-rmr-extensions-02
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 18:53:31 -0000

I’ve been selected as an MPLS-RT reviewer
for draft-esale-mpls-ldp-rmr-extensions, which is currently a candidate for
MPLS WG adoption.

This draft documents the extensions required to LDP in order to signal
resilient MPLS ring LSPs, based on the architecture for RMRs described
in draft-ietf-mpls-rmr-02.

The MPLS WG has already accepted RMR work in general as a WG project, so
the primary question for draft-esale-mpls-ldp-rmr-extensions-02 isn’t
whether or not the draft should be accepted as a WG draft, but rather is it
ready for WG adoption?

In general, I found the described extensions to LDP, and their operation,
clearly written to the extent that they can easily be the basis for WG
input and review. The authors have taken the draft to the point where wider
WG review that would result from adoption is necessary.

Thus, my opinion is that the draft is ready for WG adoption at this time.

I have one nit that can be resolved either before or after adoption. In
section 4.2.2, the section begins:

   A node X wishing to participate in LDP RMR signaling SHOULD negotiate
   the RMR capability with all its neighbors.


I would think that should be a MUST rather than a SHOULD.

Cheers,
Andy