[mpls] Alvaro Retana's No Objection on draft-ietf-mpls-lsp-ping-relay-reply-10: (with COMMENT)

["Alvaro Retana" <[e-mail]>]

Alvaro Retana has entered the following ballot position for
draft-ietf-mpls-lsp-ping-relay-reply-10: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mpls-lsp-ping-relay-reply/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I have some comments/questions:

1. TBD2 is the Relay Node Address Stack TLV Type.  There seems to be some
confusion in the text: Section 4.2. (Receiving an Echo Request)  says
that the "Type of the Relay Node Address Stack TLV is chosen from the
range 32768 to 49161…” giving the impression that any value can be used,
while 8.2. (New TLV) in the IANA Considerations says that a "suggested
value should be assigned” giving me the impression that the assignment is
just a suggestion (and somehow reinforcing the text in 4.2), but the
original definition in 3.2. (Relay Node Address Stack) simply says that
the "value should be assigned by IANA”.  Assuming that you simply want an
assignment and that it would be what is used, please clean the text up; I
suggest just referring to the value as TBD2 (in 4.2 and 8.2) and
explicitly including the text about the assignment and the range (from
3.2) in 8.2.

2. Section 4.1. (Sending an Echo Request) says that the "Relay Node
Address Stack TLV MUST be carried in the Echo Request message if the
relay functionality is required”.  How does the initiator know that it
needs the functionality?

3. Section 4.2. (Receiving an Echo Request) "A second or more address
entries MAY also be added if necessary, depending on implementation.” 
Isn’t this document defining how the implementation should work?  What
are the cases where these additional entries may be added?